fix: use a runtime.Type type switch instead of a string match#1760
Merged
fabianburth merged 2 commits intoFeb 11, 2026
Conversation
jakobmoellerdev
previously approved these changes
Feb 11, 2026
c0a9a2f to
b546b35
Compare
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
b546b35 to
d1f35f7
Compare
Skarlso
commented
Feb 11, 2026
fabianburth
approved these changes
Feb 11, 2026
jakobmoellerdev
approved these changes
Feb 11, 2026
morri-son
pushed a commit
to morri-son/open-component-model
that referenced
this pull request
Feb 18, 2026
…omponent-model#1760) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Shouldn't use string matching for type assertion. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Shouldn't use string matching for type assertion.
Which issue(s) this PR fixes