feat: register helm as inbuilt input plugin#1756
Merged
jakobmoellerdev merged 1 commit intoFeb 12, 2026
Merged
Conversation
001041f to
e9578fa
Compare
4bfa95a to
8030c29
Compare
matthiasbruns
previously approved these changes
Feb 12, 2026
bbd3f9c
5226a32 to
c69f15e
Compare
Skarlso
reviewed
Feb 12, 2026
<!-- markdownlint-disable MD041 --> Registers the helm input method as a built-in plugin in the CLI. The existing `bindings/go/helm/input.InputMethod` already implements the `BuiltinResourceInputMethod` interface. - Adds `cli/internal/plugin/builtin/input/helm/method.go` with a `Register` function - Registers it in `cli/internal/plugin/builtin/builtin.go` - Adds `bindings/go/helm` dependency to `cli/go.mod` - Updates integration test to use builtin helm plugin by default with a toggle for standalone mode <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes: open-component-model/ocm-project#876 Signed-off-by: Piotr Janik <piotr.janik@sap.com>
c69f15e to
f3dacd8
Compare
Skarlso
approved these changes
Feb 12, 2026
matthiasbruns
approved these changes
Feb 12, 2026
Member
|
@Skarlso we need to get a better view on the plugin directory. can you please double check this is documented properly? I didnt see any mention of it in any reference doc. (maybe im missing it) |
morri-son
pushed a commit
to morri-son/open-component-model
that referenced
this pull request
Feb 18, 2026
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Registers the helm input method as a built-in plugin in the CLI. The existing `bindings/go/helm/input.InputMethod` already implements the `BuiltinResourceInputMethod` interface. - Adds `cli/internal/plugin/builtin/input/helm/method.go` with a `Register` function - Registers it in `cli/internal/plugin/builtin/builtin.go` - Adds `bindings/go/helm` dependency to `cli/go.mod` - Updates integration test to use builtin helm plugin by default with a toggle for standalone mode #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes: open-component-model/ocm-project#876 <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Signed-off-by: Piotr Janik <piotr.janik@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Registers the helm input method as a built-in plugin in the CLI.
The existing
bindings/go/helm/input.InputMethodalready implements theBuiltinResourceInputMethodinterface.cli/internal/plugin/builtin/input/helm/method.gowith aRegisterfunctioncli/internal/plugin/builtin/builtin.gobindings/go/helmdependency tocli/go.modWhich issue(s) this PR fixes
Fixes: open-component-model/ocm-project#876
What this PR does / why we need it
Which issue(s) this PR fixes