feat!: make OCM configurations propagate through resource reference#1752
Merged
Skarlso merged 7 commits intoFeb 11, 2026
Conversation
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
… effective config On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
frewilhelm
reviewed
Feb 10, 2026
Contributor
|
Can you please adjust one of the e2e-tests, either |
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Contributor
Author
|
Okay, let's see if that worked. :D |
fabianburth
reviewed
Feb 10, 2026
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
jakobmoellerdev
approved these changes
Feb 10, 2026
frewilhelm
approved these changes
Feb 11, 2026
morri-son
pushed a commit
to morri-son/open-component-model
that referenced
this pull request
Feb 18, 2026
…pen-component-model#1752) Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Closes open-component-model/ocm-project#877
It fixes the referenced issue by modifying
GetEffectiveConfigto check if "parent" exists and use it's effective config.If, however, the object defines an explicit config, we use that instead.
There is a slight optimization here: Since the effective config is calculated if there is no parent, aka the base of anything coming after that in the chain, we can skip the resolution loop and assume that the effective config is correct only Secrets and ConfigMaps.
Which issue(s) this PR fixes