feat(850): remove kro permissions and create a small guide to update their permissions if necessary#1750
Merged
Skarlso merged 14 commits intoFeb 11, 2026
Conversation
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Contributor
Author
|
open tasks for tomorrow
|
…figure custom permissions On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
…k/rbac.yaml setup On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Skarlso
reviewed
Feb 11, 2026
fabianburth
reviewed
Feb 11, 2026
fabianburth
reviewed
Feb 11, 2026
fabianburth
reviewed
Feb 11, 2026
fabianburth
left a comment
Contributor
There was a problem hiding this comment.
Only nits in the documentation, but generally, very helpful and understandable! Good job!
Co-authored-by: Fabian Burth <fabian.burth@sap.com> Signed-off-by: Gergely Bräutigam <skarlso777@gmail.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
morri-son
reviewed
Feb 11, 2026
Contributor
|
Has everything in that is required. Easy to read and understand. I like it! |
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
morri-son
approved these changes
Feb 11, 2026
fabianburth
approved these changes
Feb 11, 2026
morri-son
pushed a commit
to morri-son/open-component-model
that referenced
this pull request
Feb 18, 2026
…their permissions if necessary (open-component-model#1750) Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Co-authored-by: Gergely Bräutigam <skarlso777@gmail.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com> Co-authored-by: Gergely Bräutigam <gergely.brautigam@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR removed the legacy built-in controller rbac for kro. We are not depending on kro anymore, so we should not require this permission for our controllers at all.
Since multiple test rely on kro, I have added a testing rbac to inject more permissions than the ones we need for the controller to work.
The goals of this PR are:
Which issue(s) this PR fixes
Fixes: open-component-model/ocm-project#850