feat: migrate the component version controller to v2 #1188
Merged
jakobmoellerdev merged 77 commits intoDec 2, 2025
Merged
Conversation
Contributor
Author
|
If the changes in #1145 are accepted, this how the migration would look like. ( except for verification which is incomplete yet. ) |
d7f141c to
f0da57b
Compare
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com> Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> adjust component objects in test
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
…rough the cache On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
509f7e1 to
f65f132
Compare
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
f65f132 to
41ba436
Compare
Contributor
Author
|
Interesting, this didn't occur before. Finally was able to run this locally and got: |
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Skarlso
added a commit
that referenced
this pull request
Nov 20, 2025
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Related to the migration effort: #1188 The legacy unversioned registration is missing here because old ocm doesn't have versions from time to time. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Contributor
Author
This is actually passing locally. Sooooo... 🤔 |
Contributor
Author
|
I ran this a couple of times with latest OCM as a binary on my machine and it's working. I'm wondering if I just need to update ocm. 🤔 Maybe I'm running into the yq problem. |
Contributor
Author
|
Oh joy. - name: Setup ocm
uses: open-component-model/ocm-setup-action@655f3525fd283ca7d22e6b2ceec42324331df401 # v1.0.0 |
Contributor
Author
|
Sadly, I can't try latest with that action, but let's see if the rc fixes something. If not, I'm willing to ignore this error for now. |
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
…Skarlso/open-component-model into migrate-cv-controller-v2-part-2
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
…omponent-model into migrate-cv-controller-v2-part-2
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
…Skarlso/open-component-model into migrate-cv-controller-v2-part-2
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Contributor
|
@fabianburth @jakobmoellerdev Thanks a lot for your reviews! I adjusted most of the requests and created follow-ups for the rest. |
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
83aa426 to
329f24d
Compare
…omponent-model into migrate-cv-controller-v2-part-2
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
matthiasbruns
approved these changes
Dec 2, 2025
jakobmoellerdev
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Part of open-component-model/ocm-project#753
Which issue(s) this PR fixes
Fixes open-component-model/ocm-project#753