fix: ward against nil error if resource is not filled in#1069
Merged
jakobmoellerdev merged 2 commits intoOct 21, 2025
Conversation
Contributor
Author
|
0.5.1 -> this is not working. kroVersion=$(curl -sL \
https://api.github.com/repos/kro-run/kro/releases/latest | \
jq -r '.tag_name | ltrimstr("v")'
)
helm install kro oci://ghcr.io/kro-run/kro/kro --namespace kro --create-namespace --version="${kroVersion}" || exit 1I'm not sure it's okay to use latest...? Maybe we should pin. 🤔 |
piotrjanik
previously approved these changes
Oct 20, 2025
Contributor
|
Code LGTM. Kro? Should not that be 0.4.1? That's the latest, not 0.5.1 |
Contributor
Author
|
It is the latest, but it's not a "finished" latest apparently. It's missing some pieces. :D |
ikhandamirov
previously approved these changes
Oct 20, 2025
Contributor
|
Ok, if it is missing some pieces, then to be re-reviewed. :) |
jakobmoellerdev
previously approved these changes
Oct 21, 2025
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
1669d55
9217f5a to
1669d55
Compare
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
matthiasbruns
approved these changes
Oct 21, 2025
jakobmoellerdev
approved these changes
Oct 21, 2025
morri-son
pushed a commit
to morri-son/open-component-model
that referenced
this pull request
Oct 23, 2025
…ent-model#1069) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Fixes open-component-model#1067 #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> --------- Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fixes #1067
Which issue(s) this PR fixes