Skip to content
This repository was archived by the owner on Apr 13, 2026. It is now read-only.

chore: change types to k8s-style Upper Camel Case#785

Closed
morri-son wants to merge 2 commits into
open-component-model:mainfrom
morri-son:change-to-upper-camle-case
Closed

chore: change types to k8s-style Upper Camel Case#785
morri-son wants to merge 2 commits into
open-component-model:mainfrom
morri-son:change-to-upper-camle-case

Conversation

@morri-son

@morri-son morri-son commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

On-behalf-of: Gerald Morrison (SAP) gerald.morrison@sap.com

What this PR does / why we need it

We want to consistently use k8s UpperCamelCase/v1 typing style as the default notation for input and access types.

Which issue(s) this PR is related to

Related to open-component-model/ocm-project#962

Type of content

  • Tutorial (getting-started/ or tutorials/)
  • How-to Guide (how-to/)
  • Explanation / Concept (concepts/)
  • Reference (reference/)

Checklist

  • I have read and followed the Contributing Guide
  • All commands/code snippets are tested and can be copy-pasted

On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com>
Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
@morri-son morri-son requested a review from a team as a code owner March 24, 2026 11:22
@morri-son morri-son added the kind/chore chore, maintenance, etc. label Mar 24, 2026
@netlify

netlify Bot commented Mar 24, 2026

Copy link
Copy Markdown

Deploy Preview for open-component-model ready!

Name Link
🔨 Latest commit af6c064
🔍 Latest deploy log https://app.netlify.com/projects/open-component-model/deploys/69c2b2ec48c45500088971fb
😎 Deploy Preview https://deploy-preview-785--open-component-model.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@morri-son morri-son linked an issue Mar 24, 2026 that may be closed by this pull request
7 tasks
@coderabbitai

coderabbitai Bot commented Mar 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3fe11f9b-3ae9-40af-90a9-d7a28bc8e9f8

📥 Commits

Reviewing files that changed from the base of the PR and between 47213e1 and af6c064.

📒 Files selected for processing (1)
  • content/docs/how-to/transfer-helm-charts.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • content/docs/how-to/transfer-helm-charts.md

📝 Walkthrough

Walkthrough

Documentation across multiple pages standardized input/access type identifiers: lowercase or legacy tokens (e.g., helm, file, dir, utf8, localBlob, ociArtifact) were replaced with capitalized, versioned forms (Helm/v1, File/v1, Dir/v1, UTF8/v1, LocalBlob/v1, OCIImage/v1) in examples and reference material.

Changes

Cohort / File(s) Summary
Concepts
content/docs/concepts/component-identity.md, content/docs/concepts/signing-and-verification-concept.md
Replaced example access.type values from legacy tokens (ociArtifact, localBlob) to OCIImage/v1 and LocalBlob/v1 in component descriptor examples.
Getting Started Guides
content/docs/getting-started/create-component-version.md, content/docs/getting-started/deploy-helm-chart.md
Standardized constructor and component descriptor examples to use capitalized versioned input/access types (File/v1, Dir/v1, Helm/v1, OCIImage/v1, LocalBlob/v1).
How‑To Guides
content/docs/how-to/container-image-usage.md, content/docs/how-to/download-resources-from-component-versions.md, content/docs/how-to/transfer-helm-charts.md
Updated resource access.type examples to OCIImage/v1 and adjusted Helm/chart access examples to Helm/v1 / LocalBlob/v1 where applicable.
Reference
content/docs/reference/input-and-access-types.md
Changed canonical type names and example snippets to capitalized versioned forms (Dir/v1, File/v1, Helm/v1, UTF8/v1, LocalBlob/v1) and noted deprecated aliases.
Tutorials
content/docs/tutorials/advanced-component-constructor.md, content/docs/tutorials/configure-resolvers.md, content/docs/tutorials/deploy-helm-chart-bootstrap.md
Updated tutorial examples and expected outputs to use standardized input/access type identifiers (Helm/v1, UTF8/v1, File/v1, LocalBlob/v1, OCIImage/v1).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

area/documentation

Suggested reviewers

  • frewilhelm
  • jakobmoellerdev
  • matthiasbruns

Poem

🐰 I hopped through docs both near and far,
Swapped helm for Helm/v1 beneath the star.
LocalBlob and OCIImage now stand tall,
Clear names in examples — tidy for all! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly summarizes the main change: updating type identifiers to Kubernetes-style UpperCamelCase notation across documentation.
Description check ✅ Passed The pull request description is related to the changeset, explaining the motivation to adopt k8s UpperCamelCase/v1 typing style for input and access types.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@content/docs/how-to/transfer-helm-charts.md`:
- Around line 48-51: The snippet uses helmChart: my-chart-1.0.0.tgz which is
invalid for the Helm/v1 access type; update the Helm/v1 entry so helmChart
contains chart coordinates (e.g. "my-chart:1.0.0") or move the version into a
separate version field and set helmChart to the chart name (e.g. helmChart:
my-chart and version: 1.0.0); if you intend to reference a local tarball,
instead use the localBlob access pattern rather than Helm/v1 and keep
helmRepository and Helm/v1-specific fields unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c65d631b-6be5-4460-9a91-a201ec22ae09

📥 Commits

Reviewing files that changed from the base of the PR and between 8bb92e6 and 289d4b1.

📒 Files selected for processing (11)
  • content/docs/concepts/component-identity.md
  • content/docs/concepts/signing-and-verification-concept.md
  • content/docs/getting-started/create-component-version.md
  • content/docs/getting-started/deploy-helm-chart.md
  • content/docs/how-to/container-image-usage.md
  • content/docs/how-to/download-resources-from-component-versions.md
  • content/docs/how-to/transfer-helm-charts.md
  • content/docs/reference/input-and-access-types.md
  • content/docs/tutorials/advanced-component-constructor.md
  • content/docs/tutorials/configure-resolvers.md
  • content/docs/tutorials/deploy-helm-chart-bootstrap.md

Comment thread content/docs/how-to/transfer-helm-charts.md
type: helmChart
access:
type: helm/v1
type: Helm/v1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this type and it broke on 0.2.0

The helmChart field in Helm/v1 access specs expects 'name:version'
format, not a filename. Using 'my-chart-1.0.0.tgz' is incorrect;
the colon-separated form 'my-chart:1.0.0' is what the OCM CLI parses.

Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com>
@morri-son morri-son force-pushed the change-to-upper-camle-case branch from eac6289 to af6c064 Compare March 24, 2026 15:51
@morri-son morri-son marked this pull request as draft March 25, 2026 17:22
@morri-son

Copy link
Copy Markdown
Contributor Author

needs decision on way forward and scope. Will re-open in monorepo once we're clear about the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/chore chore, maintenance, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants