chore: change types to k8s-style Upper Camel Case#785
Conversation
On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
✅ Deploy Preview for open-component-model ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDocumentation across multiple pages standardized input/access type identifiers: lowercase or legacy tokens (e.g., Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@content/docs/how-to/transfer-helm-charts.md`:
- Around line 48-51: The snippet uses helmChart: my-chart-1.0.0.tgz which is
invalid for the Helm/v1 access type; update the Helm/v1 entry so helmChart
contains chart coordinates (e.g. "my-chart:1.0.0") or move the version into a
separate version field and set helmChart to the chart name (e.g. helmChart:
my-chart and version: 1.0.0); if you intend to reference a local tarball,
instead use the localBlob access pattern rather than Helm/v1 and keep
helmRepository and Helm/v1-specific fields unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c65d631b-6be5-4460-9a91-a201ec22ae09
📒 Files selected for processing (11)
content/docs/concepts/component-identity.mdcontent/docs/concepts/signing-and-verification-concept.mdcontent/docs/getting-started/create-component-version.mdcontent/docs/getting-started/deploy-helm-chart.mdcontent/docs/how-to/container-image-usage.mdcontent/docs/how-to/download-resources-from-component-versions.mdcontent/docs/how-to/transfer-helm-charts.mdcontent/docs/reference/input-and-access-types.mdcontent/docs/tutorials/advanced-component-constructor.mdcontent/docs/tutorials/configure-resolvers.mdcontent/docs/tutorials/deploy-helm-chart-bootstrap.md
| type: helmChart | ||
| access: | ||
| type: helm/v1 | ||
| type: Helm/v1 |
There was a problem hiding this comment.
I tested this type and it broke on 0.2.0
The helmChart field in Helm/v1 access specs expects 'name:version' format, not a filename. Using 'my-chart-1.0.0.tgz' is incorrect; the colon-separated form 'my-chart:1.0.0' is what the OCM CLI parses. Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com> On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com>
eac6289 to
af6c064
Compare
|
needs decision on way forward and scope. Will re-open in monorepo once we're clear about the process. |
On-behalf-of: Gerald Morrison (SAP) gerald.morrison@sap.com
What this PR does / why we need it
We want to consistently use k8s UpperCamelCase/v1 typing style as the default notation for input and access types.
Which issue(s) this PR is related to
Related to open-component-model/ocm-project#962
Type of content
getting-started/ortutorials/)how-to/)concepts/)reference/)Checklist