docs: core model identity#771
Conversation
✅ Deploy Preview for open-component-model ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughReplaced two concept pages with a new "Component Identity" concept, added a new "Core Model" overview, updated cross-references across docs and tutorials to point at the new concept, deleted the legacy concept files, and appended several tokens to the repository wordlist. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f1b46a9 to
54bb945
Compare
|
👍🏻 I like the docs, goo to read, easy to follow. We have some overlaps between core model and component identity doc, but since this is about the main attributes a component have, that's hard to keep completely seperate. |
Add two new explanation pages following the Diataxis framework: - Overview > Core Model: accessible intro to OCM's identity model - Concepts > Component Identity: deep technical reference merging components.md and coordinates.md with descriptor structure details Delete the thin components.md and coordinates.md pages (content merged), update all relrefs, and add cross-links from getting-started and tutorials. Closes ocm-project#885 Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
Update references across docs to replace "components.md" with "component-identity.md" following concept merge. Add new terms to wordlist. Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
d47b92d to
4412dff
Compare
- Replace duplicated field tables (Resources, Sources, References, Labels) with concise prose and links to the component descriptor reference. - Replace duplicated Artifact Types and Access Specifications tables with conceptual summaries and reference links. - Replace card-grid sections with simple "Next Steps" lists in both component-identity.md and core-model.md. - Fix wording: use `extraIdentity` attribute (code-formatted). Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/config/wordlist.txt:
- Around line 514-518: Remove the duplicate and case-variant wordlist entries:
delete the lines containing "autocompletion", "terraform", "Untyped", "URI", and
"versionable" from the wordlist so each word appears only once (note aspell is
configured with ignore-case so case variants like "Untyped"/"untyped" and
"URI"/"uri" are redundant); ensure the remaining canonical entries (e.g.,
"autocompletion" at its earlier occurrence, "terraform" at line ~457, "untyped"
at ~478, "uri" at ~484, and "versionable" at ~495) are preserved.
In `@content/docs/overview/core-model.md`:
- Line 28: Update the sentence that currently reads "A **version** following
[SemVer](https://semver.org/) (e.g., `1.0.0`) — each version is an immutable
snapshot." to explicitly state OCM uses "relaxed SemVer": mention that major and
minor are required, patch is optional (e.g., `v2.1`), and a leading `v` is
allowed (e.g., `v1.0.0`), and either replace or augment the semver.org link with
an internal link to the component-identity.md rules (or add a parenthetical
pointing to content/docs/concepts/component-identity.md) so readers see the
exact relaxed SemVer format used by OCM.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 91dab6d3-042d-4f17-9199-9b4acafd2fe6
📒 Files selected for processing (13)
.github/config/wordlist.txtcontent/docs/concepts/component-identity.mdcontent/docs/concepts/components.mdcontent/docs/concepts/coordinates.mdcontent/docs/concepts/resolvers.mdcontent/docs/concepts/signing-and-verification-concept.mdcontent/docs/getting-started/create-component-version.mdcontent/docs/how-to/air-gap-transfer.mdcontent/docs/how-to/download-resources-from-component-versions.mdcontent/docs/overview/benefits.mdcontent/docs/overview/core-model.mdcontent/docs/overview/how-ocm-works.mdcontent/docs/tutorials/configure-resolvers.md
💤 Files with no reviewable changes (2)
- content/docs/concepts/coordinates.md
- content/docs/concepts/components.md
4412dff to
52b1148
Compare
- Specify relaxed SemVer versions (e.g., `v2.1`). - Add cross-link to the Component Identity page for detailed rules. Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
Skarlso
left a comment
There was a problem hiding this comment.
LGTM, I just have one comment which is interesting to me, but otherwise, feel free to ignore if not relevant. :)
frewilhelm
left a comment
There was a problem hiding this comment.
nice read. Just some nits
- Clarify domain ownership in name examples. - Replace relrefs with direct spec link for artifact types. - Simplify CTF archive description while retaining key details. Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Add two new explanation pages following the Diataxis framework: - Overview > Core Model: accessible intro to OCM's identity model - Concepts > Component Identity: deep technical reference merging components.md and coordinates.md with descriptor structure details Delete the thin components.md and coordinates.md pages (content merged), update all relrefs, and add cross-links from getting-started and tutorials. #### Which issue(s) this PR is related to <!-- Usage: `Related to #<issue number>`, or `Related to (paste link of issue)`. --> resolves open-component-model/ocm-project#885 #### Type of content <!-- Which section does this PR target? See CONTRIBUTING.md for guidance. --> - [x] Tutorial (`getting-started/` or `tutorials/`) - [ ] How-to Guide (`how-to/`) - [x] Explanation / Concept (`concepts/`) - [ ] Reference (`reference/`) - [ ] Other (infrastructure, config, fixes) #### Checklist - [x] I have read and followed the [Contributing Guide](https://github.com/open-component-model/ocm-website/blob/main/CONTRIBUTING.md) - [ ] All commands/code snippets are tested and can be copy-pasted <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added a new "Component Identity" concept and an "OCM Core Model" overview; removed legacy concept pages and updated guides, tutorials, how‑tos, and related docs to reference the new content (including a new "New to OCM?" tip in the create-component-version guide). * **Chores** * Expanded the repository wordlist with new entries (autoscaler, camelcase, filesystems, webshop). <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jakob Möller <contact@jakob-moeller.com> bf995ba
|
|
||
| ## Components and Component Versions | ||
|
|
||
| A **component** is a logical unit of software — a frontend, a database, an autoscaler, or an entire application. Components group a set of semantically related **component versions**. |
There was a problem hiding this comment.
Sounds like CV is always composed of frontend and backend or just complete application.
There was a problem hiding this comment.
this is correct.
What this PR does / why we need it
Add two new explanation pages following the Diataxis framework:
components.md and coordinates.md with descriptor structure details
Delete the thin components.md and coordinates.md pages (content merged),
update all relrefs, and add cross-links from getting-started and tutorials.
Which issue(s) this PR is related to
resolves open-component-model/ocm-project#885
Type of content
getting-started/ortutorials/)how-to/)concepts/)reference/)Checklist
Summary by CodeRabbit