chore: update identity type to OCIRegistry and replace pathprefix with path#759
Conversation
… with `path` Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
✅ Deploy Preview for open-component-model ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughSix documentation files are updated to reflect credential identity system changes: replacing OCIRepository with OCIRegistry as the consumer identity type, updating field name from pathprefix to path, and adding guidance on glob pattern usage for path matching semantics. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
content/docs/how-to/legacy-credential-compatibility.md (1)
89-89: Consider clarifying identity type variance in legacy configs.While the example shows
OCIRegistryas unchanged (which is correct for configs that already used this type), some legacy configurations may have usedOCIRepository. Consider adding a brief note that if your legacy config usedOCIRepository, it should be updated toOCIRegistry.📝 Suggested clarification
-- `OCIRegistry` consumer identity type (unchanged) +- `OCIRegistry` consumer identity type (unchanged; if your legacy config used `OCIRepository`, update it to `OCIRegistry`)Alternatively, add a separate callout or bullet point to handle the OCIRepository → OCIRegistry case explicitly.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@content/docs/how-to/legacy-credential-compatibility.md` at line 89, Add a brief clarifying note in the legacy-credential compatibility doc explaining that some legacy configs may use the identity type OCIRepository and must be updated to OCIRegistry; specifically, in the section around the "`OCIRegistry` consumer identity type (unchanged)" sentence, append a short sentence or add a bullet/callout that explicitly instructs users to replace OCIRepository with OCIRegistry in legacy configs and show the expected updated key name.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@content/docs/how-to/legacy-credential-compatibility.md`:
- Line 89: Add a brief clarifying note in the legacy-credential compatibility
doc explaining that some legacy configs may use the identity type OCIRepository
and must be updated to OCIRegistry; specifically, in the section around the
"`OCIRegistry` consumer identity type (unchanged)" sentence, append a short
sentence or add a bullet/callout that explicitly instructs users to replace
OCIRepository with OCIRegistry in legacy configs and show the expected updated
key name.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8cecd921-9019-421c-ae2a-f1d32c910f2c
📒 Files selected for processing (6)
content/docs/concepts/credential-system.mdcontent/docs/how-to/configure-multiple-credentials.mdcontent/docs/how-to/container-image-usage.mdcontent/docs/how-to/legacy-credential-compatibility.mdcontent/docs/tutorials/configure-credentials-for-controllers.mdcontent/docs/tutorials/credential-resolution.md
… with `path` (#759) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Corrects all documentation references of our OCI credentials to be of the OCIRegistry type and patches up pathprefix towards path to stay consistent. #### Which issue(s) this PR is related to <!-- Usage: `Related to #<issue number>`, or `Related to (paste link of issue)`. --> Fix open-component-model/ocm-project#916 requires open-component-model/open-component-model#1992 #### Type of content <!-- Which section does this PR target? See CONTRIBUTING.md for guidance. --> - [ ] Tutorial (`getting-started/` or `tutorials/`) - [ ] How-to Guide (`how-to/`) - [ ] Explanation / Concept (`concepts/`) - [ ] Reference (`reference/`) - [x] Other (infrastructure, config, fixes) #### Checklist - [x] I have read and followed the [Contributing Guide](https://github.com/open-component-model/ocm-website/blob/main/CONTRIBUTING.md) - [x] All commands/code snippets are tested and can be copy-pasted <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated credential identity type references across configuration examples and guides. * Clarified path matching behavior with glob pattern guidance for credential configuration. * Updated legacy credential compatibility guidance and configuration examples to reflect current system expectations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jakob Möller <contact@jakob-moeller.com> 7b47951
What this PR does / why we need it
Corrects all documentation references of our OCI credentials to be of the OCIRegistry type and patches up pathprefix towards path to stay consistent.
Which issue(s) this PR is related to
Fix open-component-model/ocm-project#916
requires open-component-model/open-component-model#1992
Type of content
getting-started/ortutorials/)how-to/)concepts/)reference/)Checklist
Summary by CodeRabbit