fix: support scoped conventional commits in auto-release workflows#60
Merged
fix: support scoped conventional commits in auto-release workflows#60
Conversation
The auto-release workflows were skipping all releases because the commit message condition checked for 'feat:' and 'fix:' prefixes, but commits use scoped format like 'feat(cfl):' and 'feat(jtk):'. Changed startsWith checks from 'feat:' to 'feat' (and 'fix:' to 'fix') to match both scoped and non-scoped conventional commit formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat(cfl):,feat(jtk):)feat:,fix:)Changes
Updated the
ifcondition in both workflow files from:startsWith(github.event.head_commit.message, 'feat:')to:
startsWith(github.event.head_commit.message, 'feat')Test plan
git fetch --tags && git tag | grep -E '^(cfl|jtk)-v'brew update && brew upgrade cfl jtkto confirm Homebrew worksCloses #59