-
Notifications
You must be signed in to change notification settings - Fork 1
fix: auto-release workflows skip scoped conventional commits #59
Copy link
Copy link
Closed
Description
Problem
The auto-release workflows (auto-release-cfl.yml and auto-release-jtk.yml) are skipping all releases because the commit message condition doesn't match scoped conventional commits.
Current condition (line 15 in both files):
if: startsWith(github.event.head_commit.message, 'feat:') || startsWith(github.event.head_commit.message, 'fix:')Actual commit messages:
feat(cfl): improve init and config test UX- starts withfeat(notfeat:feat(jtk): add issue move command- starts withfeat(notfeat:
Result: 0 tags created, 0 releases published, brew upgrades show no new versions.
Commits Awaiting Release
| Tool | Commit | Message |
|---|---|---|
| cfl | 45e7b2b | feat(cfl): improve init and config test UX |
| cfl | 40692c0 | feat(cfl): add config show/test/clear commands |
| cfl | fc75af0 | feat(cfl): add space key display to page view and search |
| cfl | cf1139b | feat(cfl): add pagination cursor support to space list |
| jtk | bbecd98 | feat(jtk): align init and config UX with cfl |
| jtk | d99da8d | feat(jtk): add issue move command |
| jtk | 959047c | feat(jtk): add attachments command |
| jtk | bcc6f46 | feat(jtk): add wiki markup detection and conversion |
| jtk | e5a9280 | feat(jtk): add init command and config test |
Fix
Update both workflow files to match both scoped and non-scoped conventional commits.
Files to Modify
.github/workflows/auto-release-cfl.yml(line 15).github/workflows/auto-release-jtk.yml(line 15)
Change
From:
if: startsWith(github.event.head_commit.message, 'feat:') || startsWith(github.event.head_commit.message, 'fix:')To:
if: startsWith(github.event.head_commit.message, 'feat') || startsWith(github.event.head_commit.message, 'fix')This matches:
feat:(non-scoped)feat(cfl):(scoped)feat(jtk):(scoped)fix:,fix(cfl):,fix(jtk):(same pattern)
Verification
- After merging, check GitHub Actions to confirm auto-release workflows run (not skip)
- Confirm tags are created:
git fetch --tags && git tag | grep -E '^(cfl|jtk)-v' - Check GitHub releases page for new releases
- Run
brew update && brew upgrade cfl jtkto confirm Homebrew works
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels