Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(p2p): Track and Return Peer Ping Latencies#2112

Merged
refcell merged 3 commits intomainfrom
rf/track-ping-latency
Jun 11, 2025
Merged

feat(p2p): Track and Return Peer Ping Latencies#2112
refcell merged 3 commits intomainfrom
rf/track-ping-latency

Conversation

@refcell
Copy link
Copy Markdown
Contributor

@refcell refcell commented Jun 11, 2025

Description

Tracks peer ping latencies so we can return the latencies in the peer info response.

Progress on #1562

Copilot AI review requested due to automatic review settings June 11, 2025 20:30
@refcell refcell added the A-p2p Area: p2p label Jun 11, 2025
@refcell refcell added the A-p2p Area: p2p label Jun 11, 2025
@refcell refcell self-assigned this Jun 11, 2025
@refcell
Copy link
Copy Markdown
Contributor Author

refcell commented Jun 11, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 82.4%. Comparing base (290ad7d) to head (56ed9e1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/node/p2p/src/gossip/driver.rs 0.0% 12 Missing ⚠️
crates/node/p2p/src/rpc/request.rs 0.0% 8 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@refcell refcell requested a review from clabby June 11, 2025 20:52
Copy link
Copy Markdown
Contributor

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go for now. Let's keep an eye on this to see if using the std mutex causes any issues.

It'll block the whole thread while waiting to acquire the lock, which could be pretty problematic if the future is on the same thread as the runtime (we can't control that.) Switching over to a tokio mutex and biting the async bullet would be preferable if not too much trouble.

@refcell refcell enabled auto-merge June 11, 2025 22:26
@refcell refcell added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit 7abea63 Jun 11, 2025
23 of 24 checks passed
@refcell refcell deleted the rf/track-ping-latency branch June 11, 2025 23:02
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
### Description

Tracks peer ping latencies so we can return the latencies in the peer
info response.

Progress on op-rs/kona#1562
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
### Description

Tracks peer ping latencies so we can return the latencies in the peer
info response.

Progress on #1562
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-p2p Area: p2p

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants