Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

fix(node/p2p): fix op-p2p peers rpc call#2014

Merged
theochap merged 1 commit intomainfrom
theo/fix-peers
Jun 5, 2025
Merged

fix(node/p2p): fix op-p2p peers rpc call#2014
theochap merged 1 commit intomainfrom
theo/fix-peers

Conversation

@theochap
Copy link
Copy Markdown
Member

@theochap theochap commented Jun 5, 2025

Description

Fix opp2p_peers rpc call by getting the supported peer protocols from the identify protocol.

Also does some light refactors to the gossip driver to clean-up some duplicate code and improve the code structure.

Progress towards #1562

@theochap theochap self-assigned this Jun 5, 2025
@theochap theochap added K-fix Kind: fix A-node Area: cl node (eq. Go op-node) handles single-chain consensus A-rpc Area: rpc A-p2p Area: p2p labels Jun 5, 2025
@theochap theochap moved this to In Progress in Project Tracking Jun 5, 2025
@theochap theochap moved this from In Progress to In Review in Project Tracking Jun 5, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 83.6%. Comparing base (19a313d) to head (2d198c1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/node/p2p/src/rpc/request.rs 0.0% 28 Missing ⚠️
crates/node/p2p/src/gossip/driver.rs 0.0% 25 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theochap theochap force-pushed the theo/fix-peers branch 2 times, most recently from c594e88 to 2d198c1 Compare June 5, 2025 03:27
@theochap theochap added this pull request to the merge queue Jun 5, 2025
Merged via the queue into main with commit dedfd85 Jun 5, 2025
43 of 44 checks passed
@theochap theochap deleted the theo/fix-peers branch June 5, 2025 16:03
@github-project-automation github-project-automation bot moved this from In Review to Done in Project Tracking Jun 5, 2025
theochap added a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
## Description

Fix `opp2p_peers` rpc call by getting the supported peer protocols from
the identify protocol.

Also does some light refactors to the gossip driver to clean-up some
duplicate code and improve the code structure.

Progress towards op-rs/kona#1562
theochap added a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
## Description

Fix `opp2p_peers` rpc call by getting the supported peer protocols from
the identify protocol.

Also does some light refactors to the gossip driver to clean-up some
duplicate code and improve the code structure.

Progress towards #1562
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-node Area: cl node (eq. Go op-node) handles single-chain consensus A-p2p Area: p2p A-rpc Area: rpc K-fix Kind: fix

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants