Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

test(node/e2e): extend the p2p tests#1831

Merged
theochap merged 1 commit intomainfrom
theo/extend-p2p-tests
May 22, 2025
Merged

test(node/e2e): extend the p2p tests#1831
theochap merged 1 commit intomainfrom
theo/extend-p2p-tests

Conversation

@theochap
Copy link
Copy Markdown
Member

@theochap theochap commented May 21, 2025

Description

This PR extends the P2p tests for the kona-node by adding a large network test and a peer address check (to ensure that the connected nodes are all known within a kurtosis network).

With that done, we are effectively testing the ability of p2p nodes to connect to each other and check that they are part of the gossip mesh.

This PR also extends the CI tasks to add a separate large network test.

Closes #1462

@theochap theochap self-assigned this May 21, 2025
@theochap theochap added M-tests Meta: Testing related A-p2p Area: p2p K-kurtosis Kind: related to kurtosis integration K-feature Kind: feature go Pull requests that update go code labels May 21, 2025
@theochap theochap moved this to In Review in Project Tracking May 21, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.8%. Comparing base (02a6c8c) to head (fbde44d).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/node/p2p/src/rpc/request.rs 0.0% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great test, but that large configuration is going to absolutely kill our free CI runners. I'll reach out to platforms to see if we can get some self hosted runners for these kinds of jobs.

@theochap theochap force-pushed the theo/extend-p2p-tests branch from f050fad to fbde44d Compare May 22, 2025 19:16
@theochap theochap enabled auto-merge May 22, 2025 20:00
@theochap theochap added this pull request to the merge queue May 22, 2025
Merged via the queue into main with commit 15fa947 May 22, 2025
21 of 22 checks passed
@theochap theochap deleted the theo/extend-p2p-tests branch May 22, 2025 21:05
@github-project-automation github-project-automation bot moved this from In Review to Done in Project Tracking May 22, 2025
theochap added a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
## Description

This PR extends the P2p tests for the kona-node by adding a large
network test and a peer address check (to ensure that the connected
nodes are all known within a kurtosis network).

With that done, we are effectively testing the ability of p2p nodes to
connect to each other and check that they are part of the gossip mesh.

This PR also extends the CI tasks to add a separate large network test.

Closes op-rs/kona#1462
theochap added a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
## Description

This PR extends the P2p tests for the kona-node by adding a large
network test and a peer address check (to ensure that the connected
nodes are all known within a kurtosis network).

With that done, we are effectively testing the ability of p2p nodes to
connect to each other and check that they are part of the gossip mesh.

This PR also extends the CI tasks to add a separate large network test.

Closes #1462
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-p2p Area: p2p go Pull requests that update go code K-feature Kind: feature K-kurtosis Kind: related to kurtosis integration M-tests Meta: Testing related

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Deterministic integration tests for the p2p discovery/gossip layer

2 participants