Update documentation about required input output types#2310
Merged
gramalingam merged 1 commit intoonnx:masterfrom Sep 13, 2019
Merged
Update documentation about required input output types#2310gramalingam merged 1 commit intoonnx:masterfrom
gramalingam merged 1 commit intoonnx:masterfrom
Conversation
Member
|
@gramalingam do you have more context on in which condition, subgraph should not provide type information? |
Contributor
Author
|
@houseroad : see Issue #2286 and the earlier PR #2009 |
wschin
approved these changes
Sep 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The types of inputs and outputs are required only for the top-level graph and not for subgraphs. Update the documentation to clarify this. (Also clarify documentation about variadic inputs and outputs.)