More unsqueeze tests#2200
Merged
ebarsoum merged 11 commits intoonnx:masterfrom Sep 15, 2019
Merged
Conversation
Also renamed the 1 dim test cases slightly.
Also renamed the 1 dim test cases slightly.
wschin
reviewed
Aug 5, 2019
wschin
reviewed
Aug 5, 2019
| ) | ||
| y = np.expand_dims(x, axis=2) | ||
| y = np.expand_dims(y, axis=4) | ||
| y = np.expand_dims(y, axis=5) |
Collaborator
There was a problem hiding this comment.
I am not sure if this is the valid test. The original tensor is 3-D, so the min axis you can expand is 0 and the max one is 3. Did I miss something? I found what I missed. The axes are output's axis indexes.
Collaborator
|
Overall this PR looks good to me. I have one comment for changing an axis bound in your test. |
Feedback from wschin to fix axis bounds. Co-Authored-By: Wei-Sheng Chin <wschin@outlook.com>
askhade
reviewed
Aug 5, 2019
wschin
approved these changes
Aug 13, 2019
postrational
approved these changes
Aug 22, 2019
ebarsoum
approved these changes
Sep 15, 2019
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
* Added more test cases for Unsqueeze * Added a test case for unsqueezing 3 dims Also renamed the 1 dim test cases slightly. * Added more test cases for Unsqueeze * Added a test case for unsqueezing 3 dims Also renamed the 1 dim test cases slightly. * Update docs/Operators.md Feedback from wschin to fix axis bounds. Co-Authored-By: Wei-Sheng Chin <wschin@outlook.com> * Re-ran update_doc.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are now 3 test cases for Unsqueeze:
One weird thing is that the Operators.md and TestCoverage.md that were generated show the two and three axes test out of order, I'm not sure why that happened or if this is something to care about... it is just a little strange to read in that order.