Skip to content

Add helper function update_inputs_outputs_dims to tools#2148

Merged
wschin merged 20 commits intoonnx:masterfrom
BowenBao:variable_length_2
Sep 13, 2019
Merged

Add helper function update_inputs_outputs_dims to tools#2148
wschin merged 20 commits intoonnx:masterfrom
BowenBao:variable_length_2

Conversation

@BowenBao
Copy link
Copy Markdown
Contributor

@BowenBao BowenBao commented Jul 2, 2019

The function updates the dimension of the inputs and outputs of the model, to the provided values in the parameter. These values can be either static or dynamic. This can be useful for extending models with fixed input size to support dynamic input sizes.

Copy link
Copy Markdown
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test?

Comment thread docs/PythonAPIOverview.md
Comment thread onnx/tools/update_model_dims.py Outdated
Comment thread onnx/tools/update_model_dims.py Outdated
Comment thread onnx/tools/update_model_dims.py
Copy link
Copy Markdown
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 22, 2019

CLA assistant check
All committers have signed the CLA.

@prasanthpul
Copy link
Copy Markdown
Member

Please sign the updated CLA

Comment thread onnx/tools/update_model_dims.py Outdated
@prasanthpul prasanthpul added this to the 1.6 milestone Sep 9, 2019
Comment thread onnx/tools/update_model_dims.py Outdated
Copy link
Copy Markdown
Collaborator

@wschin wschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one last question for import pdb.

@wschin wschin merged commit 599f3da into onnx:master Sep 13, 2019
jcwchen pushed a commit to jcwchen/onnx that referenced this pull request Sep 23, 2020
* Add a helper function update_inputs_outputs_dims to tools

* fix link to doc

* newline at the end

* add test for tools

* doc props

* nit

* ci tests

* ci tests 2

* accept shapes by dictionary inputs and add more error handling

* Update onnx/tools/update_model_dims.py

nit: rephrasing

Co-Authored-By: Wei-Sheng Chin <wschin@outlook.com>

* remove debug line

* fix type annotation

* fix annotation

* fix annotation

* fix annotation

* fix flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants