Version Conversion from opset 8 to 9#2007
Merged
ebarsoum merged 11 commits intoonnx:masterfrom May 17, 2019
Merged
Conversation
Contributor
Contributor
Author
|
cc @bddppq @houseroad Can you please take a look at this PR? Thanks. |
Member
|
Some type annotation is missing. Could you take care of it? |
Contributor
Author
|
@houseroad Can you please elaborate on what type annotations are missing? |
houseroad
reviewed
May 13, 2019
Member
houseroad
left a comment
There was a problem hiding this comment.
Check the error message at the bottom: https://travis-ci.org/onnx/onnx/jobs/529519392
Contributor
Author
|
@houseroad I added type annotations and all checks pass now. |
|
@KsenijaS please merge the master branch into your branch! Otherwise LGTM as well. |
Contributor
Author
houseroad
approved these changes
May 17, 2019
| [onnx.helper.make_tensor_value_info("Y", data_type_to, [2, 3])]) | ||
|
|
||
| converted_model = self._converted(graph, helper.make_operatorsetid("", from_opset), to_opset) | ||
|
|
hariharans29
pushed a commit
to hariharans29/onnx
that referenced
this pull request
Aug 15, 2019
* add tests * adapter for batchnorm opset 8 to 9 * adapter for upsample opset 8 to 9 * adapter for scan opset 8 to 9 * update convert.h file * fix syntax error * Add type annotations * Check node type for Cast operator * Empty Commit to rerun checks
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
* add tests * adapter for batchnorm opset 8 to 9 * adapter for upsample opset 8 to 9 * adapter for scan opset 8 to 9 * update convert.h file * fix syntax error * Add type annotations * Check node type for Cast operator * Empty Commit to rerun checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.