[Training] Adam Optimizer#1970
Merged
wschin merged 29 commits intoonnx:masterfrom Apr 13, 2020
Merged
Conversation
Update docs
postrational
reviewed
Mar 2, 2020
Contributor
postrational
left a comment
There was a problem hiding this comment.
Looks good, but some artifacts made it in. Please clean up the artifacts so the PR can be approved.
Contributor
|
@wschin Wei-Sheng, please respond to Michal's comments above, plus his comments on Gitter in Operators chat room. Thank you! |
Contributor
|
@wschin Can you please take a look and move this forward? During the TSC meeting today, the members suggest to have at least one optimizer PR merged for release 1.7. Please let us know if more time is needed. |
Collaborator
Author
|
@sveta-levitan , @postrational , @chinhuang007, PR is update-to-date again. Please take a look. Thank you. |
chinhuang007
reviewed
Mar 6, 2020
chinhuang007
reviewed
Mar 6, 2020
sveta-levitan
approved these changes
Mar 10, 2020
ebarsoum
approved these changes
Mar 11, 2020
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
* Adam draft Update docs * Empty shape inference * Add shape inference * Add tests * Fix a test * Sync with recent master changes * Sync with master * Make flake8 happy * Sync docs * sync doc * Revert side-effect changes * sync with master * Add 1 back * Polish doc * Finish the design of Adam spec * formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2314 is a single place for reviewing the whole training story.
A common signature shared by Pytroch's and TF's Adam.
Design verification script (it shows that the proposed Adam signature covers both of TF and Pytorch):