Add an upsample2d operator as experimental#180
Merged
houseroad merged 1 commit intoonnx:masterfrom Nov 14, 2017
Merged
Conversation
bddppq
reviewed
Nov 2, 2017
| .Attr( | ||
| "width_scale", | ||
| "The scale along width dimension", | ||
| AttrType::FLOAT) |
Contributor
There was a problem hiding this comment.
Please either mark the attribute as required or document the default value.
bddppq
reviewed
Nov 2, 2017
| "Y", | ||
| "4D tensor after resizing, N x C x H x W") | ||
| .SetDoc(R"DOC( | ||
| Resize the width and height dimensions: |
Contributor
There was a problem hiding this comment.
Maybe add some more description? It's not clear what values of the new pixels in the output.
Member
Author
There was a problem hiding this comment.
Will add more description, and an example here.
ad68396 to
95ce9f3
Compare
95ce9f3 to
69e30a5
Compare
Contributor
|
LGTM |
bddppq
approved these changes
Nov 14, 2017
|
Hello, do you have ETA to move this op from experimental to default. Thanks |
Member
Author
|
@silaskuo right on time, I will move it soon. PR is under construction. |
|
Thanks for the quick reply. Look forward to it! |
|
Is it moved from experimental to default? If yes, then is https://github.com/onnx/onnx/blob/master/docs/Operators.md going to be updated accordingly? Thanks. |
jfnhiller
pushed a commit
to jfnhiller/onnx
that referenced
this pull request
Feb 26, 2026
add link to backend-scoreboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is experimental.