Skip to content

Enable onnxifi_test_driver_gtests in CI #1401

Merged
houseroad merged 2 commits intoonnx:masterfrom
zrphercule:enable_CI
Sep 11, 2018
Merged

Enable onnxifi_test_driver_gtests in CI #1401
houseroad merged 2 commits intoonnx:masterfrom
zrphercule:enable_CI

Conversation

@zrphercule
Copy link
Copy Markdown
Contributor

Using onnxifi dummy backend.

Comment thread cmake/unittest.cmake Outdated
endif()

if(ONNX_DUMMY_BACKEND)
target_compile_definitions(${_UT_TARGET} PUBLIC "ONNX_DUMMY_BACKEND=true")
Copy link
Copy Markdown
Contributor

@rdzhabarov rdzhabarov Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need "-DONNX_DUMMY_BACKEND"? (but i'm not 100% certain)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually whether -D or not it doesnt works...

@zrphercule zrphercule changed the title [CI Testing][Dont Review/Merge]Enable onnxifi_test_driver_gtests in CI Enable onnxifi_test_driver_gtests in CI Sep 10, 2018
Copy link
Copy Markdown
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@houseroad houseroad merged commit 944db4f into onnx:master Sep 11, 2018
@zrphercule zrphercule deleted the enable_CI branch September 11, 2018 17:57
@zrphercule
Copy link
Copy Markdown
Contributor Author

@rdzhabarov oh I forgot telling you I updated the doc of "resolved" "unsolved" here =)

hariharans29 pushed a commit to hariharans29/onnx that referenced this pull request Aug 15, 2019
jcwchen pushed a commit to jcwchen/onnx that referenced this pull request Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants