Skip to content
This repository was archived by the owner on Mar 11, 2022. It is now read-only.

DTL and L2Geth fixes#383

Merged
CAPtheorem merged 7 commits intodevelopfrom
DTL-geth-fixes
Feb 17, 2022
Merged

DTL and L2Geth fixes#383
CAPtheorem merged 7 commits intodevelopfrom
DTL-geth-fixes

Conversation

@CAPtheorem
Copy link
Copy Markdown
Contributor

  1. Clean up the init for Turing fields inside the DTL
  2. Patch the print-ETH vulnerability (this was patched privately in the past; this is the public commit of the patch)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #383 (baf2b83) into develop (10774b0) will decrease coverage by 3.61%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #383      +/-   ##
===========================================
- Coverage    74.78%   71.17%   -3.62%     
===========================================
  Files           56       68      +12     
  Lines         1995     2331     +336     
  Branches       297      351      +54     
===========================================
+ Hits          1492     1659     +167     
- Misses         503      672     +169     
Flag Coverage Δ
batch-submitter 62.18% <ø> (ø)
contracts 87.18% <ø> (ø)
core-utils 53.79% <ø> (ø)
data-transport-layer 34.06% <0.00%> (?)
message-relayer 83.17% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../l1-ingestion/handlers/sequencer-batch-appended.ts 16.66% <0.00%> (ø)
packages/message-relayer/src/relay-tx.ts 82.52% <100.00%> (ø)
packages/message-relayer/hardhat.config.ts 100.00% <0.00%> (ø)
...ckages/data-transport-layer/src/utils/contracts.ts 22.72% <0.00%> (ø)
packages/data-transport-layer/src/utils/eth-tx.ts 85.71% <0.00%> (ø)
...layer/src/services/l1-ingestion/handlers/errors.ts 33.33% <0.00%> (ø)
packages/data-transport-layer/src/utils/common.ts 47.05% <0.00%> (ø)
...ices/l1-ingestion/handlers/state-batch-appended.ts 68.18% <0.00%> (ø)
.../src/services/l2-ingestion/handlers/transaction.ts 60.86% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10774b0...baf2b83. Read the comment docs.

@github-actions github-actions bot added the M-ops label Feb 17, 2022
@CAPtheorem CAPtheorem merged commit 3cc2634 into develop Feb 17, 2022
@CAPtheorem CAPtheorem deleted the DTL-geth-fixes branch February 17, 2022 21:01
InoMurko added a commit that referenced this pull request Feb 18, 2022
* Implement a basic Turing result cache.

 Changes to be committed:
	modified:   l2geth/core/vm/evm.go

* Require a cache hit on Turing transactions from the sequencer thread.
Users must now call eth_estimateGas first to populate the cache.

 On branch mm/turing-cache
 Changes to be committed:
	modified:   l2geth/core/vm/evm.go
	modified:   packages/boba/turing/contracts/TuringHelper.sol
	modified:   packages/boba/turing/test/002_math.ts
	modified:   packages/boba/turing/test/003_stable_swap.ts
	modified:   packages/boba/turing/test/005_lending.ts

* make lint to allow GH to pass; testing

* WIP - checkpoint.

 Changes to be committed:
	modified:   l2geth/core/error.go
	modified:   l2geth/core/state_processor.go
	modified:   l2geth/core/state_transition.go
	modified:   l2geth/core/vm/errors.go
	modified:   l2geth/core/vm/evm.go
	modified:   l2geth/core/vm/instructions.go
	modified:   l2geth/internal/ethapi/api.go
	modified:   l2geth/miner/worker.go
	modified:   l2geth/rpc/handler.go
	modified:   packages/boba/turing/test/002_math.ts

* WIP - checkpoint

 Changes to be committed:
	modified:   l2geth/core/state_processor.go
	modified:   l2geth/core/types/transaction.go
	modified:   l2geth/core/vm/evm.go

* Checkpoint - works, but ugly.
 Changes to be committed:
	modified:   l2geth/core/state_processor.go
	modified:   l2geth/internal/ethapi/api.go
	modified:   l2geth/miner/worker.go
	modified:   l2geth/rpc/handler.go

* Add state root verification in integration tests

* Clean up

* add new feeds to deploy script and cleanup examples

* add multi-oracle example

* fix example

* Add WBTCUSD and OMGUSD

* Update Wagmi_Howto.md

* Update Wagmi_Howto.md

* Update Wagmi_Howto.md

* Update Wagmi_Howto.md

* Update turing_oracle.py

* add gateway support for OLO

* Fix boba stake

* reduce the diff - dtl

* reduce the diff - dtl + turing

* reduce the diff - dtl + turing

* reduce the diff - update integration and ts packages execution in gh workflows

* reduce the diff startup sequence

* comment out expectApprox

* adjust deposit gas estimation tests

* change incorrect title, fix several console warnings

* enable active page memory

* upgrade to react 17.0.2

* upgrade to @mui

* Update ListSave.styles.js

* Update README.md

* Update evm.go

* Update yarn.lock

* fix test failure in DTL??? where did that come from?

* Update static-analysis.yml

* engineering draft

* Update Engineering_update_8.md

* Update Engineering_update_8.md

* Update Engineering_update_8.md

* Update Engineering_update_8.md

* Update Engineering_update_8.md

* upgrade to react 17.0.2

* upgrade to @mui

* Update ListSave.styles.js

* fix test failure in DTL??? where did that come from?

* Update static-analysis.yml

* missed a turing field

* fix race condition on startup

* Optimism changes 0.5.2->0.5.8

* add back the eth_getLogs range limiter

* final diffs to 0.5.8

* make lint

* Berlin hardfork experiment - Optimism PR ethereum-optimism/optimism#2095

* add L1Turing to transactionMeta

* Update ethclient.go

* Update gen_rpc_tx_meta_json.go

* make lint

* wip on stress-tests.spec

* reduce the diff

* missing fmt package

* deps fix

* lint in l2geth and yarn lock deps

* Revert "Merge branch 'gateway-package-upgrade' of github.com:omgnetwork/optimism-v2 into gateway-package-upgrade"

This reverts commit 00b25f6, reversing
changes made to c37680b.

* Update yarn.lock

* Update OVM_GasPriceOracle.spec.ts

* Update OVM_GasPriceOracle.spec.ts

* Require a cache hit during the real transaction execution. On a miss, rewind
the transaction without writing a failed receipt etc.; then call estimateGas
to run the transaction in a context which may block safely; then resubmit
the original transaction. This checkin implements the basic functionality but
it needs more testing and review.

 Changes to be committed:
	modified:   l2geth/core/error.go
	modified:   l2geth/core/state_processor.go
	modified:   l2geth/core/state_transition.go
	modified:   l2geth/core/types/transaction.go
	modified:   l2geth/core/vm/evm.go
	modified:   l2geth/core/vm/instructions.go
	modified:   l2geth/internal/ethapi/api.go
	modified:   l2geth/miner/worker.go
	modified:   l2geth/rollup/sync_service.go
	modified:   l2geth/rpc/handler.go
	modified:   packages/boba/turing/test/002_math.ts

* Lint fixes.
 Changes to be committed:
	modified:   core/error.go
	modified:   core/state_processor.go
	modified:   core/state_transition.go
	modified:   core/vm/evm.go
	modified:   core/vm/instructions.go
	modified:   internal/ethapi/api.go
	modified:   miner/worker.go
	modified:   rollup/sync_service.go

* assorted and sundry relating to the race condition

* Create Engineering_update_8.md

* tests: add oracle subscription tests

* remove commented code

* fix icon

* Optimism changes 0.5.2->0.5.8

* add back the eth_getLogs range limiter

* final diffs to 0.5.8

* make lint

* Berlin hardfork experiment - Optimism PR ethereum-optimism/optimism#2095

* add L1Turing to transactionMeta

* Update ethclient.go

* Update gen_rpc_tx_meta_json.go

* make lint

* wip on stress-tests.spec

* reduce the diff

* missing fmt package

* deps fix

* lint in l2geth and yarn lock deps

* deps fix

* linting in ts

* quick batch-submitter fix

* test fixes

* skip tests that need to warp l2 time

* update ovmcontext test and deps

* update tests

* fix ovmcontext tests

* remove only from ovmcontext tests

* t2.2xlarge

* remove only from ovmcontext tests

t2.2xlarge

add erc20 destroy

* add erc20 destroy

* comment out before all hook for should be able to unstake

* Fix watcher

* Remove some eslint packages

* Fix replica script for boba community

* Update yarn.lock

* lint fixes

* renable replica/verifier/fraud-prover

* Update up_local.sh

* Update integration.yml

* Fix verifier

* Create RoadmapFeb13_2022.svg

* Engineering update 9

* Update Engineering_update_9.md

* Add CTC deployment height in dtl

* Fix lint

* enable all tests

* enable all tests - remove uniswap

* pass in verifier and replica URLS to intg tests

* remove unused dependecy - uniswap

* test state root matching

* fixing tests

* remove docker from tests, leave replica running

* fix circular 'replica' test that tested the sequencer against itself

* turn off codechecks.io

* Turing monster Minting

* confirm function on rinkeby

* add turing-monster support to gateway

* Update Monster Minting Readme with faucet info

* Update README.md

* Add monster example (Using Turing to mint random monsters) (#388)

* improve monster color

* imporve documentation

* improve graphics

* fix color dynamic range

* Make a test transaction periodically (#387)

* add Boba periodic transferring in L2 to test

* update Boba contract link and Dockerfile platform

* update L2 web3 url for writing transaction

Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com>

* Inomurko/rem ts batch submitter (#390)

* add go batch-submitter

* fix gas-oracle linting

* fix turing new meta

* bss core + batch submitter updates

* bss core lint and tests

* set rpc urls

* retries and run all integration tests

* go batch submitter env var prefix/rename

* start removing TS batch submitter

Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com>

* add go batch-submitter (#331)

* add go batch-submitter

* fix gas-oracle linting

* fix turing new meta

* bss core + batch submitter updates

* bss core lint and tests

* set rpc urls

* retries and run all integration tests

* go batch submitter env var prefix/rename

Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com>

* Revert "add go batch-submitter (#331)" (#392)

This reverts commit edce670.

* Revert "Inomurko/rem ts batch submitter" (#394)

* Revert "Inomurko/rem ts batch submitter (#390)"

This reverts commit ac67ef8.

* solve gas oracle linting

* DTL and L2Geth fixes (#383)

* clean up init for the Turing field in the DTL

* patch the print-ETH vulnerability

* yarn lint

* Update config.go

* Add EMERGENCY_FORK_NUMBER

Co-authored-by: cby3149 <cby3149@gmail.com>
Co-authored-by: Ino Murko <ino.murko.github@protonmail.com>

* Add security alert in l2geth (#396)

* Add security alert

* Add global env for geth test

Co-authored-by: Michael Montour <mmontour@enya.ai>
Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com>
Co-authored-by: cby3149 <cby3149@gmail.com>
Co-authored-by: souradeep-das <dsouradeep2@gmail.com>
Co-authored-by: Boyuan-Chen <46272347+Boyuan-Chen@users.noreply.github.com>
Co-authored-by: cby3149 <cby3149@outlook.com>
Co-authored-by: trangtran-enya <83643565+trangtran-enya@users.noreply.github.com>
tgunnoe pushed a commit that referenced this pull request Mar 9, 2022
* clean up init for the Turing field in the DTL

* patch the print-ETH vulnerability

* yarn lint

* Update config.go

* Add EMERGENCY_FORK_NUMBER

Co-authored-by: cby3149 <cby3149@gmail.com>
Co-authored-by: Ino Murko <ino.murko.github@protonmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants