Skip to content
This repository was archived by the owner on Dec 5, 2021. It is now read-only.

Improve the way to query fast exit data#507

Merged
CAPtheorem merged 1 commit intodevelopfrom
improve-cdm-transaction-monitor
Sep 21, 2021
Merged

Improve the way to query fast exit data#507
CAPtheorem merged 1 commit intodevelopfrom
improve-cdm-transaction-monitor

Conversation

@boyuan-chen
Copy link
Copy Markdown

@boyuan-chen boyuan-chen commented Sep 21, 2021

The transaction monitor checks the status of fast cdm when it finds it regardless of the estimated finalized time. It increases the API call, but it can provide a better user experience. closed #503

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #507 (9dbf1db) into develop (443349d) will increase coverage by 9.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #507      +/-   ##
===========================================
+ Coverage    76.09%   86.05%   +9.95%     
===========================================
  Files           81       49      -32     
  Lines         3037     1936    -1101     
  Branches       469      307     -162     
===========================================
- Hits          2311     1666     -645     
+ Misses         726      270     -456     
Flag Coverage Δ
batch-submitter ?
contracts 86.05% <ø> (ø)
core-utils ?
data-transport-layer ?
message-relayer ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/data-transport-layer/src/utils/contracts.ts
...ices/l1-ingestion/handlers/state-batch-appended.ts
packages/data-transport-layer/src/utils/eth-tx.ts
packages/data-transport-layer/src/utils/common.ts
packages/core-utils/src/common/index.ts
packages/core-utils/src/common/misc.ts
...ubmitter/src/batch-submitter/tx-batch-submitter.ts
packages/core-utils/src/coders/index.ts
packages/batch-submitter/hardhat.config.ts
...h-submitter/src/batch-submitter/batch-submitter.ts
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 443349d...9dbf1db. Read the comment docs.

@CAPtheorem CAPtheorem merged commit c12bb9a into develop Sep 21, 2021
@boyuan-chen boyuan-chen deleted the improve-cdm-transaction-monitor branch September 21, 2021 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gateway: transaction watcher api does not immediately catch all cleared transactions, leading to confusing pending messages

3 participants