Skip to content
This repository was archived by the owner on Dec 5, 2021. It is now read-only.

build and publish latest images#26

Merged
InoMurko merged 1 commit intodevelopfrom
inomurko/develop-containers
Jun 1, 2021
Merged

build and publish latest images#26
InoMurko merged 1 commit intodevelopfrom
inomurko/develop-containers

Conversation

@InoMurko
Copy link
Copy Markdown

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 28, 2021

Codecov Report

Merging #26 (3185564) into develop (58e75b9) will not change coverage.
The diff coverage is n/a.

❗ Current head 3185564 differs from pull request most recent head 7a96790. Consider uploading reports for the commit 7a96790 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #26   +/-   ##
========================================
  Coverage    80.55%   80.55%           
========================================
  Files           49       49           
  Lines         1934     1934           
  Branches       311      311           
========================================
  Hits          1558     1558           
  Misses         376      376           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e75b9...7a96790. Read the comment docs.

Copy link
Copy Markdown

@CAPtheorem CAPtheorem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - suggest renaming so it's clear that its part of the omgx stack

@InoMurko InoMurko force-pushed the inomurko/develop-containers branch from 94c1a8e to 3185564 Compare May 31, 2021 22:07
build and publish latest images

build and publish latest images

publish geth develop

publish geth develop

publish develop images on develop branch only
@InoMurko InoMurko force-pushed the inomurko/develop-containers branch from 3185564 to 7a96790 Compare May 31, 2021 22:08
@InoMurko InoMurko requested review from kevsul and souradeep-das May 31, 2021 22:08
@InoMurko
Copy link
Copy Markdown
Author

Looks great - suggest renaming so it's clear that its part of the omgx stack

done!

push: true
tags: omgx/deployer:develop

integration_tests:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to call this integration-tests for consistency with naming convention - seems minor but broke the stack before

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the links point to existing integration_tests

@InoMurko InoMurko merged commit 1cb08e7 into develop Jun 1, 2021
@InoMurko InoMurko deleted the inomurko/develop-containers branch June 1, 2021 12:34
InoMurko pushed a commit that referenced this pull request Jul 12, 2021
refactor base64 decoding and slicing
InoMurko pushed a commit that referenced this pull request Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants