This repository was archived by the owner on Dec 5, 2021. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #19 +/- ##
========================================
Coverage 82.21% 82.21%
========================================
Files 48 48
Lines 1895 1895
Branches 303 303
========================================
Hits 1558 1558
Misses 337 337 Continue to review full report at Codecov.
|
|
Great work, but can we add some CI integration and enable continuous testing? |
InoMurko
pushed a commit
that referenced
this pull request
Jul 12, 2021
dont execute tests just migrate
InoMurko
pushed a commit
that referenced
this pull request
Jul 18, 2021
Removed unrelated files and added .env
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the fraud-prover service
CAUTION - the fraud prover does not currently work - it's able to detect fraud, but currently unable to correctly
_initializeFraudVerification, so that and all downstream steps fail.Specifically, the fraud prover triggers a revert at
VM Exception while processing transaction: revert Pre-state root global index must equal to the transaction root global indexinOVM_FraudVerifier.solline 134:This issue may be related to (1) injecting fraud via the Batch_submitter, and more generally, (2) fraud proving and correction in the setting of batch submissions, rather than unitary test submissions.
ToDo: The fraud prover currently is brittle, in the sense that it fails silently for many error conditions and e.g. empty returns. There are also many issues relating to indexing of various data structures, especially for batch transactions.