make individual errors in a failed test more clearly visible#167
make individual errors in a failed test more clearly visible#167oli-obk merged 4 commits intooli-obk:mainfrom
Conversation
e924e14 to
bedc88a
Compare
|
We could also use the snippets logic we use for spanned errors, so you'd get it in the same format and style (red |
|
Yeah that would be the other option I guess. We need to be careful to make this still clearly "smaller" than the separator that introduces the messages for each test failure: Maybe if it looks like this that is enough? The all-caps and the underline then hopefully clearly separate multiple failed tests. |
|
Yea that sounds good to me. |
bedc88a to
742effe
Compare
|
I think |
f3ea9a7 to
602772a
Compare
|
I love it, thanks! |
|
Yeah I'm quite happy with it. Can't wait to see it in Miri. Just needs a release now. nudge wink ;) |
|
I can do releases from gha, I just can't do the version bump from it 😃 I'll do both tomorrow |
|
No worries, not urgent at all. :) |
update ui_test In particular this includes oli-obk/ui_test#167 :)
update ui_test In particular this includes oli-obk/ui_test#167 :)
update ui_test In particular this includes oli-obk/ui_test#167 :)



In large errors I feel it is easy to miss when somewhere at the top it also says "got exit status: 0, but expected 1", or so.
Ideally all errors would do this consistently, e.g. start with a underlined title and then perhaps have more details. However that doesn't really work for the errors that show a span... but maybe ut's worth doing that at least for these two otherwise-easy-to-miss errors?