Avoid cloning tx during payload execution#29
Merged
louisliu2048 merged 2 commits intodevfrom Nov 10, 2025
Merged
Conversation
Vui-Chee
commented
Nov 10, 2025
| // This ensures that intercepted transactions are not committed to the block state, | ||
| // preventing tx number inconsistencies in static files. | ||
| let gas_used = match builder.execute_transaction_with_commit_condition( | ||
| tx.clone(), |
JimmyShi22
approved these changes
Nov 10, 2025
Vui-Chee
added a commit
that referenced
this pull request
Nov 11, 2025
* dev: (458 commits) Ignore xlayer-e2e-test during integration testing (#32) feat(genesis): optimize genesis loading with built-in xlayer specs (#23) Mirror default timeout in `clap` args struct (#31) fix constraint (#30) support trace tx log (#16) Avoid cloning tx during payload execution (#29) Feature: import blockchain data into op-reth (#20) perf(cargo): Use alloy 1.1.0 and fix some warning issue (#26) feat: Add E2E Test Suite (#19) fix tx number inconsistencies issue cause by intercept bridge function (#25) fix build error feat: integrate Apollo dynamic configuration (#8) feat: support `eth_transactionPreExec` api (#10) chore: bump version chore: bump revm v31.0.1 (paradigmxyz#19567) Xiong/block bridge okb (#21) feat: Add legacy RPC routing support for historical block data migration (#6) feat(genesis): Support legacyXLayerBlock in genesis.json (#11) chore: Update cursor rules, add rust comprehensive cursor rules (#17) chore: bump v1.9.0 (paradigmxyz#19507) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized we clone the entire tx before execution, what we can do is pull out some fields before moving the tx into function for execution.