Merged
Conversation
rbajollari
added a commit
that referenced
this pull request
Jul 19, 2024
adamewozniak
approved these changes
Jul 25, 2024
Member
adamewozniak
left a comment
There was a problem hiding this comment.
LGTM, just needs a test for the conversion function
Member
Author
|
@Mergifyio backport release/v0.3.x |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
* chore: v0.3.2 upgrade handler * convert proposals * lint * migrate proposal test (cherry picked from commit faac055) # Conflicts: # app/upgrades.go
17 tasks
adamewozniak
pushed a commit
that referenced
this pull request
Jul 29, 2024
* chore: v0.3.2 upgrade handler (#481) * chore: v0.3.2 upgrade handler * convert proposals * lint * migrate proposal test (cherry picked from commit faac055) # Conflicts: # app/upgrades.go * fix conflicts * new pf version in e2w --------- Co-authored-by: ryanbajollari <54822716+rbajollari@users.noreply.github.com> Co-authored-by: rbajollari <rbajollari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...