Skip to content

fix: Implement LegacyGovUpdateParams for querying legacy proposals#476

Merged
rbajollari merged 4 commits intomainfrom
ryan/fix-legacy-govupdateparams
Jul 12, 2024
Merged

fix: Implement LegacyGovUpdateParams for querying legacy proposals#476
rbajollari merged 4 commits intomainfrom
ryan/fix-legacy-govupdateparams

Conversation

@rbajollari
Copy link
Copy Markdown
Member

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rbajollari rbajollari requested a review from a team as a code owner July 12, 2024 17:12
@rbajollari rbajollari added the S:backport/v0.3.x Backports to the release/v0.3.x branch label Jul 12, 2024
@rbajollari rbajollari merged commit 71d54a4 into main Jul 12, 2024
@rbajollari rbajollari deleted the ryan/fix-legacy-govupdateparams branch July 12, 2024 18:25
mergify bot pushed a commit that referenced this pull request Jul 12, 2024
)

* fix: Implement LegacyGovUpdateParams for querying legacy proposals

* buf-lint

* lint

* upgrade handler

(cherry picked from commit 71d54a4)

# Conflicts:
#	app/upgrades.go
#	x/oracle/types/msgs.go
#	x/oracle/types/tx.pb.go
rbajollari added a commit that referenced this pull request Jul 12, 2024
…ackport #476) (#477)

* fix: Implement LegacyGovUpdateParams for querying legacy proposals (#476)

* fix: Implement LegacyGovUpdateParams for querying legacy proposals

* buf-lint

* lint

* upgrade handler

(cherry picked from commit 71d54a4)

# Conflicts:
#	app/upgrades.go
#	x/oracle/types/msgs.go
#	x/oracle/types/tx.pb.go

* fix conflicts

* tx.pb conflict

---------

Co-authored-by: ryanbajollari <54822716+rbajollari@users.noreply.github.com>
Co-authored-by: rbajollari <rbajollari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S:backport/v0.3.x Backports to the release/v0.3.x branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants