Skip to content

chore(deps): bump wagoid/commitlint-github-action from 4.1.4 to 4.1.5#10

Merged
ernado merged 1 commit intomainfrom
dependabot/github_actions/wagoid/commitlint-github-action-4.1.5
Oct 4, 2021
Merged

chore(deps): bump wagoid/commitlint-github-action from 4.1.4 to 4.1.5#10
ernado merged 1 commit intomainfrom
dependabot/github_actions/wagoid/commitlint-github-action-4.1.5

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 4, 2021

Bumps wagoid/commitlint-github-action from 4.1.4 to 4.1.5.

Changelog

Sourced from wagoid/commitlint-github-action's changelog.

4.1.5 (2021-10-01)

Commits
  • 8d669e3 chore(release): publish 4.1.5 [skip-ci]
  • 06bd01f chore(deps): bump actions/setup-node from 2.4.0 to 2.4.1 (#239)
  • d64c041 chore(deps): bump @​actions/core from 1.5.0 to 1.6.0 (#240)
  • b3d9151 chore(deps-dev): bump @​jest/globals from 27.1.1 to 27.2.4 (#241)
  • 8afa4f7 chore(deps-dev): bump jest from 27.1.1 to 27.2.4 (#242)
  • 72a676a chore(deps-dev): bump @​rollup/plugin-node-resolve from 13.0.4 to 13.0.5 (#251)
  • 67d03d3 chore(deps-dev): bump prettier from 2.3.2 to 2.4.1 (#238)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [wagoid/commitlint-github-action](https://github.com/wagoid/commitlint-github-action) from 4.1.4 to 4.1.5.
- [Release notes](https://github.com/wagoid/commitlint-github-action/releases)
- [Changelog](https://github.com/wagoid/commitlint-github-action/blob/master/CHANGELOG.md)
- [Commits](wagoid/commitlint-github-action@v4.1.4...v4.1.5)

---
updated-dependencies:
- dependency-name: wagoid/commitlint-github-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code labels Oct 4, 2021
@ernado ernado merged commit 4e9237c into main Oct 4, 2021
@ernado ernado deleted the dependabot/github_actions/wagoid/commitlint-github-action-4.1.5 branch October 4, 2021 03:56
ernado pushed a commit that referenced this pull request Nov 25, 2025
Empty schemas (nil schema in OpenAPI specs) represent "any valid JSON value"
according to JSON Schema specification. Previously these were treated as
errors, but they should be handled as ir.Any (jx.Raw in Go).

This commonly occurs in request/response bodies with content but no schema:
{"content": {"application/json": {}}}

Changes:
- Modified schema_gen.go to return ir.Any(nil) for nil schemas
- Added documentation explaining empty schema semantics
- Aligned with existing array handling (line 431)
- Added regression test TestSchemaGenNilSchema
- Moved response_content_schema.json from negative to positive testdata

Fixes #10
ernado pushed a commit that referenced this pull request Nov 25, 2025
Empty schemas (missing schema field in OpenAPI media type objects) now have
context-aware handling:

**Responses**: Generate jx.Raw (any JSON value)
- Allows clients to handle unknown JSON structures from servers
- Solves issue #10 for default error responses and flexible APIs
- Consistent with JSON Schema spec (empty schema = any JSON)

**Requests**: Return error "empty schema in request body"
- Prevents clients from sending arbitrary data without spec guidance
- More conservative approach - requires explicit schema or ignore flag
- Avoids over-permissive APIs where spec doesn't define structure

Changes:
- Added `request bool` field to `generateSchemaOverride` and `schemaGen`
- Modified `generate2()` to check context before handling nil schemas
- Updated `generateContents()` to pass request flag via override
- Split test into separate Response/Request test cases
- Updated test data to use response-only empty schema test

Fixes #10
lanej added a commit to lanej/ogen that referenced this pull request Nov 25, 2025
Empty schemas (missing schema field in OpenAPI media type objects) now have
context-aware handling:

**Responses**: Generate jx.Raw (any JSON value)
- Allows clients to handle unknown JSON structures from servers
- Solves empty response schema issue for default errors and flexible APIs
- Consistent with JSON Schema spec (empty schema = any JSON)

**Requests**: Return error "empty schema in request body"
- Prevents clients from sending arbitrary data without spec guidance
- More conservative approach - requires explicit schema or ignore flag
- Avoids over-permissive APIs where spec doesn't define structure

Changes:
- Added `request bool` field to `generateSchemaOverride` and `schemaGen`
- Modified `generate2()` to check context before handling nil schemas
- Updated `generateContents()` to pass request flag via override
- Split test into separate Response/Request test cases
- Updated test data to use response-only empty schema test

Follows Postel's Law: be liberal in what you accept, conservative in what you send.

Related to ogen-go#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant