[FIX] mrp: split call to write on stock move#69377
Closed
Conversation
Contributor
|
|
b6b533f to
e24cb44
Compare
d2f31f2 to
0f09f19
Compare
Contributor
|
@Whenrow Hello, this looks good now, could we move forward or is there something else left to do? |
Contributor
|
robodoo r+ |
Contributor
|
Unable to stage PR ({"message":"Merge conflict","documentation_url":"https://docs.github.com/rest/reference/repos#merge-a-branch"}) |
You can, in a production order, change the quantity done of a stock move
raw and change its initial demand ('To Consume' field) in the same
transaction. This can lead to some issue as changing the quantity done
will update the stock move line and changing the initial demand will
unreserve the stock move thus impacting the stock move lines too.
This commit will split the values to update of a stock in move in case
the two fields have to be updated. First the stock move lines, then the
initial demand.
This commit also remove the default_product_uom_qty in the move_raw_ids
fields. This ensure the onchanges do not create/edit any stock move lines
with some reserved quantity.
opw : 2451298
0f09f19 to
83d53fd
Compare
Contributor
|
robodoo retry |
Contributor
|
I'm sorry, @agr-odoo. Retry makes no sense when the PR is not in error. |
Contributor
|
robodoo r+ |
Contributor
|
This pull request has forward-port PRs awaiting action (not merged or closed): #70702 |
3 similar comments
Contributor
|
This pull request has forward-port PRs awaiting action (not merged or closed): #70702 |
Contributor
|
This pull request has forward-port PRs awaiting action (not merged or closed): #70702 |
Contributor
|
This pull request has forward-port PRs awaiting action (not merged or closed): #70702 |
This was referenced May 18, 2021
amoyaux
added a commit
to odoo-dev/odoo
that referenced
this pull request
Nov 5, 2021
It happens that the `stock.quant.reserved_quantity` and `stock.move.line.product_qty` for the same parameters are not equals (due to some bugs in the past) It could implies that it doesn't exist enough reserved quantity on the quant when a user try to unreserve a stock.move.line resulting in the UserError 'It is not possible to unreserve more products of %s than you have in stock' However on current stable version (13.0 and 14.0) a lot of PR already fixed a lot of issue as: odoo#69377 odoo#66347 odoo#61758 odoo#54355 odoo#43180 odoo#70975 for example (there is more than that) So the idea is to provide a way to unlock the database manually for stable but not in the new version to be able to analyse them and find possible bugs responssible for the desynchronization. The server action check all the quants and their relative move line to check if match correctly. If not it will remove the reservation from both. It could remove the reservation from some `pickings` and `stock.move` related to odoo#62139
amoyaux
added a commit
to odoo-dev/odoo
that referenced
this pull request
Nov 29, 2021
It happens that the `stock.quant.reserved_quantity` and `stock.move.line.product_qty` for the same parameters are not equals (due to some bugs in the past) It could implies that it doesn't exist enough reserved quantity on the quant when a user try to unreserve a stock.move.line resulting in the UserError 'It is not possible to unreserve more products of %s than you have in stock' However on current stable version (13.0 and 14.0) a lot of PR already fixed a lot of issue as: odoo#69377 odoo#66347 odoo#61758 odoo#54355 odoo#43180 odoo#70975 for example (there is more than that) So the idea is to provide a way to unlock the database manually for stable but not in the new version to be able to analyse them and find possible bugs responssible for the desynchronization. The server action check all the quants and their relative move line to check if match correctly. If not it will remove the reservation from both. It could remove the reservation from some `pickings` and `stock.move` related to odoo#62139
amoyaux
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 9, 2021
It happens that the `stock.quant.reserved_quantity` and `stock.move.line.product_qty` for the same parameters are not equals (due to some bugs in the past) It could implies that it doesn't exist enough reserved quantity on the quant when a user try to unreserve a stock.move.line resulting in the UserError 'It is not possible to unreserve more products of %s than you have in stock' However on current stable version (13.0 and 14.0) a lot of PR already fixed a lot of issue as: odoo#69377 odoo#66347 odoo#61758 odoo#54355 odoo#43180 odoo#70975 for example (there is more than that) So the idea is to provide a way to unlock the database manually for stable but not in the new version to be able to analyse them and find possible bugs responssible for the desynchronization. The server action check all the quants and their relative move line to check if match correctly. If not it will remove the reservation from both. It could remove the reservation from some `pickings` and `stock.move` related to odoo#62139
robodoo
pushed a commit
that referenced
this pull request
Dec 9, 2021
It happens that the `stock.quant.reserved_quantity` and `stock.move.line.product_qty` for the same parameters are not equals (due to some bugs in the past) It could implies that it doesn't exist enough reserved quantity on the quant when a user try to unreserve a stock.move.line resulting in the UserError 'It is not possible to unreserve more products of %s than you have in stock' However on current stable version (13.0 and 14.0) a lot of PR already fixed a lot of issue as: #69377 #66347 #61758 #54355 #43180 #70975 for example (there is more than that) So the idea is to provide a way to unlock the database manually for stable but not in the new version to be able to analyse them and find possible bugs responssible for the desynchronization. The server action check all the quants and their relative move line to check if match correctly. If not it will remove the reservation from both. It could remove the reservation from some `pickings` and `stock.move` related to #62139 closes #79180 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
amoyaux
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 9, 2021
It happens that the `stock.quant.reserved_quantity` and `stock.move.line.product_qty` for the same parameters are not equals (due to some bugs in the past) It could implies that it doesn't exist enough reserved quantity on the quant when a user try to unreserve a stock.move.line resulting in the UserError 'It is not possible to unreserve more products of %s than you have in stock' However on current stable version (13.0 and 14.0) a lot of PR already fixed a lot of issue as: odoo#69377 odoo#66347 odoo#61758 odoo#54355 odoo#43180 odoo#70975 for example (there is more than that) So the idea is to provide a way to unlock the database manually for stable but not in the new version to be able to analyse them and find possible bugs responssible for the desynchronization. The server action check all the quants and their relative move line to check if match correctly. If not it will remove the reservation from both. It could remove the reservation from some `pickings` and `stock.move` related to odoo#62139 X-original-commit: d99e173
robodoo
pushed a commit
that referenced
this pull request
Dec 9, 2021
It happens that the `stock.quant.reserved_quantity` and `stock.move.line.product_qty` for the same parameters are not equals (due to some bugs in the past) It could implies that it doesn't exist enough reserved quantity on the quant when a user try to unreserve a stock.move.line resulting in the UserError 'It is not possible to unreserve more products of %s than you have in stock' However on current stable version (13.0 and 14.0) a lot of PR already fixed a lot of issue as: #69377 #66347 #61758 #54355 #43180 #70975 for example (there is more than that) So the idea is to provide a way to unlock the database manually for stable but not in the new version to be able to analyse them and find possible bugs responssible for the desynchronization. The server action check all the quants and their relative move line to check if match correctly. If not it will remove the reservation from both. It could remove the reservation from some `pickings` and `stock.move` related to #62139 closes #81127 X-original-commit: d99e173 Signed-off-by: William Henrotin (whe) <whe@odoo.com> Signed-off-by: Arnold Moyaux <arm@odoo.com>
odooaktiv
pushed a commit
to odooaktiv/odoo
that referenced
this pull request
Jun 13, 2022
It happens that the `stock.quant.reserved_quantity` and `stock.move.line.product_qty` for the same parameters are not equals (due to some bugs in the past) It could implies that it doesn't exist enough reserved quantity on the quant when a user try to unreserve a stock.move.line resulting in the UserError 'It is not possible to unreserve more products of %s than you have in stock' However on current stable version (13.0 and 14.0) a lot of PR already fixed a lot of issue as: odoo#69377 odoo#66347 odoo#61758 odoo#54355 odoo#43180 odoo#70975 for example (there is more than that) So the idea is to provide a way to unlock the database manually for stable but not in the new version to be able to analyse them and find possible bugs responssible for the desynchronization. The server action check all the quants and their relative move line to check if match correctly. If not it will remove the reservation from both. It could remove the reservation from some `pickings` and `stock.move` related to odoo#62139 closes odoo#81127 X-original-commit: d99e173 Signed-off-by: William Henrotin (whe) <whe@odoo.com> Signed-off-by: Arnold Moyaux <arm@odoo.com>
antonioburic
pushed a commit
to VanMoof/odoo
that referenced
this pull request
Jul 31, 2022
It happens that the `stock.quant.reserved_quantity` and `stock.move.line.product_qty` for the same parameters are not equals (due to some bugs in the past) It could implies that it doesn't exist enough reserved quantity on the quant when a user try to unreserve a stock.move.line resulting in the UserError 'It is not possible to unreserve more products of %s than you have in stock' However on current stable version (13.0 and 14.0) a lot of PR already fixed a lot of issue as: odoo#69377 odoo#66347 odoo#61758 odoo#54355 odoo#43180 odoo#70975 for example (there is more than that) So the idea is to provide a way to unlock the database manually for stable but not in the new version to be able to analyse them and find possible bugs responssible for the desynchronization. The server action check all the quants and their relative move line to check if match correctly. If not it will remove the reservation from both. It could remove the reservation from some `pickings` and `stock.move` related to odoo#62139 closes odoo#79180 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
sergiocorato
pushed a commit
to efatto/OCB
that referenced
this pull request
Sep 15, 2022
It happens that the `stock.quant.reserved_quantity` and `stock.move.line.product_qty` for the same parameters are not equals (due to some bugs in the past) It could implies that it doesn't exist enough reserved quantity on the quant when a user try to unreserve a stock.move.line resulting in the UserError 'It is not possible to unreserve more products of %s than you have in stock' However on current stable version (13.0 and 14.0) a lot of PR already fixed a lot of issue as: odoo#69377 odoo#66347 odoo#61758 odoo#54355 odoo#43180 odoo#70975 for example (there is more than that) So the idea is to provide a way to unlock the database manually for stable but not in the new version to be able to analyse them and find possible bugs responssible for the desynchronization. The server action check all the quants and their relative move line to check if match correctly. If not it will remove the reservation from both. It could remove the reservation from some `pickings` and `stock.move` related to odoo#62139 closes odoo#81127 X-original-commit: d99e173 Signed-off-by: William Henrotin (whe) <whe@odoo.com> Signed-off-by: Arnold Moyaux <arm@odoo.com>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Jan 11, 2023
It happens that the `stock.quant.reserved_quantity` and `stock.move.line.product_qty` for the same parameters are not equals (due to some bugs in the past) It could implies that it doesn't exist enough reserved quantity on the quant when a user try to unreserve a stock.move.line resulting in the UserError 'It is not possible to unreserve more products of %s than you have in stock' However on current stable version (13.0 and 14.0) a lot of PR already fixed a lot of issue as: odoo/odoo#69377 odoo/odoo#66347 odoo/odoo#61758 odoo/odoo#54355 odoo/odoo#43180 odoo/odoo#70975 for example (there is more than that) So the idea is to provide a way to unlock the database manually for stable but not in the new version to be able to analyse them and find possible bugs responssible for the desynchronization. The server action check all the quants and their relative move line to check if match correctly. If not it will remove the reservation from both. It could remove the reservation from some `pickings` and `stock.move` related to odoo/odoo#62139 closes odoo/odoo#79180 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can, in a production order, change the quantity done of a stock move
raw and change its initial demand ('To Consume' field) in the same
transaction. This can lead to some issue as changing the quantity done
will update the stock move line and changing the initial demand will
unreserve the stock move thus impacting the stock move lines too.
This commit will split the values to update of a stock in move in case
the two fields have to be updated. First the stock move lines, then the
initial demand.
opw : 2451298
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr