Skip to content

[FW][FIX] stock: put in pack and unreserve#54332

Closed
fw-bot wants to merge 1 commit intoodoo:saas-12.3from
odoo-dev:saas-12.3-12.0-opw-2288208-unreserve-nim-Z38v-fw
Closed

[FW][FIX] stock: put in pack and unreserve#54332
fw-bot wants to merge 1 commit intoodoo:saas-12.3from
odoo-dev:saas-12.3-12.0-opw-2288208-unreserve-nim-Z38v-fw

Conversation

@fw-bot
Copy link
Copy Markdown
Contributor

@fw-bot fw-bot commented Jul 10, 2020

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #54328

@robodoo robodoo added conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot seen 🙂 labels Jul 10, 2020
@fw-bot
Copy link
Copy Markdown
Contributor Author

fw-bot commented Jul 10, 2020

Ping @nim-odoo
Cherrypicking 8c96555 of source #54328 failed

stderr:

error: could not apply 8c965550ed9... [FIX] stock: put in pack and unreserve
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Jul 10, 2020
- Create a product P, tracked by lot
- Add some stock with a lot
- Create an outgoing picking
- Set 10 units of P
- Set 2 done, Put in Pack
- Unreserve

An error occurs: 'It is not possible to unreserve more products of P
than you have in stock.'

It happens because the `lot_id` is removed from the copied
`stock.move.line`.

Commit eac8c06 makes sense for incoming pickings, but
not for internal or outgoing transfers.

opw-2288208

X-original-commit: 5712850
@nim-odoo nim-odoo force-pushed the saas-12.3-12.0-opw-2288208-unreserve-nim-Z38v-fw branch from f44c484 to 99c1c68 Compare July 10, 2020 15:03
Copy link
Copy Markdown
Contributor

@nim-odoo nim-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo p=1
robodoo r+

@robodoo robodoo added r+ 👌 CI 🤖 Robodoo has seen passing statuses labels Jul 10, 2020
robodoo pushed a commit that referenced this pull request Jul 10, 2020
- Create a product P, tracked by lot
- Add some stock with a lot
- Create an outgoing picking
- Set 10 units of P
- Set 2 done, Put in Pack
- Unreserve

An error occurs: 'It is not possible to unreserve more products of P
than you have in stock.'

It happens because the `lot_id` is removed from the copied
`stock.move.line`.

Commit eac8c06 makes sense for incoming pickings, but
not for internal or outgoing transfers.

opw-2288208

closes #54332

X-original-commit: 5712850
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
@robodoo robodoo closed this Jul 10, 2020
@robodoo robodoo temporarily deployed to merge July 10, 2020 16:15 Inactive
@fw-bot fw-bot deleted the saas-12.3-12.0-opw-2288208-unreserve-nim-Z38v-fw branch July 24, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI 🤖 Robodoo has seen passing statuses conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants