Skip to content

[FW][FIX] stock: forbid to modify product on done move line#43150

Closed
fw-bot wants to merge 1 commit intoodoo:13.0from
odoo-dev:13.0-11.0-import_done_move_line-arm-DSgB-fw
Closed

[FW][FIX] stock: forbid to modify product on done move line#43150
fw-bot wants to merge 1 commit intoodoo:13.0from
odoo-dev:13.0-11.0-import_done_move_line-arm-DSgB-fw

Conversation

@fw-bot
Copy link
Copy Markdown
Contributor

@fw-bot fw-bot commented Jan 10, 2020

It happens that people modify the product on done stock.move.line
(it's not possible without customisation, at least allow to import or
to modify product and lot_id in the same view).

During the write on stock.move.line only the lot,locations,package and
owner are update on the quant. Not the product since it's not suppose to
be modify. It leads to a stock.move.line with a correct information but
a total mess on the quants with a lot updated and the previous product.
Since the product is not modified, the product on the quant and the
product on the lot linked to the same quant are different.

Task: 2119471

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #42608

@fw-bot
Copy link
Copy Markdown
Contributor Author

fw-bot commented Jan 10, 2020

Ping @amoyaux, @nim-odoo
Cherrypicking 3491a5d of source #42608 failed

stderr:

error: could not apply 3491a5dc933... [FIX] stock: forbid to modify product on done move line
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

@robodoo robodoo added seen 🙂 conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot labels Jan 10, 2020
@C3POdoo C3POdoo added the RD research & development, internal work label Jan 10, 2020
It happens that people modify the product on done stock.move.line
(it's not possible without customisation, at least allow to import or
to modify product and lot_id in the same view).

During the write on stock.move.line only the lot,locations,package and
owner are update on the quant. Not the product since it's not suppose to
be modify. It leads to a stock.move.line with a correct information but
a total mess on the quants with a lot updated and the previous product.
Since the product is not modified, the product on the quant and the
product on the lot linked to the same quant are different.

Task: 2119471
X-original-commit: 3ec96c3
@amoyaux amoyaux force-pushed the 13.0-11.0-import_done_move_line-arm-DSgB-fw branch from 57c4c51 to d6193dc Compare January 13, 2020 08:30
@nim-odoo
Copy link
Copy Markdown
Contributor

robodoo r+

@robodoo robodoo added r+ 👌 CI 🤖 Robodoo has seen passing statuses labels Jan 13, 2020
@robodoo robodoo closed this in f2a4f70 Jan 13, 2020
@robodoo robodoo temporarily deployed to merge January 13, 2020 09:55 Inactive
@fw-bot fw-bot deleted the 13.0-11.0-import_done_move_line-arm-DSgB-fw branch January 27, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI 🤖 Robodoo has seen passing statuses conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants