[FIX] stock: forbid to modify product on done move line#42608
[FIX] stock: forbid to modify product on done move line#42608
Conversation
3b32cd3 to
784faa7
Compare
There was a problem hiding this comment.
also problematic is assigned and partially available.. and maybe the source of "the cannot unreserve more than.." tickets
if a sml is reserved and the product is changed trough an import, the original quant stays reserved and some of the newly changed producs are unreserved
cc @nvn-odoo @jev-odoo
There was a problem hiding this comment.
i would change the message to
"Changing the product of this record is forbidden at this point."
There was a problem hiding this comment.
If you suggest changing the message, then the 'at this point' seems not very precise for the customer.
It could be "Changing the product of this record is forbidden on state 'Done'." or something like that. The more precise info for the customer, the less Support ticket ;)
There was a problem hiding this comment.
@sle-odoo indeed, thank you for the notification :-)
784faa7 to
37807f5
Compare
37807f5 to
ef3b7a1
Compare
|
@nim-odoo Could you check? |
There was a problem hiding this comment.
Missing the _() translation function?
By the way, the wording of the error message is not clear and WILL trigger support tickets of customers asking what means this record and at this point
Can we use something like "Editing the product set on this stock move line is not allowed as some stock changes are already taken into account"?
Thanks :)
There was a problem hiding this comment.
please note that you cannot get this error issue without editing the views and removing the readonly or exporting the ml/changing the product_id/reimporting them, so you won't get more tickets before since the concerned users already fucked their inventory at this point and thus already opened tickets with "cannot unreserve more than"
imo it's not important to have a super clear and specific error messages here, blocking the flow is important
anyway let nim decide
ef3b7a1 to
cfc8bce
Compare
nim-odoo
left a comment
There was a problem hiding this comment.
I'm not against the change, but since the issue can only appear if the user is doing something nasty I'd go more for a fix in v13. About the wording, maybe something like:
Changing the product is only allowed in 'Draft' state.
The average Joe doesn't know what is a 'record'. Moreover, they know when they can do it. With the current wording, they only know when they cannot do it.
cfc8bce to
bf424b1
Compare
It happens that people modify the product on done stock.move.line (it's not possible without customisation, at least allow to import or to modify product and lot_id in the same view). During the write on stock.move.line only the lot,locations,package and owner are update on the quant. Not the product since it's not suppose to be modify. It leads to a stock.move.line with a correct information but a total mess on the quants with a lot updated and the previous product. Since the product is not modified, the product on the quant and the product on the lot linked to the same quant are different. Task: 2119471
bf424b1 to
3491a5d
Compare
It happens that people modify the product on done stock.move.line (it's not possible without customisation, at least allow to import or to modify product and lot_id in the same view). During the write on stock.move.line only the lot,locations,package and owner are update on the quant. Not the product since it's not suppose to be modify. It leads to a stock.move.line with a correct information but a total mess on the quants with a lot updated and the previous product. Since the product is not modified, the product on the quant and the product on the lot linked to the same quant are different. closes #42608 Task: 2119471 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
|
Staging failed: timed out (>120 minutes) |
|
robodoo retry |
|
Staging failed: timed out (>120 minutes) |
|
robodoo retry |
It happens that people modify the product on done stock.move.line
(it's not possible without customisation, at least allow to import or
to modify product and lot_id in the same view).
During the write on stock.move.line only the lot,locations,package and
owner are update on the quant. Not the product since it's not suppose to
be modify. It leads to a stock.move.line with a correct information but
a total mess on the quants with a lot updated and the previous product.
Since the product is not modified, the product on the quant and the
product on the lot linked to the same quant are different.
Task: 2119471
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr