Skip to content

[FIX] *: support for pylint 4#236447

Closed
fw-bot wants to merge 1 commit intoodoo:18.0from
odoo-dev:18.0-17.0-astroid-4-compat-xmo-478011-fw
Closed

[FIX] *: support for pylint 4#236447
fw-bot wants to merge 1 commit intoodoo:18.0from
odoo-dev:18.0-17.0-astroid-4-compat-xmo-478011-fw

Conversation

@fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Nov 19, 2025

  • astroid 4 deprecates toplevel exports of nodes, thankfully that was never actually necessary so we can just import that unconditionally
  • remove support for pre-jammy pylint / astroid, specifically astroid.nodes was added in astroid 2.7.0 and astroid.node_classes deprecated then and removed in 3.0, this can affect Bullseye users as it shipped with astroid 2.5
  • Astroid 4 changes spec.Finder.find_module in order to cache it (Make Finder.find_module static to facilitate future caching pylint-dev/astroid#2509), we can just make our method static for all versions as we don't need self anyway.
  • The mail test triggers function-redefined (E0102), fix it.
  • Skip the escpos script thing which triggers a bunch of undefined-variable (E0602) false positives.

Forward-Port-Of: #236258

@robodoo
Copy link
Contributor

robodoo commented Nov 19, 2025

Pull request status dashboard

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Nov 19, 2025
@fw-bot
Copy link
Contributor Author

fw-bot commented Nov 19, 2025

@xmo-odoo cherrypicking of pull request #236258 failed.

stdout:

Auto-merging addons/hw_escpos/controllers/main.py
Auto-merging addons/test_mail/tests/test_mail_mail.py
Auto-merging odoo/addons/test_lint/tests/_odoo_checker_sql_injection.py
CONFLICT (content): Merge conflict in odoo/addons/test_lint/tests/_odoo_checker_sql_injection.py
Auto-merging odoo/addons/test_lint/tests/test_checkers.py

stderr:

WARN Using Git v2.44.0 or above is recommended to get meaningful revision names on conflict markers when using Mergiraf.

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@xmo-odoo xmo-odoo force-pushed the 18.0-17.0-astroid-4-compat-xmo-478011-fw branch 2 times, most recently from 9b9ee5b to 634bb88 Compare November 19, 2025 08:35
@C3POdoo C3POdoo requested review from a team November 19, 2025 08:38
@xmo-odoo
[FIX] *: support for pylint 4
955f94b 
- astroid 4 deprecates toplevel exports of nodes, thankfully that was
  never actually necessary so we can just import that unconditionally
- remove support for pre-jammy pylint / astroid, specifically
  `astroid.nodes` was added in astroid 2.7.0 and
  `astroid.node_classes` deprecated then and removed in 3.0, this can
  affect Bullseye users as it shipped with astroid 2.5
- Astroid 4 changes `spec.Finder.find_module` in order to cache it
  (pylint-dev/astroid#2509), we can just make our method static for
  all versions as we don't need `self` anyway.
- The mail test triggers `function-redefined` (E0102), fix it.
- Skip the escpos script thing which triggers a bunch of
  `undefined-variable` (E0602) false positives.

X-original-commit: f06c90a
@xmo-odoo xmo-odoo force-pushed the 18.0-17.0-astroid-4-compat-xmo-478011-fw branch from 634bb88 to 955f94b Compare November 19, 2025 08:51
@xmo-odoo
Copy link
Collaborator

xmo-odoo commented Nov 19, 2025

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 19, 2025
@xmo-odoo
[FIX] *: support for pylint 4
794216c 
- astroid 4 deprecates toplevel exports of nodes, thankfully that was
  never actually necessary so we can just import that unconditionally
- remove support for pre-jammy pylint / astroid, specifically
  `astroid.nodes` was added in astroid 2.7.0 and
  `astroid.node_classes` deprecated then and removed in 3.0, this can
  affect Bullseye users as it shipped with astroid 2.5
- Astroid 4 changes `spec.Finder.find_module` in order to cache it
  (pylint-dev/astroid#2509), we can just make our method static for
  all versions as we don't need `self` anyway.
- The mail test triggers `function-redefined` (E0102), fix it.
- Skip the escpos script thing which triggers a bunch of
  `undefined-variable` (E0602) false positives.

closes #236447

X-original-commit: f06c90a
Related: odoo/enterprise#99867
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
@robodoo robodoo closed this Nov 19, 2025
@fw-bot fw-bot mentioned this pull request Nov 19, 2025
Closed
@fw-bot fw-bot deleted the 18.0-17.0-astroid-4-compat-xmo-478011-fw branch November 26, 2025 14:31
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Dec 7, 2025
@xmo-odoo @gamarino
[FIX] *: support for pylint 4
1d5bd37 
- astroid 4 deprecates toplevel exports of nodes, thankfully that was
  never actually necessary so we can just import that unconditionally
- remove support for pre-jammy pylint / astroid, specifically
  `astroid.nodes` was added in astroid 2.7.0 and
  `astroid.node_classes` deprecated then and removed in 3.0, this can
  affect Bullseye users as it shipped with astroid 2.5
- Astroid 4 changes `spec.Finder.find_module` in order to cache it
  (pylint-dev/astroid#2509), we can just make our method static for
  all versions as we don't need `self` anyway.
- The mail test triggers `function-redefined` (E0102), fix it.
- Skip the escpos script thing which triggers a bunch of
  `undefined-variable` (E0602) false positives.

closes odoo/odoo#236447

X-original-commit: f06c90a5fec803c1e8a85b3cdd71e560e7855d0a
Related: odoo/enterprise#99867
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
sbejaoui pushed a commit to acsone/odoo that referenced this pull request Feb 16, 2026
@xmo-odoo @sbejaoui
[FIX] *: support for pylint 4
8db3046 
- astroid 4 deprecates toplevel exports of nodes, thankfully that was
  never actually necessary so we can just import that unconditionally
- remove support for pre-jammy pylint / astroid, specifically
  `astroid.nodes` was added in astroid 2.7.0 and
  `astroid.node_classes` deprecated then and removed in 3.0, this can
  affect Bullseye users as it shipped with astroid 2.5
- Astroid 4 changes `spec.Finder.find_module` in order to cache it
  (pylint-dev/astroid#2509), we can just make our method static for
  all versions as we don't need `self` anyway.
- The mail test triggers `function-redefined` (E0102), fix it.
- Skip the escpos script thing which triggers a bunch of
  `undefined-variable` (E0602) false positives.

closes odoo#236447

X-original-commit: f06c90a
Related: odoo/enterprise#99867
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
carlosdauden pushed a commit to Tecnativa/odoo that referenced this pull request Mar 10, 2026
@xmo-odoo @carlosdauden
[FIX] *: support for pylint 4
5724786 
- astroid 4 deprecates toplevel exports of nodes, thankfully that was
  never actually necessary so we can just import that unconditionally
- remove support for pre-jammy pylint / astroid, specifically
  `astroid.nodes` was added in astroid 2.7.0 and
  `astroid.node_classes` deprecated then and removed in 3.0, this can
  affect Bullseye users as it shipped with astroid 2.5
- Astroid 4 changes `spec.Finder.find_module` in order to cache it
  (pylint-dev/astroid#2509), we can just make our method static for
  all versions as we don't need `self` anyway.
- The mail test triggers `function-redefined` (E0102), fix it.
- Skip the escpos script thing which triggers a bunch of
  `undefined-variable` (E0602) false positives.

closes odoo#236447

X-original-commit: f06c90a
Related: odoo/enterprise#99867
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fw-bot @robodoo @xmo-odoo