[FW][16.0][Backport] [FIX] safe_eval: 3.11 compatibility#156700
Closed
fw-bot wants to merge 1 commit intoodoo:saas-16.1from
Closed
[FW][16.0][Backport] [FIX] safe_eval: 3.11 compatibility#156700fw-bot wants to merge 1 commit intoodoo:saas-16.1from
fw-bot wants to merge 1 commit intoodoo:saas-16.1from
Conversation
Complement on 1e35315 (odoo#112450): alongside the split between forwards and backwards jump we missed that 3.11 has a specialized version of each for the `is None` and `is not None` cases. A use of that was added in standard in 16.5 (odoo#120446) but more generally it makes sense that server actions would support conditional tests against `None`, probably... X-original-commit: 22ad0a3
Contributor
|
|
Contributor
Author
|
This PR targets saas-16.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
Author
|
@hugosantosred @xmo-odoo the next pull request (#156713) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Collaborator
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 6, 2024
Complement on 1e35315 (#112450): alongside the split between forwards and backwards jump we missed that 3.11 has a specialized version of each for the `is None` and `is not None` cases. A use of that was added in standard in 16.5 (#120446) but more generally it makes sense that server actions would support conditional tests against `None`, probably... closes #156700 X-original-commit: 22ad0a3 Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #136943 to 16.0 branch
Description of the issue/feature this PR addresses: This fixes the issue #149524
Current behavior before PR: When creating a server action with 16.0 branch throws the error:
forbidden opcode(s) in 'lambda': POP_JUMP_FORWARD_IF_NOT_NONE, POP_JUMP_FORWARD_IF_NONEDesired behavior after PR is merged: Server actions created without problemas
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #156438