[FW][FIX] mrp_subcontracting: changing UoM causes unreserve issues#154450
Closed
fw-bot wants to merge 1 commit intoodoo:saas-15.2from
Closed
Conversation
Contributor
|
|
Contributor
Author
|
@pno-odoo @Whenrow cherrypicking of pull request #154327 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
90a1808 to
bc96028
Compare
Before this commit: It was possible to purchase a subcontracted product and on the receipt of the product, change the unit of measure o on the stock move lines of the components when the quantities were already reserved. This caused unreserve issue given that, all of a sudden, instead of having 200g, we would have 200kg reserved and the change would not be reflected on the quant. After this commit: The view was modified to not allow changes of UoM if there are reserved quantities, or if the state is done. OPW-3742720 X-original-commit: 35da769
bc96028 to
5cb12ca
Compare
Contributor
|
fw-bot r+ |
Contributor
Author
|
@pno-odoo I can only do this on unmodified forward-port PRs, ask robodoo. |
Contributor
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 4, 2024
Before this commit: It was possible to purchase a subcontracted product and on the receipt of the product, change the unit of measure o on the stock move lines of the components when the quantities were already reserved. This caused unreserve issue given that, all of a sudden, instead of having 200g, we would have 200kg reserved and the change would not be reflected on the quant. After this commit: The view was modified to not allow changes of UoM if there are reserved quantities, or if the state is done. OPW-3742720 closes #154450 X-original-commit: 35da769 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
This was referenced Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit:
"Cannot unreserve more than you have in stock" Error
It was possible to purchase a subcontracted product, and on the receipt of the product, change the unit of measure o on the stock move lines of the components when the quantities were already reserved. This caused unreserve issue given that, all of a sudden, instead of having 200g, we would have 200kg reserved and the change would not be reflected on the quant.
After this commit:
The view was modified to not allow changes of UoM if there are reserved quantities, or if the state is done.
OPW-3742720
Forward-Port-Of: #154327