Skip to content

[FIX] base: 3.11 compatibility#141015

Closed
d-fence wants to merge 1 commit intoodoo:17.0from
odoo-dev:17.0-fix-jump-opcodes-moc
Closed

[FIX] base: 3.11 compatibility#141015
d-fence wants to merge 1 commit intoodoo:17.0from
odoo-dev:17.0-fix-jump-opcodes-moc

Conversation

@d-fence
Copy link
Copy Markdown
Contributor

@d-fence d-fence commented Nov 3, 2023

Complement of the previous complement e2752a0 (#137099)

Those opcodes were added in Python 3.11 and we missed them.

Fixes #140588

@d-fence d-fence requested a review from xmo-odoo November 3, 2023 16:03
@robodoo
Copy link
Copy Markdown
Contributor

robodoo commented Nov 3, 2023 •
edited
Loading

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team and HydrionBurst and removed request for a team November 3, 2023 16:09
@rdeodoo rdeodoo removed the request for review from a team November 3, 2023 16:35
@C3POdoo C3POdoo added the RD research & development, internal work label Nov 3, 2023
@xmo-odoo
Copy link
Copy Markdown
Collaborator

xmo-odoo commented Nov 6, 2023

Shouldn't this be merged in 16.2 like #136943 was?

Also might be worth shuffling the opcodes a touch to move POP_JUMP_FORWARD_IF_TRUE and POP_JUMP_FORWARD_IF_FALSE near POP_JUMP_BACKWARD_IF_FALSE.

@d-fence d-fence force-pushed the 17.0-fix-jump-opcodes-moc branch from 5dc290f to 1bfc00d Compare November 6, 2023 15:26
@d-fence
[FIX] base: 3.11 compatibility
6baf670 
Complement of the previous complement e2752a0 (odoo#137099)

Those opcodes were added in Python 3.11 and we missed them.

Fixes odoo#140588
@d-fence d-fence force-pushed the 17.0-fix-jump-opcodes-moc branch from 1bfc00d to 6baf670 Compare November 6, 2023 15:31
@d-fence
Copy link
Copy Markdown
Contributor Author

d-fence commented Nov 6, 2023

I reordered a bit POP_JUMP_(BACKWARD|FORWARD)_IF_.* as asked.
I will backport later in 15.0 as there is an urgent need for this one in 17.0.

@d-fence
Copy link
Copy Markdown
Contributor Author

d-fence commented Nov 7, 2023

robodoo r+

robodoo pushed a commit that referenced this pull request Nov 7, 2023
@d-fence
[FIX] base: 3.11 compatibility
252bece 
Complement of the previous complement e2752a0 (#137099)

Those opcodes were added in Python 3.11 and we missed them.

Fixes #140588

closes #141015

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
@fw-bot fw-bot mentioned this pull request Nov 7, 2023
Closed
@robodoo robodoo closed this Nov 7, 2023
@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Nov 11, 2023

@d-fence this pull request has forward-port PRs awaiting action (not merged or closed):

2 similar comments
@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Nov 12, 2023

@d-fence this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Nov 13, 2023

@d-fence this pull request has forward-port PRs awaiting action (not merged or closed):

@vava-odoo vava-odoo mentioned this pull request Nov 13, 2023
Closed
@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Nov 14, 2023

@d-fence this pull request has forward-port PRs awaiting action (not merged or closed):

1 similar comment
@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Nov 15, 2023

@d-fence this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Nov 16, 2023

@d-fence this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Copy Markdown
Contributor

fw-bot commented Nov 17, 2023

@d-fence this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot fw-bot deleted the 17.0-fix-jump-opcodes-moc branch November 21, 2023 16:47
borna-ng added a commit to jobrad-gmbh/odoo that referenced this pull request Jul 30, 2025
@borna-ng
CPT-620 Add missing Python 3.11 opcodes for QWeb
2a29f65 
As fixed in odoo#141015
borna-ng added a commit to jobrad-gmbh/odoo that referenced this pull request Jul 30, 2025
@borna-ng
CPT-620 Upgrade to Python 3.11 (#60)
0a8096a 
* CPT-620 Upgrade to Python 3.11

* CPT-620 Update Poetry files

* CPT-620 Upgrade to psycopg2 2.9.10

* CPT-620 Add missing Python 3.11 opcodes for QWeb

As fixed in odoo#141015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xmo-odoo xmo-odoo Awaiting requested review from xmo-odoo

@HydrionBurst HydrionBurst Awaiting requested review from HydrionBurst HydrionBurst was automatically assigned from odoo/rd-framework-py

Assignees

No one assigned

Labels

RD research & development, internal work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[17.0] ValueError: forbidden opcode(s) in 'True if show_footer is None else not show_footer': POP_JUMP_FORWARD_IF_NOT_NONE

5 participants

@d-fence @robodoo @xmo-odoo @fw-bot @C3POdoo