Skip to content

Only build multicore packages on multicore compilers#468

Merged
talex5 merged 2 commits intoocurrent:masterfrom
talex5:filter-effects
Jun 9, 2022
Merged

Only build multicore packages on multicore compilers#468
talex5 merged 2 commits intoocurrent:masterfrom
talex5:filter-effects

Conversation

@talex5
Copy link
Copy Markdown
Contributor

@talex5 talex5 commented May 25, 2022

If a package depends on base-domains or base-effects then it requires a multicore compiler. Don't try to test it on other platforms.

Many projects want to add a sub-package with support for effects on OCaml 5.0, alongside their existing support for Lwt. This PR allows them to do that without losing CI on all older compilers. e.g.

@talex5
Copy link
Copy Markdown
Contributor Author

talex5 commented May 25, 2022

Seems to work, but logs:

2022-05-25 14:46.05 [INFO] is_multicore "4.14.0+options" failed: Failure("unknown variant: options")

ocaml-version does with_variant t (Some "options"), but of_string then fails to parse this.

@talex5
Copy link
Copy Markdown
Contributor Author

talex5 commented May 25, 2022

Also, lint-doc needs to handle this.

@dra27
Copy link
Copy Markdown
Contributor

dra27 commented May 25, 2022

Flying by, somewhat, but two questions (!!): looks like a bug in Ocaml_version.Configure_options.is_multicore - surely that should be mapping any exception raised in parsing to false? More seriously, though, aren't we heading towards a state where this can/should be predicated on "ocaml" {> 5.0.0~~}?

@talex5
Copy link
Copy Markdown
Contributor Author

talex5 commented May 26, 2022

aren't we heading towards a state where this can/should be predicated on "ocaml" {> 5.0.0~~}?

Yes. This is only needed until we have a 5.0 compiler available in CI. Not sure when that will happen.

If we don't merge this, we should still merge the lint-doc fix.

@dra27
Copy link
Copy Markdown
Contributor

dra27 commented May 26, 2022

There should be an alpha0 within the next couple of weeks - the idea is that this fixes magic numbers, installation layout, and so forth. There are a few other things converging at which point alpha1 is released and we have a "normal" compiler release cycle... but CI (and tooling, etc.) should start converging on released versions as soon as alpha0 is cut.

talex5 added 2 commits June 9, 2022 08:44
If a package depends on base-domains or base-effects then it requires a
multicore compiler. Don't try to test it on other platforms.

Many projects want to add a sub-package with support for effects on
OCaml 5.0, alongside their existing support for Lwt. This PR allows them
to do that without losing CI on all older compilers.
@talex5 talex5 merged commit 3b3645c into ocurrent:master Jun 9, 2022
@talex5 talex5 deleted the filter-effects branch June 9, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants