RFC: eio-only version of cohttp by bikallem · Pull Request #857 · mirage/ocaml-cohttp

bikallem · 2022-02-01T13:13:42Z

This is a WIP PR which implements an eio-only version of cohttp. Therefore the API is necessarily different as compared to other cohttp packages (lwt, async).

The HTPP protocol implemented is 1.1
It is developed against 4.12+domains switch.
It supports running the server in a multiple domains(cores) setting. It utilizes socket sharding (https://www.nginx.com/blog/socket-sharding-nginx-release-1-9-1/) so it is automatically load balanced among the cores/domains in linux. Load balancing needs to be investigated for other OSes.
Only the server API done for now. A sample server - server1.ml - in included in the PR. It can also be viewed here - https://github.com/bikallem/ocaml-cohttp/blob/eio-3/cohttp-eio/examples/server1.ml.
The server API aims to be composable. To precisely define composable, here composable means Server.middleware and Server.handler values can be defined by other external users and exist in various opam packages. And that such packages can be reused and composed together to form a web application. The demo - server1.ml - demonstrates one such use case of composing together Server.handler values. Next, Server.middleware is designed to cater to scenarios where external users can define web application functionality such as cookie based sessions, sql db based sessions, authentication and the like and a web application developer can per-use such packages. I intend to update the examples with such a demo middleware. The design of Server.handler and Server.middleware is mostly inspired by F# web library - https://github.com/giraffe-fsharp/Giraffe. However, it can also be found in another ocaml web library (https://github.com/aantron/dream).

I am opening the PR to get early feedback and to gauge maintainer appetite for this work.

Latest benchmarking results:
1 Core performance:

Multicore performance: (24 cores)

mseri · 2022-02-01T16:17:28Z

While the lwt implementation is in a delicate situation, requiring a big break with the past and the ecosystem, this one could be easily added as cohttp subpackage already now imho.

We could add an extra lower bound on 5.0.0 just for this package (leaving jsoo enabled: we know it does not yet support 5.0.0, but they can coexist, we just need to figure out the CI).

It could be interesting then to evolve this and the conduit-free implementation of lwt-server together so that they api remains consistent.

Fwiw, I think we can even leave the client out for the time being. And focus on the server to start with.

avsm · 2022-02-01T17:18:15Z

I'm in favour of @mseri's proposal. I think we can get an eio client in there too though -- it's a fairly small amount of code vs the server.

cohttp-eio/src/cohttp_eio.mli

cohttp-eio/src/parser.ml

cohttp-eio/src/cohttp_eio.mli

mseri · 2022-02-02T15:59:49Z

It looks like there is a lot of re-implementation. I think, if we call it cohttp-*, it should re-use signature from the http module (I would suggest also the parser). And, if anything needs being extended or improved, we do it at those libraries level. Ideally cohttp-eio would depend on eio and cohttp and get the relevant signatures from there, so that as much as possible of the types and the interfaces are shared.

rgrinberg · 2022-02-02T19:32:26Z

The server API aims to be composable. To precisely define composable, here composable means Server.middleware and Server.handler values can be defined by other external users and exist in various opam packages. ...

I don't think we should be introducing web framework components into cohttp. Especially since this was already implemented outside of cohttp without loss of functionality.

rgrinberg · 2022-02-02T19:33:08Z

Why did you decide to use cstructs? Anil mentioned that strings are the way to go with multicore.

rgrinberg · 2022-02-02T19:34:45Z

.envrc

@@ -0,0 +1,2 @@
+use nix shell-eio.nix 
+eval $(opam env --shell=bash --inplace-path --set-switch)


this shouldn't be committed. not everyone is using direnv.

@bikallem this file still needs to be removed

rgrinberg · 2022-02-02T19:36:14Z

cohttp-eio/src/server.ml

+    in
+    let headers =
+      let date = Unix.time () |> Unix.gmtime in
+      Http.Header.add_unless_exists headers "Date" (datetime_to_string date)


Do we really need this? I don't remember Date being mandatory.

According to this spec (https://www.rfc-editor.org/rfc/rfc7231#section-7.1.1.2), Date seems to be mandatory if the server is capable. To quote An origin server MUST send a Date header field in all other cases.

golang http lib also seems to add this header - https://github.com/golang/go/blob/master/src/net/http/server.go#L1416-L1417

That's a good point, but I'd still go against it. For a few reasons:

We don't do it in the lwt/async. It's inconsistent with respect to our own libs.

The implementation we have here is naive. Getting the current time is takes a syscall and should be cached for high performance servers.

It's just as easy to implement outside of the basic library. It could just as easily be done through middleware. Or even a simple response generation function which would work for all backends.

Agreed. We can drop Date for now and put it in the cohttp-consuming libraries

Removed now.

rgrinberg · 2022-02-02T19:41:22Z

cohttp-eio/src/server.ml

+      (*--- Don't cache set-cookie headers in browsers and proxies. ---*)
+      if Http.Header.mem headers "set-cookie" then
+        Http.Header.add headers "Cache-Control" {|no-cache="Set-Cookie"|}
+      else headers


We can just let downstream frameworks take care of this for us.

Removed now.

rgrinberg · 2022-02-02T19:41:53Z

dune-project

+;   (conf-npm :with-test)
+;   (js_of_ocaml (>= 3.3.0))
+;   (js_of_ocaml-ppx (>= 3.3.0))
+;   (js_of_ocaml-lwt (>= 3.5.0))))


Why is this commented out?

jsoo doesn't build on 4.12+domains switch.

rgrinberg · 2022-02-02T19:42:03Z

dune

@@ -0,0 +1 @@
+(data_only_dirs cohttp-lwt-jsoo cohttp_lwt_jsoo_test)


We don't need this dune file.

It is temporarily here so that dune won't build jsoo packages.

I see. Note that you could always build just the package you want with dune build cohttp-eio.install.

rgrinberg · 2022-02-02T19:42:56Z

dune-project

+  eio_main
+  cstruct
+  logs
+  (fmt (>= 0.8.7))


I could be wrong, but I don't see fmt or logs being used anywhere.

tmattio · 2022-02-02T20:59:27Z

Disclaimer: not a maintainer of Cohttp or Eio, so I'm probably missing a bit of context.

What's the reason for adding this as a new cohttp-eio package?
With effects allowing us to write APIs without monads, the use of Eio becomes an implementation detail that doesn't leak to the package interface (apart from the Reader.create function apparently, but I'm guessing that's something that could be changed). So I was expecting this would allow package maintainers to stop having to maintain multiple packages for each IO backend.

Is there something preventing us from implementing the functionality in cohttp and have the lwt and async backends "wrap" the cohttp package to keep the API compatibility?

rgrinberg · 2022-02-02T21:40:15Z

Even if we could completely drop support for 4.x, the Lwt and Async packages have their own event loops while Eio has its own. I doubt people want to use a cohttp-{lwt,async} package that brings its own event loop.

bikallem · 2022-02-02T22:04:29Z

Disclaimer: not a maintainer of Cohttp or Eio, so I'm probably missing a bit of context.

What's the reason for adding this as a new cohttp-eio package? With effects allowing us to write APIs without monads, the use of Eio becomes an implementation detail that doesn't leak to the package interface (apart from the Reader.create function apparently, but I'm guessing that's something that could be changed). So I was expecting this would allow package maintainers to stop having to maintain multiple packages for each IO backend.

Is there something preventing us from implementing the functionality in cohttp and have the lwt and async backends "wrap" the cohttp package to keep the API compatibility?

eio sits atop effects, uring and luv and has its own IO loop which works a bit differently from lwt/async. If you want direct style code in a lwt codebase, there is lwt_eio package which does that. Here is another PR which attempts to do just that (#854). Perhaps going forward if eio gains traction and becomes the "default"/blessed io package, then library authors will probably stop maintaining lwt/async packages.

bikallem · 2022-02-02T22:11:19Z

The server API aims to be composable. To precisely define composable, here composable means Server.middleware and Server.handler values can be defined by other external users and exist in various opam packages. ...

I don't think we should be introducing web framework components into cohttp. Especially since this was already implemented outside of cohttp without loss of functionality.

Agreed. It won't. cotthp-eio will provide types and maybe some glue functions to help downstream web frameworks/components provide "web framework/component" like functionalities.

tmattio · 2022-02-02T22:17:35Z

Even if we could completely drop support for 4.x, the Lwt and Async packages have their own event loops while Eio has its own. I doubt people want to use a cohttp-{lwt,async} package that brings its own event loop.

Couldn't eio offer an API to provide your own event loop? So people could use the same package but call Eio_lwt.init_event_loop () or similar to tell Eio to use Lwt (or Async's) event loop.

bikallem · 2022-02-02T22:42:50Z

Why did you decide to use cstructs? Anil mentioned that strings are the way to go with multicore.

Cstruct.t is the default/chosen data structure in eio, so we use Cstruct.t also to save the hassle of of data structure conversion/allocation/gc cost. With regards to cstruct/bigstring, AIUI Cstruct.t/bigstring allows zero copy/no allocation when data is moved from C memory space to OCaml managed memory space. Furthermore, on linux, uring removes the need to do allocation/copying when moving data from OS kernel space to user space. io_uring which eio uses has been designed to explicitly exploit these functionalities. cohttp-eio aims to also exploit these to the fullest possible. Perhaps @talex5 can elucidate/correct the above if my understanding is incorrect.

rgrinberg · 2022-02-03T01:44:15Z

cohttp-eio/src/server.ml

+      }
+  done
+
+let create ?(socket_backlog = 10_000) ?(domains = cpu_core_count) ~port


What do you think about making the default for domains to be 1? To me seems like the safest option since the user's code might not necessarily be thread safe.

Yes, it's very rare for a server to need to process requests so fast it needs more than one core for the job.

rgrinberg · 2022-02-03T01:49:14Z

Why did you decide to use cstructs? Anil mentioned that strings are the way to go with multicore.

Cstruct.t is the default/chosen data structure in eio, so we use Cstruct.t also to save the hassle of of data structure conversion/allocation/gc cost. With regards to cstruct/bigstring, AIUI Cstruct.t/bigstring allows zero copy/no allocation when data is moved from C memory space to OCaml managed memory space. Furthermore, on linux, uring removes the need to do allocation/copying when moving data from OS kernel space to user space. io_uring which eio uses has been designed to explicitly exploit these functionalities. cohttp-eio aims to also exploit these to the fullest possible. Perhaps @talex5 can elucidate/correct the above if my understanding is incorrect.

Thanks for response. This still needs some clarification. AFAIK, normal strings aren't going to be moved by the GC in 5.0 so they should be usable for io_uring and not require extra copies anyway.

rgrinberg · 2022-02-03T01:58:30Z

Agreed. It won't. cotthp-eio will provide types and maybe some glue functions to help downstream web frameworks/components provide "web framework/component" like functionalities.

In which case, we should drop the middleware alias. You have a noble goal in mind, but I doubt it will have the outcome we all desire. Who is to say that the various OCaml web frameworks popular today are going to use this type? I don't yet see any interest from them their maintainers, therefore I doubt that this is going to be adopted. To get some unification here, we need to get the various maintainers on board first and only then start introducing stuff to smooth out compatibility. Otherwise, we're just going to introduce the nth+1 framework.

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

mseri · 2022-06-08T19:12:24Z

cohttp-eio/src/reader.ml

+      let headers = http_headers t in
+      let encoding = Http.Header.get_transfer_encoding headers in
+      commit t;
+      { Http.Request.meth; resource; version; headers; scheme = None; encoding }


Since we were talking about scheme, why here we set it to None? We don't have a way to populate it?
Is the warning due to the use of encoding?

Since we were talking about scheme, why here we set it to None? We don't have a way to populate it?

I am not sure if there is a reliable way to determine a value for the scheme. For example, a web app using cohttp-eio could be behind a proxy server where the ssl/tls terminate or it could be a normal socket connection without ssl/tls.

Is the warning due to the use of encoding?

Yes, dune gives a build error during dev without the attribute.

mseri · 2022-06-08T19:13:21Z

I have cleaned the commits from the spurious changes inherited with the merges. Just had a final question, for the rest I am waiting for the CI to make sure I did not screw up anything

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

mseri · 2022-06-08T21:13:14Z

The tests on nix are failing with

File "cohttp-eio/src/dune", line 4, characters 12-15:
4 |  (libraries eio cstruct http bigstringaf fmt))
                ^^^
Error: Library "eio" not found.
Hint: try:
  dune external-lib-deps --missing -j 1 @runtest
File "cohttp-eio/tests/dune", line 6, characters 23-31:
6 |  (libraries cohttp_eio eio_main fmt))
                           ^^^^^^^^
Error: Library "eio_main" not found.
Hint: try:
  dune external-lib-deps --missing -j 1 @runtest
File "cohttp-eio/tests/dune", line 13, characters 23-31:
13 |  (libraries cohttp_eio eio_main fmt))
                            ^^^^^^^^
Error: Library "eio_main" not found.
Hint: try:
  dune external-lib-deps --missing -j 1 @runtest
File "cohttp-eio/tests/dune", line 22, characters 0-50:
22 | (mdx
23 |  (package cohttp-eio)
24 |  (packages cohttp-eio))
Error: Program ocaml-mdx not found in the tree or in PATH
 (context: default)
Hint: opam install mdx
File "cohttp-eio/tests/dune", line 27, characters 9-25:
27 |  (deps %{bin:test-server} %{bin:test-chunk-server} %{bin:crlf}))
              ^^^^^^^^^^^^^^^^
Error: Program test-server not found in the tree or in PATH
 (context: default)

bikallem · 2022-06-09T08:22:53Z

I am not familiar with nix but I think nix needs to not run the cohttp-eio package and tests for now. If nix is to run on cohttp-eio then it needs to run a version of OCaml with effects and domains, 4.12.0+domains or 5.0.0+trunk. @rgrinberg

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

They are broken on the CI environments for various infrastructural reasons Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

bikallem

shell-eio.nix only installs/provides system dependencies when working in nixos. It will not setup the required OCaml version (4.12.+domains or 5.0.0). For that I believe it needs a nix package to be submitted to nixpkgs repo in github. I am not familiar enough with nixpkgs to be able to package trunk OCaml. Best leave the eio part out of nix.yml for now.

internal/modules/cjs/loader.js:905 throw err; ^ Error: Cannot find module 'xmlhttprequest' Fixing this requires knowing npm, yarn and node, so I will disable them for the moment Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

We need a nix user to know how to install ocaml 5.0.0+trunk on nix Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

mseri · 2022-06-09T10:12:04Z

The last two commits should fix the CI, if also nix is green I will merge

mseri · 2022-06-09T12:15:50Z

It is all green now. Time to take a stance a merge. The next cohttp release will be a alpha o beta release anyway, so extra changes will have time to be made

mseri · 2022-06-09T12:16:04Z

Thanks a lot for the patience and the effort

…p-mirage, cohttp-lwt, cohttp-lwt-unix, cohttp-lwt-jsoo, cohttp-eio, cohttp-curl, cohttp-curl-lwt, cohttp-curl-async, cohttp-bench and cohttp-async (6.0.0~alpha0) CHANGES: - cohttp-eio: ensure "Host" header is the first header in http client requests (bikallem mirage/ocaml-cohttp#939) - cohttp-eio: add TE header in client. Check TE header is server (bikallem mirage/ocaml-cohttp#941) - cohttp-eio: add User-Agent header to request from Client (bikallem mirage/ocaml-cohttp#940) - cohttp-eio: add Content-Length header to request/response (bikallem mirage/ocaml-cohttp#929) - cohttp-eio: add cohttp-eio client api - Cohttp_eio.Client (bikallem mirage/ocaml-cohttp#879) - http: add requires_content_length function for requests and responses (bikallem mirage/ocaml-cohttp#879) - cohttp-eio: use Eio.Buf_write and improve server API (talex5 mirage/ocaml-cohttp#887) - cohttp-eio: update to Eio 0.3 (talex5 mirage/ocaml-cohttp#886) - cohttp-eio: convert to Eio.Buf_read (talex5 mirage/ocaml-cohttp#882) - cohttp lwt client: Connection cache and explicit pipelining (madroach mirage/ocaml-cohttp#853) - http: add Http.Request.make and simplify Http.Response.make (bikallem mseri mirage/ocaml-cohttp#878) - http: add pretty printer functions (bikallem mirage/ocaml-cohttp#880) - New eio based client and server on top of the http library (bikallem mirage/ocaml-cohttp#857) - New curl based clients (rgrinberg mirage/ocaml-cohttp#813) + cohttp-curl-lwt for an Lwt backend + cohttp-curl-async for an Async backend - Completely new Parsing layers for servers (anuragsoni mirage/ocaml-cohttp#819) + Cohttp now uses an optimized parser for requests. + The new parser produces much less temporary buffers during read operations in servers. - Faster header comparison (gasche mirage/ocaml-cohttp#818) - Introduce http package containing common signatures and structures useful for compatibility with cohttp - and no dependencies (rgrinberg mirage/ocaml-cohttp#812) - async(server): allow reading number of active connections (anuragsoni mirage/ocaml-cohttp#809) - Various internal refactors (rgrinberg, mseri, mirage/ocaml-cohttp#802, mirage/ocaml-cohttp#812, mirage/ocaml-cohttp#820, mirage/ocaml-cohttp#800, mirage/ocaml-cohttp#799, mirage/ocaml-cohttp#797) - http (all cohttp server backends): Consider the connection header in response in addition to the request when deciding on whether to keep a connection alive (anuragsoni, mirage/ocaml-cohttp#843) + The user provided Response can contain a connection header. That header will also be considered in addition to the connection header in requests when deciding whether to use keep-alive. This allows a handler to decide to close a connection even if the client requested a keep-alive in the request. - async(server): allow creating a server without using conduit (anuragsoni mirage/ocaml-cohttp#839) + Add `Cohttp_async.Server.Expert.create` and `Cohttp_async.Server.Expert.create_with_response_action`that can be used to create a server without going through Conduit. This allows creating an async TCP server using the Tcp module from `Async_unix` and lets the user have more control over how the `Reader.t` and `Writer.t` are created. - http(header): faster `to_lines` and `to_frames` implementation (mseri mirage/ocaml-cohttp#847) - cohttp(cookies): use case-insensitive comparison to check for `set-cookies` (mseri mirage/ocaml-cohttp#858) - New lwt based server implementation: cohttp-server-lwt-unix + This new implementation does not depend on conduit and has a simpler and more flexible API - async: Adapt cohttp-curl-async to work with core_unix. - *Breaking changes* + refactor: move opam metadata to dune-project (rgrinberg mirage/ocaml-cohttp#811) + refactor: deprecate Cohttp_async.Io (rgrinberg mirage/ocaml-cohttp#807) + fix: move more internals to Private (rgrinberg mirage/ocaml-cohttp#806) + fix: deprecate transfer encoding field (rgrinberg mirage/ocaml-cohttp#805) + refactor: deprecate Cohttp_async.Body_raw (rgrinberg mirage/ocaml-cohttp#804) + fix: deprecate more aliases (rgrinberg mirage/ocaml-cohttp#803) + refactor: deprecate connection value(rgrinberg mirage/ocaml-cohttp#798) + refactor: deprecate using attributes (rgrinberg mirage/ocaml-cohttp#796) + cleanup: remove cohttp-{curl,server}-async (rgrinberg mirage/ocaml-cohttp#904) + cleanup: remove cohttp-{curl,server,proxy}-lwt (rgrinberg mirage/ocaml-cohttp#904) + fix: all parsers now follow the spec and require `\r\n` endings. Previously, the `\r` was optional. (rgrinberg, mirage/ocaml-cohttp#921) - `cohttp-lwt-jsoo`: do not instantiate `XMLHttpRequest` object on boot (mefyl mirage/ocaml-cohttp#922)

@art-w

CHANGES: - cohttp-lwt-unix: Add http/https proxy support for client requests (@art-w @MisterDA, mirage/ocaml-cohttp#1080) - cohttp-mirage: Support conduit 8.0.0 (@hannesm, mirage/ocaml-cohttp#1104) ## v6.0.0 (2024-11-21) - bump minimum dune version to 3.8 (@avsm) - cohttp-eio: Use system authenticator in example. - http, cohttp: remove the scheme field from requests. This means that [Request.uri] no longer returns the same URI as was to create the request with [Request.make] (@rgrinberg 1086) - cohttp-eio: Remove unused `Client_intf` module (talex5 mirage/ocaml-cohttp#1081) - cohttp-eio: Make server response type abstract and allow streaming in cohttp-eio (talex5 mirage/ocaml-cohttp#1024) - cohttp-{lwt,eio}: server: add connection header to response if not present (ushitora-anqou mirage/ocaml-cohttp#1025) - cohttp-curl: Curl no longer prepends the first HTTP request header to the output. (jonahbeckford mirage/ocaml-cohttp#1030, mirage/ocaml-cohttp#987) - cohttp-eio: client: use permissive argument type for make_generic - cohttp-eio: Improve error handling in example server (talex5 mirage/ocaml-cohttp#1023) - cohttp-eio: Don't blow up `Server.callback` on client disconnections. (mefyl mirage/ocaml-cohttp#1015) - http: Fix assertion in `Source.to_string_trim` when `pos <> 0` (mefyl mirage/ocaml-cohttp#1017) - cohttp: `Cohttp.Request.make_for_client` no longer allows setting both `~chunked:true` and `~body_length`. - cohttp-lwt-unix: Don't blow up when certificates are not available and no-network requests are made. (akuhlens mirage/ocaml-cohttp#1027) + Makes `cohttp-lwt.S.default_ctx` lazy. ## v6.0.0~beta2 (2024-01-05) - cohttp-eio: Don't blow up `Server.run` on client disconnections. (mefyl mirage/ocaml-cohttp#1011) - cohttp-eio: Match body encoding with headers. (mefyl mirage/ocaml-cohttp#1012) - cohttp-lwt: Preserve extended `Server.S.IO` signature. (mefyl mirage/ocaml-cohttp#1013) ## v6.0.0~beta1 (2023-10-27) - cohttp-eio: move new Cohttp.{Client,Server} modules under Cohttp.Generic (mseri mirage/ocaml-cohttp#1003) - cohttp-eio: Add Client.make_generic and HTTPS support. (talex5 mirage/ocaml-cohttp#1002) - cohttp: move generic client and server signatures to cohttp and use them across all packages. (mefyl mirage/ocaml-cohttp#984) - cohttp-eio: Complete rewrite to follow common interfaces and behaviors. (mefyl mirage/ocaml-cohttp#984) ## v6.0.0~alpha2 (2023-08-08) - cohttp-lwt: Do not leak exceptions to `Lwt.async_exception_hook`. (mefyl mirage/ocaml-cohttp#992, mirage/ocaml-cohttp#995) - http.header, cohttp, cohttp-eio: remove "first" and "move_to_first" and the special treatment of the "host" header (mseri mirage/ocaml-cohttp#988, mirage/ocaml-cohttp#986) - http.header: introduce "iter_ord" to guarantee iteration following the order of the entries in the headers (mseri mirage/ocaml-cohttp#986) - do not omit mandatory null Content-Length headers (mefyl mirage/ocaml-cohttp#985) - cohttp-async, cohttp-curl-async: compatibility with core/async v0.16.0 (mseri, dkalinichenko-js mirage/ocaml-cohttp#976) - cohttp-lwt server: call conn_closed before drainig the body of response on error (pirbo mirage/ocaml-cohttp#982) - cohttp-eio: Relax socket interface requirement on `Server.connection_handler`. (mefyl mirage/ocaml-cohttp#983) ## v6.0.0~alpha1 (2023-04-28) - cohttp,cohttp-async server: correctly close broken streams (reported by Stéphane Glondu, fix by samhot and anuragsoni) - cohttp-eio: remove unused code from tests to work with Eio 0.8 (talex5 mirage/ocaml-cohttp#967) - Upgrade dune to v3.0 (bikallem mirage/ocaml-cohttp#947) - cohttp-eio: allow client to optionally configure request pipelining (bikallem mirage/ocaml-cohttp#949) - cohttp-eio: update to Eio 0.7 (talex5 mirage/ocaml-cohttp#952) - cohttp-eio: update examples to use eio 0.7 primitives (bikallem mirage/ocaml-cohttp#957) - cohttp-eio: generate Date header in responses (bikallem mirage/ocaml-cohttp#955) - cohttp-eio: further improve Cohttp_eio.Client ergonomics (bikallem #?) - cohttp-eio: server api improvements (bikallem mirage/ocaml-cohttp#962) ## v6.0.0~alpha0 (2022-10-24) - cohttp-eio: ensure "Host" header is the first header in http client requests (bikallem mirage/ocaml-cohttp#939) - cohttp-eio: add TE header in client. Check TE header is server (bikallem mirage/ocaml-cohttp#941) - cohttp-eio: add User-Agent header to request from Client (bikallem mirage/ocaml-cohttp#940) - cohttp-eio: add Content-Length header to request/response (bikallem mirage/ocaml-cohttp#929) - cohttp-eio: add cohttp-eio client api - Cohttp_eio.Client (bikallem mirage/ocaml-cohttp#879) - http: add requires_content_length function for requests and responses (bikallem mirage/ocaml-cohttp#879) - cohttp-eio: use Eio.Buf_write and improve server API (talex5 mirage/ocaml-cohttp#887) - cohttp-eio: update to Eio 0.3 (talex5 mirage/ocaml-cohttp#886) - cohttp-eio: convert to Eio.Buf_read (talex5 mirage/ocaml-cohttp#882) - cohttp lwt client: Connection cache and explicit pipelining (madroach mirage/ocaml-cohttp#853) - http: add Http.Request.make and simplify Http.Response.make (bikallem mseri mirage/ocaml-cohttp#878) - http: add pretty printer functions (bikallem mirage/ocaml-cohttp#880) - New eio based client and server on top of the http library (bikallem mirage/ocaml-cohttp#857) - New curl based clients (rgrinberg mirage/ocaml-cohttp#813) + cohttp-curl-lwt for an Lwt backend + cohttp-curl-async for an Async backend - Completely new Parsing layers for servers (anuragsoni mirage/ocaml-cohttp#819) + Cohttp now uses an optimized parser for requests. + The new parser produces much less temporary buffers during read operations in servers. - Faster header comparison (gasche mirage/ocaml-cohttp#818) - Introduce http package containing common signatures and structures useful for compatibility with cohttp - and no dependencies (rgrinberg mirage/ocaml-cohttp#812) - async(server): allow reading number of active connections (anuragsoni mirage/ocaml-cohttp#809) - Various internal refactors (rgrinberg, mseri, mirage/ocaml-cohttp#802, mirage/ocaml-cohttp#812, mirage/ocaml-cohttp#820, mirage/ocaml-cohttp#800, mirage/ocaml-cohttp#799, mirage/ocaml-cohttp#797) - http (all cohttp server backends): Consider the connection header in response in addition to the request when deciding on whether to keep a connection alive (anuragsoni, mirage/ocaml-cohttp#843) + The user provided Response can contain a connection header. That header will also be considered in addition to the connection header in requests when deciding whether to use keep-alive. This allows a handler to decide to close a connection even if the client requested a keep-alive in the request. - async(server): allow creating a server without using conduit (anuragsoni mirage/ocaml-cohttp#839) + Add `Cohttp_async.Server.Expert.create` and `Cohttp_async.Server.Expert.create_with_response_action`that can be used to create a server without going through Conduit. This allows creating an async TCP server using the Tcp module from `Async_unix` and lets the user have more control over how the `Reader.t` and `Writer.t` are created. - http(header): faster `to_lines` and `to_frames` implementation (mseri mirage/ocaml-cohttp#847) - cohttp(cookies): use case-insensitive comparison to check for `set-cookies` (mseri mirage/ocaml-cohttp#858) - New lwt based server implementation: cohttp-server-lwt-unix + This new implementation does not depend on conduit and has a simpler and more flexible API - async: Adapt cohttp-curl-async to work with core_unix. - *Breaking changes* + refactor: move opam metadata to dune-project (rgrinberg mirage/ocaml-cohttp#811) + refactor: deprecate Cohttp_async.Io (rgrinberg mirage/ocaml-cohttp#807) + fix: move more internals to Private (rgrinberg mirage/ocaml-cohttp#806) + fix: deprecate transfer encoding field (rgrinberg mirage/ocaml-cohttp#805) + refactor: deprecate Cohttp_async.Body_raw (rgrinberg mirage/ocaml-cohttp#804) + fix: deprecate more aliases (rgrinberg mirage/ocaml-cohttp#803) + refactor: deprecate connection value(rgrinberg mirage/ocaml-cohttp#798) + refactor: deprecate using attributes (rgrinberg mirage/ocaml-cohttp#796) + cleanup: remove cohttp-{curl,server}-async (rgrinberg mirage/ocaml-cohttp#904) + cleanup: remove cohttp-{curl,server,proxy}-lwt (rgrinberg mirage/ocaml-cohttp#904) + fix: all parsers now follow the spec and require `\r\n` endings. Previously, the `\r` was optional. (rgrinberg, mirage/ocaml-cohttp#921) - `cohttp-lwt-jsoo`: do not instantiate `XMLHttpRequest` object on boot (mefyl mirage/ocaml-cohttp#922) ## v5.0.0 (2021-12-15) - Cohttp.Header: new implementation (lyrm mirage/ocaml-cohttp#747) + New implementation of Header modules using an associative list instead of a map, with one major semantic change (function ```get```, see below), and some new functions (```clean_dup```, ```get_multi_concat```) + More Alcotest tests as well as fuzzing tests for this particular module. ### Purpose The new header implementation uses an associative list instead of a map to represent headers and is focused on predictability and intuitivity: except for some specific and documented functions, the headers are always kept in transmission order, which makes debugging easier and is also important for [RFC7230§3.2.2](https://tools.ietf.org/html/rfc7230#section-3.2.2) that states that multiple values of a header must be kept in order. Also, to get an intuitive function behaviour, no extra work to enforce RFCs is done by the basic functions. For example, RFC7230§3.2.2 requires that a sender does not send multiple values for a non list-value header. This particular rule could require the ```Header.add``` function to remove previous values of non-list-value headers, which means some changes of the headers would be out of control of the user. With the current implementation, an user has to actively call dedicated functions to enforce such RFCs (here ```Header.clean_dup```). ### Semantic changes Two functions have a semantic change : ```get``` and ```update```. #### get ```get``` was previously doing more than just returns the value associated to a key; it was also checking if the searched header could have multiple values: if not, the last value associated to the header was returned; otherwise, all the associated values were concatenated and returned. This semantics does not match the global idea behind the new header implementation, and would also be very inefficient. + The new ```get``` function only returns the last value associated to the searched header. + ```get_multi_concat``` function has been added to get a result similar to the previous ```get``` function. #### update ```update``` is a pretty new function (mirage/ocaml-cohttp#703) and changes are minor and related to ```get``` semantic changes. + ```update h k f``` is now modifying only the last occurrences of the header ```k``` instead of all its occurrences. + a new function ```update_all``` function has been added and work on all the occurrences of the updated header. ### New functions : + ```clean_dup``` enables the user to clean headers that follows the {{:https://tools.ietf.org/html/rfc7230#section-3.2.2} RFC7230§3.2.2} (no duplicate, except ```set-cookie```) + ```get_multi_concat``` has been added to get a result similar to the previous ```get``` function. - Cohttp.Header: performance improvement (mseri, anuragsoni mirage/ocaml-cohttp#778) **Breaking** the headers are no-longer lowercased when parsed, the headers key comparison is case insensitive instead. - cohttp-lwt-unix: Adopt ocaml-conduit 5.0.0 (smorimoto mirage/ocaml-cohttp#787) **Breaking** `Conduit_lwt_unix.connect`'s `ctx` param type changed from `ctx` to `ctx Lazy.t` - cohttp-mirage: fix deprecated fmt usage (tmcgilchrist mirage/ocaml-cohttp#783) - lwt_jsoo: Use logs for the warnings and document it (mseri mirage/ocaml-cohttp#776) - lwt: Use logs to warn users about leaked bodies and document it (mseri mirage/ocaml-cohttp#771) - lwt, lwt_unix: Improve use of logs and the documentation, fix bug in the Debug.enable_debug function (mseri mirage/ocaml-cohttp#772) - lwt_jsoo: Fix exception on connection errors in chrome (mefyl mirage/ocaml-cohttp#761) - lwt_jsoo: Fix `Lwt.wakeup_exn` `Invalid_arg` exception when a js stack overflow happens in the XHR completion handler (mefyl mirage/ocaml-cohttp#762). - lwt_jsoo: Add test suite (mefyl mirage/ocaml-cohttp#764). ## v4.0.0 (2021-03-24) - cohttp.response: fix malformed status header for custom status codes (mseri aalekseyev mirage/ocaml-cohttp#752) - remove dependency to base (samoht mirage/ocaml-cohttp#745) - add GitHub Actions workflow (smorimoto mirage/ocaml-cohttp#739) - `cohttp-lwt-jsoo`: Forward exceptions to caller when response is null (mefyl mirage/ocaml-cohttp#738) - Use implicit executable dependency for generate.exe (TheLortex mirage/ocaml-cohttp#735) - cohttp: fix chunked encoding of empty body (mefyl mirage/ocaml-cohttp#715) - cohttp-async: fix body not being uploaded with unchunked Async.Pipe (mefyl mirage/ocaml-cohttp#706) - cohttp-{async, lwt}: fix surprising behaviours of Body.is_empty (anuragsoni mirage/ocaml-cohttp#714 mirage/ocaml-cohttp#712 mirage/ocaml-cohttp#713) - refactoring of tests (mseri mirage/ocaml-cohttp#709, dinosaure mirage/ocaml-cohttp#692) - update documentation (dinosaure mirage/ocaml-cohttp#716, mseri mirage/ocaml-cohttp#720) - fix deadlock in logging (dinosaure mirage/ocaml-cohttp#722) - improve media type parsing (seliopou mirage/ocaml-cohttp#542, dinosaure mirage/ocaml-cohttp#725) - [reverted] breaking changes to client and server API to use conduit 3.0.0 (dinosaure mirage/ocaml-cohttp#692). However, as the design discussion did not reach consensus, these changes were reverted to preserve better compatibility with existing cohttp users. (samoht mirage/ocaml-cohttp#741) **Potentially breaking changes** - remove `wrapped false` from the codebase (rgrinberg mirage/ocaml-cohttp#734) - cohttp: add Uri.scheme to Request.t (brendanlong mirage/ocaml-cohttp#707) - cohttp: update HTTP codes (emillon mirage/ocaml-cohttp#711) - cohttp-lwt-jsoo: rename Cohttp_lwt_xhr to Cohttp_lwt_jsoo for consistency (mseri mirage/ocaml-cohttp#717) - cohttp: fix transfer-encoding ordering in headers (mseri mirage/ocaml-cohttp#721) - lower-level support for long-running cohttp-async connections (brendanlong mirage/ocaml-cohttp#704) - add of_form and to_form functions to body (seliopou mirage/ocaml-cohttp#440, mseri mirage/ocaml-cohttp#723) - cohttp-lwt: partly inline read_response, fix body stream leak (madroach dinosaure mirage/ocaml-cohttp#696). Note: there is a new warning that may show up in your logs when bodies are leaked, see also [mirage/ocaml-cohttp#730](mirage/ocaml-cohttp#730). - add comparison functions for Request.t and Response.t via ppx_compare (msaffer-js dinosaure mirage/ocaml-cohttp#686) ## v3.0.0 - aborted ## v2.5.5 (2021-03-15) - `Cohttp_async.resolve_local_file`, `Cohttp_lwt.resolve_local_file` and `Cohttp_lwt_unix.resolve_file` are now the same code under the hood (`Cohttp.Path.resolve_local_file`). The old names have been preserved for compatibility, but will be marked as deprecated in the next release. This changes the behavior of `Cohttp_lwt_unix.resolve_file`: it now percent-decodes the paths and blocks escaping from the docroot correctly. This also fixes and tests the corner cases in these methods when the docroot is empty. (ewanmellor mirage/ocaml-cohttp#755) ## v2.5.4 (2020-07-21) - cohttp: a change in mirage/ocaml-cohttp#694 modified the semantics of Header.replace. The semantics change is reverted, and a new Header.update function is introduced, following the semantics of Map.update. (mirage/ocaml-cohttp#702 mseri) - cohttp: reimplement update to support compilers that are older than OCaml 4.06 (mirage/ocaml-cohttp#703 mseri) ## v2.5.3 (2020-06-27) - cohttp-async: adapt to async >= v0.14 (mirage/ocaml-cohttp#699 copy) ## v2.5.2 (2020-06-27) - cohttp, cohttp-async: correctly set host header for unix domain sockets, implement Unix domain socket support for cohttp-async (mirage/ocaml-cohttp#698 Leonidas-from-XIV) - cohttp: better body encoding management when creating request and response, and correction of Header.replace function (mirage/ocaml-cohttp#694 lyrm) ## v2.5.1 (2020-02-18) - cohttp-lwt: pass ctx through HEAD client requests (mirage/ocaml-cohttp#689 hannesm) ## v2.5.0 (2019-12-17) - cohttp-async: support async v0.13.0 (mirage/ocaml-cohttp#680 copy) - cohttp-lwt-jsoo: support js_of_ocaml 3.5.0 and higher (avsm) ## v2.4.0 (2019-11-08) - mirage: adapt to new mirage interfaces: mirage-flow 2.0.0, mirage-channel 4.0.0, mirage-kv 3.0.0 (mirage/ocaml-cohttp#678 hannesm) - async: use Pipe.singleton instead of Pipe.of_list as it is more efficient (mirage/ocaml-cohttp#677 smuenzel-js) ## v2.3.0 (2019-08-18) - use conduit-mirage instead of mirage-conduit, which was renamed upstream in conduit. The minimum OCaml version supported for conduit-mirage is now OCaml 4.07 and higher. (mirage/ocaml-cohttp#672 avsm) - remove deprecation warnings in OCaml 4.08.0 using stdlib-shims (mirage/ocaml-cohttp#672 avsm) - async: do not read body if none is present (mirage/ocaml-cohttp#671 emillon) ## v2.2.0 (2019-07-20) - Previously if the client closed the connection while cohttp was handling a request, the server would crash (by default, unless the user overrode that using `on_exn` or changing Lwt's async exception handler). Now, cohttp will just log this at `info` level and continue. Exceptions produced by user code are logged as errors, while other exceptions generated by cohttp call back to the conduit exception handler, as before. (mirage/ocaml-cohttp#669 talex5) ## v2.1.3 (2019-07-12) - support uri.3.0.0 that has optional sexp support (mirage/ocaml-cohttp#668 avsm) - use re.1.9.0 api to remove deprecation warnings (mirage/ocaml-cohttp#664 vbmithr) ## v2.1.2 (2019-04-09) - cohttp: handle empty cookie components gracefully without raising an exception (mirage/ocaml-cohttp#663 martinslota) ## v2.1.1 (2019-04-05) - `cohttp-mirage`: remove dependency on the `result` module (mirage/ocaml-cohttp#662 hannesm) - Support Async v0.12.0 and higher (mirage/ocaml-cohttp#661 copy) ## v2.1.0 (2019-03-01) - `cohttp-mirage`: update to the newest `Mirage_kv.RO` API ## v2.0.0 (2019-02-04) Compatibility breaking interface changes: Async: Expert response action no longer writes empty HTTP body (mirage/ocaml-cohttp#647 by andreas) In cohttp.0.99, a number of subpackages were turned into explicit opam packages to simplify dependency management. To aid migration, some compatibility shims were left in place so that the old findlib names would continue to work. They have now been removed as of this release. If you were still using them, then please rename them as follows: - `cohttp.lwt-core` -> `cohttp-lwt` - `cohttp.lwt` -> `cohttp-lwt-unix` - `cohttp.js` -> `cohttp-lwt-jsoo` - `cohttp.async` -> `cohttp-async` - `cohttp.top` -> `cohttp-top` Other changes and bugfixes: * Lwt, Mirage: Add log warnings for uncaught exceptions (mirage/ocaml-cohttp#592 by ansiwen) * Log invalid client input and do not catch out of memory exceptions (mirage/ocaml-cohttp#652 hannesm) * Port opam files to opam2 and add local synopsis and descriptions. * Lwt: Add Expert response action for servers (mirage/ocaml-cohttp#647 by andreas) * Use the namespaced `js_of_ocaml` interfaces from 3.3.0 onwards (mirage/ocaml-cohttp#654 avsm) * Use Base64 3.1.0 interfaces (mirage/ocaml-cohttp#655 avsm) * Clean up redundant conflicts in the `opam` files (avsm) ## v1.2.0 (2018-10-19) * Support more than a single chunk extension for RFC7320 compliance (mirage/ocaml-cohttp#618 by djs55) * Lwt-unix: add a `?backlog` argument to the serve function (samoht) * Use the uri.2.0.0 interfaces for sexpression generation of types (avsm) * Switch to `sexplib0` for a more lightweight s-expression library (mseri) * Minimum OCaml compiler version requirement is now 4.04.1 (mseri) * Add an example of using custom resolvers to the README (mseri) ## v1.1.1 (2018-08-13) * Update to be compatible with new async/core (mirage/ocaml-cohttp#607 by rgrinberg) * Remove use of deprecated `Lwt_logs` (mirage/ocaml-cohttp#609 by raphael-proust) * Do not rely on locale for printing qvalues (mirage/ocaml-cohttp#611 by vbmithr) * Ppx dependencies aren't just build time dependencies (mirage/ocaml-cohttp#625 by rgrinberg) ## v1.1.0 (2018-03-28) * Add an "expert mode" to hand off raw responses to a custom handler, which in turns makes protocols like Websockets easier (mirage/ocaml-cohttp#488 by msaffer). * Set the user-agent by default if one is not provided (mirage/ocaml-cohttp#586 by TheCBaH). * Fix typo in the `cohttp.js` META file. * Refresh use of the Re library to the latest version (mirage/ocaml-cohttp#602 by rgrinberg). * Rearrange the ppx dependencies to be more specific (mirage/ocaml-cohttp#596 by yomimono). * Explicitly depend on sexplib in the Async backend (mirage/ocaml-cohttp#605 by kevinqiu). ## v1.0.2 (2018-01-06) * Support Async v0.10.0 and OCaml 4.06.0 (mirage/ocaml-cohttp#588 via vbmithr) * Require `ppx_type_conv`>=v0.9.1` due to a bug with duplicate modules present in earlier versions. ## v1.0.1 (2018-01-03) * cohttp-mirage: expose the missing IO module (mirage/ocaml-cohttp#594, samoht) * cohttp-mirage: catch exceptions when closing channels in mirage client (mirage/ocaml-cohttp#589, ansiwen) ## v1.0.0 (2017-11-16) * opam: rename `mirage-http` to `cohttp`-mirage` (mirage/ocaml-cohttp#572) * cohttp-lwt{,-unix}: wrap the libraries in top-level modules (mirage/ocaml-cohttp#568) * opam: improve dependencies (mirage/ocaml-cohttp#574, mirage/ocaml-cohttp#566, mirage/ocaml-cohttp#575) * cohttp: add the convenience function `Header.is_empty` (mirage/ocaml-cohttp#576) * fix compatibility with OCaml 4.06 and `-safe-string` (mirage/ocaml-cohttp#580, mirage/ocaml-cohttp#581) ## v0.99.0 (2017-07-12) Port build to jbuilder, and break up OPAM packages into multiple independent packages instead of being optional dependencies against the main `cohttp` package. This makes it significantly easier to depend on precisely the libraries you need, but requires porting applications to use the new `ocamlfind` and `opam` scheme. The new package layout is: - `cohttp`: the main `Cohttp` module - `cohttp-lwt`: the portable Lwt implementation - `cohttp-lwt-unix`: the Lwt/Unix implementation - `cohttp-lwt-jsoo`: the js-of-ocaml JavaScript implementation - `cohttp-async`: the Jane Street Async implementation - `mirage-http`: the MirageOS compatible implementation - `cohttp-top`: a toplevel printer for the Cohttp types. In each of these packages, the `opam` and `ocamlfind` package names are now _the same_, so you will need to rename the former subpackages such as `cohttp.async` to `cohttp-async`. The implementation is otherwise the same, so no other code changes should be required. In return for these breaking changes to the packaging, it is now significantly easier to depend on a particular backend, also for us to rev the interfaces towards a stable 1.0 release. Jbuilder also builds the source tree around 4x faster than it did previously. A number of deprecation warnings have been added to the source tree as well to mark the interfaces that will be removed in 1.0. These are `Cohttp_lwt.{Client,Server,Net}`, and a `Cohttp_lwt.Body` alias was added to deprecate the direct use of `Cohttp_lwt_body`. This will let us unify the namespaces of all the packages to use a single top-level module for each package in the future. Most of the release and packaging work here was done by rgrinberg and avsm. ## 0.22.0 (2017-03-09) * Lwt: ensure conn_closed is closed once client goes away (mirage/ocaml-cohttp#528) * Use the Logs library for logging. (mirage/ocaml-cohttp#532) ## 0.21.1 (2017-02-18) * Remove -principal from type checking temporarily, to workaround a bug in the OCaml 4.03 type checker that causes compilation hangs (http://caml.inria.fr/mantis/view.php?id=7305). * Improve documentation in the `test_xhr.ml` js_of_ocaml test. * XHR: Allow setting withCredentials * Async: pass along ?ssl_config when connecting to Uri's (mirage/ocaml-cohttp#510) * Lwt: Add on ?on_exn to Server.create (mirage/ocaml-cohttp#518) * Add Header.to_frames ## 0.21.0 (2016-05-22) * Allow to request paths as strings (mirage/ocaml-cohttp#470, mirage/ocaml-cohttp#478) ## 0.20.2 (2016-04-04) * Update META version (mirage/ocaml-cohttp#473) * uri.services is only required by cohttp.async 0.20.1 (2016-04-01) * Switch cohttp to use ppx (mirage/ocaml-cohttp#457) * Lwt: Fix leak on HEAD client requests (mirage/ocaml-cohttp#467) 0.20.0 (2016-03-25) * Switch to pa_fields_conv and pa_sexp_conv for camlp4 extensions (mirage/ocaml-cohttp#465) * Compatibility with latest async (mirage/ocaml-cohttp#468) * Async: Add support for SSL parameters in client (mirage/ocaml-cohttp#466) * Lwt: ignore Sig.sigpipe under Windows (mirage/ocaml-cohttp#456) * Lwt: Fix FD leak (mirage/ocaml-cohttp#447) * Lwt: Log uncaught user exceptions * Async: Close non-persistent async connections (mirage/ocaml-cohttp#442) 0.19.3 (2015-09-28): * Support Async 113.00 by explicitly using the blocking Core `printf` (mirage/ocaml-cohttp#431) * cohttp_curl_async: add `-data-binary` to send POST data. (mirage/ocaml-cohttp#425) 0.19.2 (2015-08-20): * Improve Cohttp_async.Client error handling. When a Uri.t fails to resolve it is now included in the error. (mirage/ocaml-cohttp#420) 0.19.1 (2015-08-08): * Bring make_body_writer and write_header in Cohttp.S.Http_io. Needed by ocaml-git 0.19.0 (2015-08-05): Compatibility breaking interface changes: * Remove `read_form` from the `Request/Response/Header` interfaces as this should be done in `Body` handling instead (mirage/ocaml-cohttp#401). New features and bug fixes: * Remove `IO.write_line` as it was unused in any interfaces. * Do not use the `lwt` camlp4 extension. No observable external difference. * Do not return a code stacktrace in the default 500 handler. * Add `Cohttp.Header.compare` (mirage/ocaml-cohttp#411) * Fix typos in CLI documentation (mirage/ocaml-cohttp#413 via moonlightdrive) * Use the Lwt 2.5.0 buffer API. * `Cohttp_lwt.read_response` now has a non-optional `closefn` parameter (mirage/ocaml-cohttp#400). * Add a `Cohttp_lwt_s` module that contains all the Lwt module types in one convenient place (mirage/ocaml-cohttp#397). 0.18.3 (2015-07-12): * Allow `DELETE` requests to have request bodies (mirage/ocaml-cohttp#383). * Improve the Lwt client `callv` for HTTP/1.1 pipelined requests (mirage/ocaml-cohttp#379 via Török Edwin). 0.18.2 (2015-06-19): * Do not add content encoding for 204's (mirage/ocaml-cohttp#375) 0.18.1 (2015-06-05): * Remove trailing whitespace from headers (mirage/ocaml-cohttp#372) * Don't reverse order of list valued headers (mirage/ocaml-cohttp#372) 0.18.0 (2015-06-02): * Add Cohttp_async.Client.callv. Allows for making requests while reusing an HTTP connection (mirage/ocaml-cohttp#344) * Responses of status 1xx/204/304 have no bodies and cohttp should not attempt to read them (mirage/ocaml-cohttp#355) * Add top level printers. See cohttp.top findlib package (mirage/ocaml-cohttp#363) * Add `Header.to_string` (mirage/ocaml-cohttp#362) * Fix chunk truncation in chunked transfer encoding (mirage/ocaml-cohttp#360) Compatibility breaking interface changes: * Remove `Request`/`Response` modules outside of Cohttp pack (mirage/ocaml-cohttp#349) 0.17.2 (2015-05-24): * Remove dependency on the Lwt Camlp4 syntax extension (mirage/ocaml-cohttp#334). * Add `make github` target to push documentation to GitHub Pages (mirage/ocaml-cohttp#338 from Jyotsna Prakash). * Add Async integration tests and consolidate Lwt tests using the new framework (mirage/ocaml-cohttp#337). * Fix allocation of massive buffer when handling fixed size http bodies (mirage/ocaml-cohttp#345) 0.17.1 (2015-04-24): * [async] Limit buffer size to a maximum of 32K in the Async backend (mirage/ocaml-cohttp#330 from Stanislav Artemkin). * Add `Cohttp.Conf.version` with the library version number included. * Remove debug output from `cohttp-curl-async`. * Add the beginning of a `DESIGN.md` document to explain the library structure. 0.17.0 (2015-04-17): Compatibility breaking interface changes: * `CONNECT` and `TRACE` methods added to `Code`.Exhaustive matches will need updating. New features and bug fixes: * `Link` header parsing has been added as `Cohttp.Link`, `Header.get_links` and `Header.add_links` * `cohttp_server_*` now obeys `HEAD` requests and responds 405 to unknown methods * `Cohttp_async.Server.response` type is now exposed as a `response * body` pair * Failure to read a body in a pipelined response no longer terminates the stream * Fix `cohttp_curl_lwt -X HEAD` sending empty chunked body (mirage/ocaml-cohttp#313) * Fix a bug which left extra `\r\n` in buffer at end of chunked reads * Fix handling of request URI for query strings and `CONNECT` proxies (mirage/ocaml-cohttp#308, mirage/ocaml-cohttp#318) * Fix precedence of `Host` header when request-URI is absolute URI * Fix request URI path to be non-empty except for * requests (e.g. `OPTIONS *`) 0.16.1 (2015-04-09): New features and bug fixes: * Fix handling of request paths starting with multiple slashes (mirage/ocaml-cohttp#308) 0.16.0 (2015-03-23): Compatibility breaking interface changes: * Response.t and Request.t fields are no longer mutable * [lwt] Fix types in `post_form` to be a `string * string list` instead of a `Header.t` (mirage/ocaml-cohttp#257) * Simplify the `Net` signature which needs to be provided for Lwt servers to not be required. Only the Lwt client needs a `Net` functor argument to make outgoing connections. (mirage/ocaml-cohttp#274) * The `Request` and `Response` records are no longer mutable, so use functional updates instead via `Fieldslib.Field.fset Request.Fields.<field>`. (mirage/ocaml-cohttp#296) * `Request.has_body` does not permit a body to be set for methods that RFC7231 forbids from having one (`HEAD`, `GET` and `DELETE`). New features and bug fixes: * Fix linking problem caused by sub-libraries using cohttp modules outside the cohttp pack. * Added async client for S3. (mirage/ocaml-cohttp#304) * Fix String_io.read_line to trim '\r' from end of string (mirage/ocaml-cohttp#300) * Fix `cohttp-server-lwt` to correctly bind to a specific interface (mirage/ocaml-cohttp#298). * Add `Cohttp_async.request` to send raw, unmodified requests. * Supplying a `content-range` or `content-range` header in any client request will always override any other encoding preference (mirage/ocaml-cohttp#281). * Add a `cohttp-lwt-proxy` to act as an HTTP proxy. (mirage/ocaml-cohttp#248) * Extend `cohttp-server-async` file server to work with HTTPS (mirage/ocaml-cohttp#277). * Copy basic auth from `Uri.userinfo` into the Authorization header for HTTP requests. (mirage/ocaml-cohttp#255) * Install binaries via an OPAM `.install` file to ensure that they are reliably uninstalled. (mirage/ocaml-cohttp#252) * Use the `magic-mime` library to add a MIME type by probing filename during static serving in the Lwt/Async backends. (mirage/ocaml-cohttp#260) * Add `Cohttp.Header.add_opt_unless_exists` to set a header only if an override wasn't supplied, and to initialise a fresh Header value if none is present. * Do not override user-supplied headers in `post_form` or `redirect`. * `Request.make` does not inject a `transfer-encoding` header if there is no body present in the request (mirage/ocaml-cohttp#246). * `Server.respond` no longer overrides user-supplied headers that specify the `content-length` or `transfer-encoding` headers (mirage/ocaml-cohttp#268). * `cohttp_server_lwt` and `cohttp_server_async` now include sizes in directory listing titles * Add `Header.add_multi` to initialise a header structure with multiple fields more efficiently (mirage/ocaml-cohttp#272). * Expose `IO.ic` and `IO.oc` types for `Cohttp_async` (mirage/ocaml-cohttp#271). * Skip empty body chunks in `Transfer_io.write` (mirage/ocaml-cohttp#270). * With the Lwt backend, `read` hangs if trying to fetch more than `Sys.max_string_length` (which can be triggered on 32-bit platforms). Read only a maximum that fits into a string (mirage/ocaml-cohttp#282). * `cohttp-curl-lwt` now takes http method as parameter (mirage/ocaml-cohttp#288) * Fix installation of server binaries in OPAM metadata. (mirage/ocaml-cohttp#295) 0.15.2 (2015-02-15): * When transfer encoding is unknown, read until EOF when body size is unknown. (mirage/ocaml-cohttp#241) * Add some missing documentation to `Cohttp.S.IO` signature. (mirage/ocaml-cohttp#233) * Add `Cohttp.Header.mem` to check if a header exists. * Add `Cohttp.Conf` module to expose the library version number. (mirage/ocaml-cohttp#259) * Add `Cohttp.Header.add_unless_exists` to update a key if it doesn't already exist. (mirage/ocaml-cohttp#244) * Add `Cohttp.Header.get_location` to retrieve redirection information. (mirage/ocaml-cohttp#254) * [async] Clean up the `Net.lookup` function to use `Or_error.t` instead of raising. (mirage/ocaml-cohttp#247) * [tests] Add more tests for `content-range` handling. (mirage/ocaml-cohttp#249) 0.15.1 (2015-01-10): * Lwt 2.4.7 renamed `blit_bytes_string` to `blit_to_bytes`, so depend on the newer API now. (mirage/ocaml-cohttp#230) * Use `cmdliner` in all of the Lwt client and server binaries. This gives `cohttp-lwt-server` a nice Unix-like command-line interface now that can be viewed with the `--help` option. (mirage/ocaml-cohttp#218 via Runhang Li) * Improve `oasis` constraints and regenerate `opam` file (mirage/ocaml-cohttp#229 via Christophe Troestler). 0.15.0 (2014-12-24): Compatibility breaking interface changes: * Change `Cohttp_lwt_body.map` to use a non-labelled type to fit the Lwt style better (mirage/ocaml-cohttp#200). * Depend on Base64 version 2, which uses `B64` as the toplevel module name (mirage/ocaml-cohttp#220). New features and bug fixes: * Remove use of deprecated `Lwt_unix.run` and replace it with `Lwt_main.run`. Should be no observable external change (mirage/ocaml-cohttp#217). * Improve ocamldoc of `Cohttp.S` signature (mirage/ocaml-cohttp#221). 0.14.0 (2014-12-18): Compatibility breaking interface changes: * Simplify the Lwt server signature, so that manual construction of a `callback` is no longer required (mirage/ocaml-cohttp#210). Code that previous looked like: ``` let conn_closed (_,conn_id) () = <...> let config = { Server.callback; conn_closed } in ``` should now be: ``` let conn_closed (_,conn_id) = <...> let config = Server.make ~callback ~conn_closed () in ``` * Remove the `Cohttp.Base64` module in favour of the external `base64` library (which is now a new dependency). New features and bug fixes: * Lwt `respond_error` now defaults to an internal server error if no status code is specified (mirage/ocaml-cohttp#212). * Modernise the `opam` file using the OPAM 1.2 workflow (mirage/ocaml-cohttp#211). * Flush the response body to the network by default, rather than buffering by default. The `?flush` optional parameter can still be explicitly set to false if flushing is not desired (mirage/ocaml-cohttp#205). 0.13.0 (2014-12-05): Compatibility breaking interface changes: * Add sexp converters for Conduit contexts and `Lwt` client and server modules and module types. New features and bug fixes: * Can use the Conduit 0.7+ `CONDUIT_TLS=native` environment variable to make HTTPS requests using the pure OCaml TLS stack instead of depending on OpenSSL bindings. All of the installed binaries (client and server) can work in this mode. * Add `Cohttp_lwt_unix_debug` which lets libraries control the debugging output from Cohttp. Previously the only way to do this was to set the `COHTTP_DEBUG` environment variable at the program start. * Add `cohttp-curl-lwt` as a lightweight URI fetcher from the command-line. It uses the `cmdliner` as a new dependency. * Remove build dependency check on `lwt.ssl` for `cohttp.lwt`. This has been moved to conduit, so only `lwt.unix` is needed here now. 0.12.0 (2014-11-07): Compatibility breaking interface changes: * Rename `Cohttp.Auth.t` to `Cohttp.Auth.credential` and `Cohttp.Auth.req` to `Cohttp.Auth.challenge`. Also expose an `Other` variant to make it more extensible for unknown authentication types. The `Cohttp.Auth` functions using these types have also been renamed accordingly. * Rename `Cohttp.Transfer.encoding_to_string` to `string_of_encoding` for consistency with the rest of Cohttp's APIs. * The `has_body` function in the Request and Response modules now explicitly signals when the body size is unknown. * Move all the module type signatures into `Cohttp.S`. * If users have percent-encoded file names, their resolution is changed: `resolve_local_file` in `Cohttp_async` and `Cohttp_lwt` now always percent-decode paths (mirage/ocaml-cohttp#157) * Remove the `Cohttp_lwt.Server.server` type synonym to `t`. * When reading data from a HTTP body stream using the `Fixed` encoding, we need to maintain state (bytes remaining) so we know when to finish. The `Cohttp.Request` and `Cohttp.Response` interfaces now expose a `reader` and `writer` types to track this safely. * Add `is_empty` function to the `Cohttp.S.Body` module type. * Add `Strings` representation to `Cohttp.Body` to efficiently hold a list of body chunks. * Move flushing logic for HTTP bodies into the portable `Request` and `Response` modules instead of individual Lwt and Async backends. * Port module interfaces to the latest Conduit (0.6.0+) API. * Cohttp requires OCaml 4.01.0 or higher now. New features and bugfixes: * Add a `Cohttp_lwt_xhr` JavaScript backend that enables Cohttp logic to be mapped to `XMLHTTPRequest` in browsers via `js_of_ocaml` (via Andy Ray). * Add a `Cohttp.String_io` and `String_io_lwt` module that uses OCaml `string` or `Buffer.t` to read and write HTTP requests and responses instead of network connections. * `cohttp_server_lwt` and `cohttp_server_async` now return better errors (mirage/ocaml-cohttp#158) * `cohttp_server_lwt` and `cohttp_server_async` now serve indexes directly (mirage/ocaml-cohttp#162) * [lwt] Add `stop` thread to terminate a running server if it finishes (mirage/ocaml-cohttp#147). * Add `Cohttp.Connection.compare` to make ordering of connections possible. * Add `Body.map` and `Body.as_pipe` to work with HTTP bodies more easily. * Remove link-time dependency on camlp4 via META fixes (mirage/ocaml-cohttp#127). * Support HTTP methods and versions other than the standard ones. (mirage/ocaml-cohttp#142). * Improve `cohttp_server_lwt` and `cohttp_server_async` directory listings (mirage/ocaml-cohttp#158) * Fix `Cohttp_async.resolve_local_file` directory traversal vulnerability (mirage/ocaml-cohttp#158) * [async] In the Async server, do not close the Reader too early. * [async] Close file descriptors more eagerly in the HTTP client (mirage/ocaml-cohttp#167). * Reduce thread allocation by replacing `return <const>` with `return_none`, `return_unit` or `return_nil`. 0.11.2 (2014-04-21) * Fix build by add a missing build-deps in _oasis. 0.11.1 (2014-04-17): * Remove an errant async_ssl reference left in the _oasis file that is now handled by the Conduit library (mirage/ocaml-cohttp#116). * Add an Lwt-based SimpleHTTPServer equivalent as `cohttp-server-lwt` (mirage/ocaml-cohttp#108). * `Cohttp.Connection.t` now exposes sexp accessor functions (mirage/ocaml-cohttp#117). 0.11.0 (2014-04-01): * Remove dependency on `ocaml-re` in order to make library POSIX thread-safe. * Shift most of the connection handling logic out to a Conduit library that worries about which SSL library to use, and fails if SSL is not available. * Add Async-SSL support for both client and server (mirage/ocaml-cohttp#102). * Add Lwt-SSL support for the server side (the client side existed before). * Fix buggy Async chunked POST handling. 0.10.0 (2014-03-02): * Interface change: The `Request` and `Response` module types now explicitly signal `Eof` and `Invalid` (for errors), to help the backend distinguish them. * Interface change: Unify HTTP body handling across backends into a `Cohttp.Body` module. This is extended by Async/Lwt implementations with their specific ways of handling bodies (Pipes for Async, or Lwt_stream for Lwt). * [lwt] Interface change: HTTP client calls now raise Lwt exceptions rather than return an option type. This permits better error handling in Lwt. * [lwt] Interface change: The `Server` callback now always provides a `body` argument, since `Cohttp_lwt_body` now explicitly supports empty bodys. * Add `Cohttp.Header.is_keep_alive` to test if a connection should be reused. * [lwt] Respect the `keep-alive` header in the server request handling. * [async] Add a `Body` that takes a `Pipe` or a `string`, similarly to Lwt. * Install `cohttp-server` binary even if tests are disabled. * Begin an `examples` directory with some simple uses of the library. 0.9.16 (2014-01-30): * Add some module type equalities in `Cohttp_lwt_unix` so that `Cohttp_lwt_unix.Server.Request.IO.ic` can be equivalen to `Lwt_io.input_channel`. * Add sexp converters to most Cohttp types (mirage/ocaml-cohttp#83). * Improve Travis tests to cover more upstream users of Cohttp. * Refactor build flags to let the portable Lwt-core be built independently of Lwt.unix. 0.9.15 (2014-01-11): * Remove `Cohttp_mirage` libraries, which have now moved to `mirage/mirage-http-*` on GitHub. * Add an "HTTP only" `Cookie` attribute (mirage/ocaml-cohttp#69). * Fix parsing of cookies with `=` in the values (mirage/ocaml-cohttp#71). * Add `Max-age` support for cookies (mirage/ocaml-cohttp#70). * Make the `Response` record fields mutable to match the `Request` (mirage/ocaml-cohttp#67). * Fix compilation with Async 109.58.00 (mirage/ocaml-cohttp#77). * Make Header handling case-insensitive (by forcing lowercase) (mirage/ocaml-cohttp#75). * Remove the `>>` operator as it was unused and had incorrect precedence (mirage/ocaml-cohttp#79). 0.9.14 (2013-12-15): * Install a `cohttp-server` binary that serves local directory contents via a web server (mirage/ocaml-cohttp#54). * Add a `flush` function to the `IO` module type and implement in Lwt/Async/Mirage. * Add option `flush` support in the Async and Lwt responders (mirage/ocaml-cohttp#52). * Autogenerate HTTP codes from citricsquid's JSON representation of the HTTP RFCs. * Always set `TCP_NODELAY` for Lwt/Unix server sockets for low-latency responses (mirage/ocaml-cohttp#58). * Added a Server-Side Events test-case from the HTML5 Doctor. See `lib_test/README.md`. * Async.Server response now takes an optional `body` rather than a mandatory `body option` (mirage/ocaml-cohttp#62). * Regenerate build system using OASIS 0.4.0. 0.9.13 (2013-12-10): * The `cohttp.lwt-core` is now installed as an OS-independent Lwt library. * Add support for Mirage 1.0, via `cohttp.mirage-unix` and `cohttp.mirage-xen`. * Add a new `Cohttp.Connection` module to manage server's connections identifiers. * Share the same configuration type for the different server implementations. * Add `Accept_types` module to the `Cohttp` pack. 0.9.12 (2013-11-28): * Improve documentation for `Cohttp.Header`. * Expose Fieldslib setters and getters for most of the `Cohttp` types (mirage/ocaml-cohttp#38). * `Cohttp.Set_cookie.t` is no longer an abstract type to make it easier to update (mirage/ocaml-cohttp#38). * [Lwt] ignore SIGPIPE unconditionally if using the Lwt/Unix module (mirage/ocaml-cohttp#37). * Rename `Cookie` creation parameters for consistency (interface breaking, see mirage/ocaml-cohttp#44). * Fix transfer-length detection (regression from 0.9.11 in mirage/ocaml-cohttp#42). * Add Merin editor file (mirage/ocaml-cohttp#41). 0.9.11 (2013-10-27): * Request module: When sending a request, add the port information in the host header field if available. * Request module: When parsing a request, add scheme, host and port information in the uri. * TCP server: When creating the socket for the server, do not force PF_INET6 but take the sockaddr value. * Add HTTP OPTIONS method. * Use getaddrinfo instead of gethostbyname for DNS resolution. * Async: improve HTTP/1.0 support (mirage/ocaml-cohttp#35). * Build with debug symbols, binary annotations by default. * Add Travis CI test scripts. 0.9.10 (2013-06-21): * Add `set-cookie` header extraction functions for clients that read cookies. * Explicitly flush the debug output when the `COHTTP_DEBUG` env variable is set. * [async] Add client head/post/patch/delete methods. * [lwt] Client.head no longer returns a response body, just the metadata. * [lwt] Do not send chunked encoding headers with GET/DELETE requests that have no body. 0.9.9 (2013-06-12): * Disable the mirage executable test as it was building too aggressively and breaking builds. 0.9.8 (2013-05-24): * Lwt interface change: Rewrite Lwt backends to share code, and remove duplicate function calls from Uri. * Depend on `Uri` 1.3.8+ as it exposes the parameter query functions now removed from `Request`. * Do not depend on Cstruct in core library, as only Mirage needs it. * Remove `Cohttp_async.body` type alias and just use `string Pipe.Reader.t` for more explicit types. 0.9.7 (2013-05-10): * Attach a GC finaliser to the Lwt client to ensure that even an HTTP body isn't consumed, the socket will eventually be closed (mirage/ocaml-cohttp#11). * Add an Async.Server interface, and revise the Client interface to be more in line with Core standards. * Add 422 Unprocessable Entity code. * Refactor modules better across Lwt/Async, but incompatible with earlier releases for Async (Lwt is unchanged at present). * Add user agent string and User-Agent header helper function * The git history of this release is full of adventures in parameterised monads and refactoring, but this isn't in the actual release. Yet. 0.9.6 (2013-03-18): * Depend on Async (>= 109.12.00), which has an incompatible API with earlier versions. * Rearrange core library files for `obuild` support. 0.9.5 (2012-12-29): * Fix cookie parsing to retrieve the correct header. * Update to `mirage-net` 0.5.0 API (based on cstruct 0.6.0). 0.9.4 (2012-12-19): * Add Lwt `respond_redirect` and `respond_need_auth` helpers. * Add enough Basic authorization support to serve a password-protected website. * Fix Lwt file serving to not throw exception on trying to serve a directory. * Port Async interface to 108.07.00 or higher (incompatible with earlier versions). 0.9.3 (2012-10-27): * Add basic cookie support back to the portable library. * `Cohttp_lwt.Client.post_form` now uses non-chunked encoding for the POST instead of chunked. * Various improvements and tests for the pipelined Lwt Client.callv * If an Lwt callback does not consume a body, ensure it has been drained by the API to prevent future pipelines from stalls. * Fix handling of Lwt server non-empty POST bodies. * Map the `put` functions to HTTP PUT instead of POST. 0.9.2 (2012-09-20): * Add Request.get_param to extract a singleton key from queries. * Fix chunked encoding handling when short reads occur. * Install HTML documentation for all enabled drivers. * Use ocaml-uri-1.3.2 interface for query parsing. * Lwt: Add Server.respond_file and resolve_file for the Unix library to make it easier to serve static files. * Lwt: Server.respond_not_found takes an optional Uri.t now. 0.9.1 (2012-09-11): * Functorise for Async, Lwt_unix and Mirage. * Use URI and Re libraries to not need Str any more. * More robust parsing for various HTTP headers. 0.9.0 (2012-08-01): * Initial public release.

bikallem mentioned this pull request Feb 1, 2022

RFC : Port cohttp-lwt-unix to eio using lwt_eio #854

Closed

bikallem changed the title ~~RFC: pure eio version of cohttp~~ RFC: eio-only version of cohttp Feb 1, 2022

bikallem force-pushed the eio-3 branch from 2350a7e to 82197b3 Compare February 2, 2022 15:48

mseri reviewed Feb 2, 2022

View reviewed changes

cohttp-eio/src/cohttp_eio.mli Outdated Show resolved Hide resolved

mseri reviewed Feb 2, 2022

View reviewed changes

cohttp-eio/src/parser.ml Outdated Show resolved Hide resolved

mseri reviewed Feb 2, 2022

View reviewed changes

cohttp-eio/src/cohttp_eio.mli Outdated Show resolved Hide resolved

bikallem force-pushed the eio-3 branch 4 times, most recently from 1f993c6 to f42f787 Compare February 2, 2022 18:30

rgrinberg reviewed Feb 2, 2022

View reviewed changes

rgrinberg reviewed Feb 3, 2022

View reviewed changes

Update CHANGES

72d6648

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

mseri force-pushed the eio-3 branch from 29d4cf8 to 72d6648 Compare June 8, 2022 19:08

mseri reviewed Jun 8, 2022

View reviewed changes

ci: update use of alpha repository for ocaml 5.0.0

c444f76

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

mseri force-pushed the eio-3 branch from 6313ea3 to c444f76 Compare June 8, 2022 19:26

nix: runtest -j 1, somehow GH ci is having issues with more

21f31f7

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

mseri added 3 commits June 9, 2022 10:28

ci: dont try to run eio tests in nix

36927d3

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

ci: disable js-tests

6afe32c

They are broken on the CI environments for various infrastructural reasons Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

ci: test eio and js with nix

e65f724

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

bikallem commented Jun 9, 2022

View reviewed changes

mseri added 2 commits June 9, 2022 12:08

ci: js-tests are broken also on nix

4158050

internal/modules/cjs/loader.js:905 throw err; ^ Error: Cannot find module 'xmlhttprequest' Fixing this requires knowing npm, yarn and node, so I will disable them for the moment Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

ci: don't test cohttp-eio on nix

2c436df

We need a nix user to know how to install ocaml 5.0.0+trunk on nix Signed-off-by: Marcello Seri <marcello.seri@gmail.com>

mseri merged commit 1dc4746 into mirage:master Jun 9, 2022

mseri mentioned this pull request Oct 24, 2022

[new release] http, cohttp, cohttp-top, cohttp-server-lwt-unix, cohttp-mirage, cohttp-lwt, cohttp-lwt-unix, cohttp-lwt-jsoo, cohttp-eio, cohttp-curl, cohttp-curl-lwt, cohttp-curl-async and cohttp-async (6.0.0~alpha0) ocaml/opam-repository#22353

Merged

bikallem deleted the eio-3 branch November 9, 2022 14:24

samoht mentioned this pull request Mar 3, 2025

[new release] cohttp (14 packages) (6.1.0) ocaml/opam-repository#27537

Merged

		@@ -0,0 +1,2 @@
		use nix shell-eio.nix
		eval $(opam env --shell=bash --inplace-path --set-switch)

		@@ -0,0 +1 @@
		(data_only_dirs cohttp-lwt-jsoo cohttp_lwt_jsoo_test)

Conversation

bikallem commented Feb 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mseri commented Feb 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avsm commented Feb 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mseri commented Feb 2, 2022

Uh oh!

rgrinberg commented Feb 2, 2022

Uh oh!

rgrinberg commented Feb 2, 2022

Uh oh!

rgrinberg Feb 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bikallem Feb 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tmattio commented Feb 2, 2022

Uh oh!

rgrinberg commented Feb 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bikallem commented Feb 2, 2022

Uh oh!

bikallem commented Feb 2, 2022

Uh oh!

tmattio commented Feb 2, 2022

Uh oh!

bikallem commented Feb 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rgrinberg commented Feb 3, 2022

Uh oh!

rgrinberg commented Feb 3, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bikallem commented Feb 1, 2022 •

edited

Loading

mseri commented Feb 1, 2022 •

edited

Loading

rgrinberg Feb 2, 2022 •

edited

Loading

bikallem Feb 2, 2022 •

edited

Loading

rgrinberg commented Feb 2, 2022 •

edited

Loading

bikallem commented Feb 2, 2022 •

edited

Loading

mseri commented Jun 8, 2022 •

edited

Loading