Draft
Conversation
Author
|
cc. @baywet |
baywet
reviewed
Feb 6, 2024
baywet
left a comment
There was a problem hiding this comment.
Thanks for putting this together! A couple of comments.
Comment on lines
+35
to
+37
| - name: Install kiota | ||
| run: dotnet tool install --global Microsoft.OpenApi.Kiota --prerelease | ||
|
|
There was a problem hiding this comment.
Suggested change
| - name: Install kiota | |
| run: dotnet tool install --global Microsoft.OpenApi.Kiota --prerelease |
Comment on lines
+27
to
+29
| - uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: '8.x.x' |
There was a problem hiding this comment.
Suggested change
| - uses: actions/setup-dotnet@v4 | |
| with: | |
| dotnet-version: '8.x.x' | |
| - uses: microsoft/setup-kiota@v0.5.0 |
Author
There was a problem hiding this comment.
I'm happy to go in the direction you are proposing, but, currently, the installation of the tools is based on dotnet tool install, if we move to the specific GH Action it would be best to update all of the jobs.
Looking for the maintainers of this project guidance here.
andreaTP
commented
Feb 8, 2024
| -d schemas/downloaded.json \ | ||
| --serializer none \ | ||
| --deserializer none \ | ||
| --exclude-path "/repos/{template_owner}/{template_repo}/generate" \ |
Author
There was a problem hiding this comment.
cc. @baywet this seems to be a viable workaround for microsoft/kiota#4151 I think we should apply it to the Go generation script as it's affected too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @kfcampbell and @nickfloyd 👋 ,
after the work we have done in Kiota on Java it would be great to start distributing a Java SDK 😄
Here I started to spearhead the effort, but it will require some help on your side to be finalized, e.g. creating the
java-sdkrepository.The generated code can be compiled using Maven with a minimal
pom.xmllike:Happy to answer any questions and assist in the process!