Skip to content

feat: v5#343

Merged
gr2m merged 10 commits intomainfrom
beta
Jun 20, 2023
Merged

feat: v5#343
gr2m merged 10 commits intomainfrom
beta

Conversation

@gr2m
Copy link
Copy Markdown
Contributor

@gr2m gr2m commented Sep 10, 2022

Breaking changes

  • drop onUnhandledRequest middleware option
  • returns a 404 response for unknown routes
  • drop support for NodeJS v14, v16

BREAKING CHANGE: drop `onUnhandledRequest` middleware option
@gr2m gr2m marked this pull request as draft September 10, 2022 20:59
@gr2m
Copy link
Copy Markdown
Contributor Author

gr2m commented Sep 10, 2022

fyi @baoshan ☝🏼

@gr2m gr2m added the Type: Feature New feature or request label Sep 10, 2022
@wolfy1339 wolfy1339 added the Type: Breaking change Used to note any change that requires a major version bump label Nov 7, 2022
wolfy1339 and others added 7 commits April 28, 2023 14:00
@wolfy1339 wolfy1339 marked this pull request as ready for review June 18, 2023 18:33
Copy link
Copy Markdown
Contributor

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've resolved the merge conflict in package-lock.json by regenerating the file during the merge. I think this is good to go now!

@gr2m gr2m merged commit 7a781c5 into main Jun 20, 2023
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wolfy1339
Copy link
Copy Markdown
Member

Fyi this depends on the beta version of @octokit/core, we should get that taken care of ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants