Remove onUnhandledRequest middleware option#341
Merged
gr2m merged 2 commits intooctokit:betafrom Sep 10, 2022
Merged
Conversation
gr2m
reviewed
Sep 8, 2022
Contributor
gr2m
left a comment
There was a problem hiding this comment.
I suggest we release this as a beta to verify that @octokit/app still works without the onUnhandledRequest hook and to verify that you can easily build middleware.
gr2m
reviewed
Sep 8, 2022
882f7ac to
4e5da8a
Compare
4e5da8a to
6f5f025
Compare
Contributor
Author
|
There is also a draft PR for |
Contributor
|
I've updated both PRs to merge into Can you add |
BREAKING CHANGE: drop onUnhandledRequest middleware option support
6f5f025 to
f14ff6d
Compare
Contributor
Author
|
Thanks. I’ve appended a |
|
🎉 This PR is included in version 5.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on the idea that Octokit middlewares (not limited to
oauth-app.js) respect below proposed principle:pathPrefix(returns a predictable404response for unknown routes)pathPrefix(but could be easily customized in an idiomatic way of the specific framework/runtime)This PR also removes the (already deprecated) Cloudflare handler because this is a breaking change which leads to a major version bump.