fix(middleware): oauth-app has no onUnhandledRequest option#337
Merged
gr2m merged 1 commit intooctokit:betafrom Sep 15, 2022
Merged
fix(middleware): oauth-app has no onUnhandledRequest option#337gr2m merged 1 commit intooctokit:betafrom
gr2m merged 1 commit intooctokit:betafrom
Conversation
oscard0m
reviewed
Sep 10, 2022
Contributor
|
@baoshan is this PR ready for review / beta release? |
Contributor
Author
|
Thanks. Please review it. I’ll open another PR once |
Contributor
Author
|
This is the PR to |
Member
|
This needs a final rebase |
wolfy1339
approved these changes
Sep 12, 2022
f0a1d63 to
a8538e5
Compare
Contributor
Author
|
Rebased. Depends on |
98d18a1 to
311f618
Compare
gr2m
reviewed
Sep 12, 2022
311f618 to
ca19ae5
Compare
BREAKING CHANGE: onUnhandledRequest middleware option is removed
ca19ae5 to
f55d03a
Compare
gr2m
approved these changes
Sep 15, 2022
Contributor
gr2m
left a comment
There was a problem hiding this comment.
I didn't have the time to thoroughly review it and I won't be able to soon. But I don't want you to get blocked and really appreciate all your work you put into this, so I'm going to merge it into beta.
|
🎉 This PR is included in version 14.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR keeps
app.jsupdated if we could remove theonUnhandledRequestoption fromoauth-app.js.Related PR: #341