Skip to content

test(refactor): use 'toEqual' instead of 'toStrictEqual' with JSON.stringify in Response assertions#589

Merged
oscard0m merged 1 commit intomainfrom
migrate-response-assertions-from-toStrinctEqual-to-toEqual
Jul 19, 2023
Merged

test(refactor): use 'toEqual' instead of 'toStrictEqual' with JSON.stringify in Response assertions#589
oscard0m merged 1 commit intomainfrom
migrate-response-assertions-from-toStrinctEqual-to-toEqual

Conversation

@oscard0m
Copy link
Copy Markdown
Member

@oscard0m oscard0m commented Jul 19, 2023

Resolves #590


Behavior

Before the change?

Test assertions of Responses from fetch-mock are done with jest.toStrictEqual with JSON.stringify

After the change?

Test assertions of Responses from fetch-mock are done with jest.toEqual

Other information

More context in #588


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Type: Maintenance


…ringify in Response assertions

More context in #588
@oscard0m oscard0m added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 19, 2023
Copy link
Copy Markdown
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this @oscard0m ❤️

@oscard0m oscard0m merged commit 00919b6 into main Jul 19, 2023
@oscard0m oscard0m deleted the migrate-response-assertions-from-toStrinctEqual-to-toEqual branch July 19, 2023 14:12
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Replace toStrictEqual with JSON.stringify Response assertions with toEqual in core.js

2 participants