Avoid JSON.stringify hack when testing responses of fetch-mock #588
Description
Affected repos:
- feat: v20 rest.js#305
- feat: v5 #563
- fix(deps): update octokit monorepo (major) action.js#513
- build(deps): lock file maintenance auth-app.js#498
- feat: v5 oauth-app.js#343
- Replace
toStrictEqualwithJSON.stringifyResponse assertions withtoEqualincore.js#590 - Replace
toStrictEqualwithJSON.stringifyResponse assertions withtoEqualinrest.jsrest.js#328 - Replace
toStrictEqualwithJSON.stringifyResponse assertions withtoEqualinaction.jsaction.js#515 - Replace
toMatchObjectResponse assertions withtoEqualinauth-app.jsauth-app.js#506 - Replace
toMatchObjectResponse assertions withtoEqualinoauth-app.jsoauth-app.js#437
this should not be necessary, but if it's tricky we can do a follow up issue. It slows down tests, makes order of keys significant, and will be harder to debug when they don't match.
Originally posted by @gr2m in #563 (comment)
Metadata
Metadata
Assignees
Type
Projects
Status