Skip to content

test(refactor): test(refactor): use 'toEqual' instead of 'toMatchObject' for Responses#507

Merged
oscard0m merged 1 commit intomainfrom
migrate-response-assertions-from-toMatchObject-to-toEqual
Jul 19, 2023
Merged

test(refactor): test(refactor): use 'toEqual' instead of 'toMatchObject' for Responses#507
oscard0m merged 1 commit intomainfrom
migrate-response-assertions-from-toMatchObject-to-toEqual

Conversation

@oscard0m
Copy link
Copy Markdown
Member

@oscard0m oscard0m commented Jul 19, 2023

Resolves #506


Behavior

Before the change?

Test assertions of Responses from fetch-mock are done with jest.toMatchObject

After the change?

Test assertions of Responses from fetch-mock are done with jest.toEqual

Other information

More context in octokit/core.js#588


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Type: Maintenance


@oscard0m oscard0m added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 19, 2023
@oscard0m oscard0m merged commit 29c8044 into main Jul 19, 2023
@oscard0m oscard0m deleted the migrate-response-assertions-from-toMatchObject-to-toEqual branch July 19, 2023 14:20
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Replace toMatchObject Response assertions with toEqual in auth-app.js

2 participants