Skip to content

chore: update package.json for bundler module resolution#63

Merged
octet-stream merged 3 commits into
octet-stream:mainfrom
louisgv:patch-1
May 30, 2023
Merged

chore: update package.json for bundler module resolution#63
octet-stream merged 3 commits into
octet-stream:mainfrom
louisgv:patch-1

Conversation

@louisgv

@louisgv louisgv commented May 28, 2023

Copy link
Copy Markdown
Contributor

When setting moduleResolution: bundler, in TS5, the current exports will not work. Error:

There are types at '/node_modules/formdata-node/@type/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'formdata-node' library may need to update its package.json or typings.ts(7016)

louisgv added 3 commits May 28, 2023 15:29
…tion

When setting moduleResolution: bundler, in TS5, the current exports will not work. Error:

There are types at '/node_modules/formdata-node/@type/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'formdata-node' library may need to update its package.json or typings.ts(7016)
@octet-stream

octet-stream commented May 30, 2023

Copy link
Copy Markdown
Owner

LGTM, but the change is supposed to be made in 5.x branch, because main is for upcoming major release. I will backport and update 5.x version myself, no worries.

@octet-stream octet-stream merged commit 82d2811 into octet-stream:main May 30, 2023
@octet-stream

octet-stream commented May 30, 2023

Copy link
Copy Markdown
Owner

Your fix is available in https://github.com/octet-stream/form-data/releases/tag/v5.0.1

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants