Clarify the Lwt.pick#650
Merged
aantron merged 1 commit intoocsigen:masterfrom Jan 8, 2019
bikallem:patch-1
Merged
Conversation
Clarify that promises created via Lwt.wait() are not cancellable.
Collaborator
|
Thanks! |
MisterDA
added a commit
to MisterDA/lwt
that referenced
this pull request
Dec 6, 2021
Unix.create_process duplicates the handles given to the child process if they're not inheritable. Mimic this behaviour in Lwt for consistency. See the following PRs: - [Unix library: better API for "close-on-exec" over file descriptors ocsigen#650](ocaml/ocaml#650); - [win32unix create_process: duplicate std handles in create_process iff they're not inheritable #10807](ocaml/ocaml#650).
MisterDA
added a commit
to MisterDA/lwt
that referenced
this pull request
Feb 1, 2022
Unix.create_process duplicates the handles given to the child process if they're not inheritable. Mimic this behaviour in Lwt for consistency. See the following PRs: - [Unix library: better API for "close-on-exec" over file descriptors ocsigen#650](ocaml/ocaml#650); - [win32unix create_process: duplicate std handles in create_process iff they're not inheritable #10807](ocaml/ocaml#650).
MisterDA
added a commit
to MisterDA/lwt
that referenced
this pull request
Feb 8, 2022
Unix.create_process duplicates the handles given to the child process if they're not inheritable. Mimic this behaviour in Lwt for consistency. See the following PRs: - [Unix library: better API for "close-on-exec" over file descriptors ocsigen#650](ocaml/ocaml#650); - [win32unix create_process: duplicate std handles in create_process iff they're not inheritable #10807](ocaml/ocaml#650).
MisterDA
added a commit
to MisterDA/lwt
that referenced
this pull request
Feb 25, 2022
Unix.create_process duplicates the handles given to the child process if they're not inheritable. Mimic this behaviour in Lwt for consistency. See the following PRs: - [Unix library: better API for "close-on-exec" over file descriptors ocsigen#650](ocaml/ocaml#650); - [win32unix create_process: duplicate std handles in create_process iff they're not inheritable #10807](ocaml/ocaml#650).
MisterDA
added a commit
to MisterDA/lwt
that referenced
this pull request
Feb 28, 2022
Unix.create_process duplicates the handles given to the child process if they're not inheritable. Mimic this behaviour in Lwt for consistency. See the following PRs: - [Unix library: better API for "close-on-exec" over file descriptors ocsigen#650](ocaml/ocaml#650); - [win32unix create_process: duplicate std handles in create_process iff they're not inheritable #10807](ocaml/ocaml#650).
MisterDA
added a commit
to MisterDA/lwt
that referenced
this pull request
Feb 28, 2022
Unix.create_process duplicates the handles given to the child process if they're not inheritable. Mimic this behaviour in Lwt for consistency. See the following PRs: - [Unix library: better API for "close-on-exec" over file descriptors ocsigen#650](ocaml/ocaml#650); - [win32unix create_process: duplicate std handles in create_process iff they're not inheritable #10807](ocaml/ocaml#650).
MisterDA
added a commit
to MisterDA/lwt
that referenced
this pull request
Feb 28, 2022
Unix.create_process duplicates the handles given to the child process if they're not inheritable. Mimic this behaviour in Lwt for consistency. See the following PRs: - [Unix library: better API for "close-on-exec" over file descriptors ocsigen#650](ocaml/ocaml#650); - [win32unix create_process: duplicate std handles in create_process iff they're not inheritable #10807](ocaml/ocaml#650).
MisterDA
added a commit
to MisterDA/lwt
that referenced
this pull request
Mar 18, 2022
Unix.create_process duplicates the handles given to the child process if they're not inheritable. Mimic this behaviour in Lwt for consistency. See the following PRs: - [Unix library: better API for "close-on-exec" over file descriptors ocsigen#650](ocaml/ocaml#650); - [win32unix create_process: duplicate std handles in create_process iff they're not inheritable #10807](ocaml/ocaml#650).
smorimoto
pushed a commit
to MisterDA/lwt
that referenced
this pull request
Apr 3, 2022
Unix.create_process duplicates the handles given to the child process if they're not inheritable. Mimic this behaviour in Lwt for consistency. See the following PRs: - [Unix library: better API for "close-on-exec" over file descriptors ocsigen#650](ocaml/ocaml#650); - [win32unix create_process: duplicate std handles in create_process iff they're not inheritable #10807](ocaml/ocaml#650).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that promises created via Lwt.wait() are not cancellable.