Skip to content

Lwt_unix: add support for joining/leaving multicast groups#143

Merged
vbmithr merged 1 commit intoocsigen:masterfrom
nojb:mcast
Apr 4, 2015
Merged

Lwt_unix: add support for joining/leaving multicast groups#143
vbmithr merged 1 commit intoocsigen:masterfrom
nojb:mcast

Conversation

@nojb
Copy link
Copy Markdown
Contributor

@nojb nojb commented Apr 3, 2015

This patch adds bindings to be able to join and leave IPv4 multicast groups. As far as I know currently the only libraries where this functions are bound are JS core and ocamlnet. Both are inconvenient to use with lwt.

@vbmithr
Copy link
Copy Markdown
Member

vbmithr commented Apr 4, 2015

Awesome, much appreciated! (at least by me ;) )

Can you please add a test that covers this code (like the ones in tests/unix).
Thanks

@nojb
Copy link
Copy Markdown
Contributor Author

nojb commented Apr 4, 2015

Added the tests in e6ae14c. Thanks!

@vbmithr
Copy link
Copy Markdown
Member

vbmithr commented Apr 4, 2015

Amazing, thanks.

@vbmithr vbmithr merged commit e6ae14c into ocsigen:master Apr 4, 2015
nojb added a commit to nojb/ocaml-bt that referenced this pull request Apr 4, 2015
@aantron aantron mentioned this pull request Jan 15, 2018
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants